mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-05-14 02:46:57 +02:00
568b7ce7ea
The Paintable tree and its supplemental painting data structures were GC allocated because that was the easiest way to manage it and avoid leaks introduced by ref cycles. This included the Paintable subclasses themselves plus StackingContext, ChromeWidget, Scrollbar, ResizeHandle, and scroll-frame state. We are now trying to reduce GC allocation churn on layout and painting updates, so keeping this short-lived rendering tree outside the JS heap is a better fit. Move Paintable to RefCountedTreeNode, make painting helpers ref-counted or weakly reference Paintables, and update the layout and event-handler call sites to use RefPtr/WeakPtr ownership.
106 lines
4.6 KiB
C++
106 lines
4.6 KiB
C++
/*
|
|
* Copyright (c) 2025, Jonathan Gamble <gamblej@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibGC/WeakInlines.h>
|
|
#include <LibWeb/CSS/CSSStyleProperties.h>
|
|
#include <LibWeb/CSS/PropertyID.h>
|
|
#include <LibWeb/DOM/Element.h>
|
|
#include <LibWeb/Page/ElementResizeAction.h>
|
|
#include <LibWeb/Painting/ChromeMetrics.h>
|
|
#include <LibWeb/Painting/PaintableBox.h>
|
|
|
|
// https://drafts.csswg.org/css-ui#resize
|
|
|
|
namespace Web {
|
|
|
|
static Optional<CSSPixelSize> containing_block_padding_box_size(Layout::Node const& layout_node)
|
|
{
|
|
auto parent_box = layout_node.containing_block();
|
|
if (!parent_box)
|
|
return {};
|
|
if (auto first_paintable = parent_box->first_paintable(); auto const* paintable_box = as_if<Painting::PaintableBox>(first_paintable.ptr()))
|
|
return paintable_box->absolute_padding_box_rect().size();
|
|
return {};
|
|
}
|
|
|
|
ElementResizeAction::ElementResizeAction(GC::Ref<DOM::Element> element, CSSPixelPoint pointer_down_origin)
|
|
: m_element(element)
|
|
, m_pointer_down_origin(pointer_down_origin)
|
|
{
|
|
auto paintable_box = element->paintable_box();
|
|
if (paintable_box)
|
|
m_initial_border_box_size = paintable_box->absolute_border_box_rect().size();
|
|
}
|
|
|
|
void ElementResizeAction::handle_pointer_move(CSSPixelPoint pointer_position)
|
|
{
|
|
auto element = m_element.ptr();
|
|
if (!element || !element->is_connected())
|
|
return;
|
|
|
|
auto paintable_box = element->paintable_box();
|
|
if (!paintable_box)
|
|
return;
|
|
auto const& layout_node = paintable_box->layout_node();
|
|
auto const& computed = layout_node.computed_values();
|
|
auto resize = computed.resize();
|
|
if (resize == CSS::Resize::None)
|
|
return;
|
|
|
|
bool horizontal_writing_mode = computed.writing_mode() == CSS::WritingMode::HorizontalTb;
|
|
bool resize_x = computed.resize() == CSS::Resize::Both
|
|
|| computed.resize() == CSS::Resize::Horizontal
|
|
|| (computed.resize() == CSS::Resize::Inline && horizontal_writing_mode)
|
|
|| (computed.resize() == CSS::Resize::Block && !horizontal_writing_mode);
|
|
|
|
bool resize_y = computed.resize() == CSS::Resize::Both
|
|
|| computed.resize() == CSS::Resize::Vertical
|
|
|| (computed.resize() == CSS::Resize::Inline && !horizontal_writing_mode)
|
|
|| (computed.resize() == CSS::Resize::Block && horizontal_writing_mode);
|
|
|
|
CSSPixels dx = resize_x ? pointer_position.x() - m_pointer_down_origin.x() : 0;
|
|
CSSPixels dy = resize_y ? pointer_position.y() - m_pointer_down_origin.y() : 0;
|
|
auto writing_mode = computed.writing_mode();
|
|
if ((writing_mode == CSS::WritingMode::HorizontalTb && computed.direction() == CSS::Direction::Rtl)
|
|
|| writing_mode == CSS::WritingMode::VerticalRl
|
|
|| writing_mode == CSS::WritingMode::SidewaysRl) {
|
|
dx = -dx;
|
|
}
|
|
CSSPixels css_width = max(ChromeMetrics::ZOOM_INVARIANT_RESIZE_GRIPPER_SIZE, m_initial_border_box_size.width() + dx);
|
|
CSSPixels css_height = max(ChromeMetrics::ZOOM_INVARIANT_RESIZE_GRIPPER_SIZE, m_initial_border_box_size.height() + dy);
|
|
|
|
auto reference_basis = containing_block_padding_box_size(layout_node);
|
|
|
|
if (reference_basis.has_value()) {
|
|
if (auto const& min_width = computed.min_width(); !min_width.is_auto()) {
|
|
css_width = max(css_width, min_width.to_px(layout_node, reference_basis->width()));
|
|
}
|
|
if (auto const& max_width = computed.max_width(); !max_width.is_none()) {
|
|
css_width = min(css_width, max_width.to_px(layout_node, reference_basis->width()));
|
|
}
|
|
if (auto const& min_height = computed.min_height(); !min_height.is_auto()) {
|
|
css_height = max(css_height, min_height.to_px(layout_node, reference_basis->height()));
|
|
}
|
|
if (auto const& max_height = computed.max_height(); !max_height.is_none()) {
|
|
css_height = min(css_height, max_height.to_px(layout_node, reference_basis->height()));
|
|
}
|
|
}
|
|
if (computed.box_sizing() == CSS::BoxSizing::ContentBox) {
|
|
auto const& metrics = paintable_box->box_model();
|
|
css_width -= metrics.padding.left + metrics.padding.right + computed.border_left().width + computed.border_right().width;
|
|
css_height -= metrics.padding.top + metrics.padding.bottom + computed.border_top().width + computed.border_bottom().width;
|
|
}
|
|
|
|
auto style = element->style_for_bindings();
|
|
auto width_str = MUST(String::formatted("{:.2f}px", max(0.0, css_width.to_double())));
|
|
auto height_str = MUST(String::formatted("{:.2f}px", max(0.0, css_height.to_double())));
|
|
|
|
MUST(style->set_property(CSS::PropertyID::Width, width_str));
|
|
MUST(style->set_property(CSS::PropertyID::Height, height_str));
|
|
}
|
|
|
|
}
|