Andreas Kling e28ac74e0b LibWeb: Queue a task to proceed after module map entry finishes fetching ...

We were doing this synchronously, which was unsafe in that caused us to
re-enter the module map entry setting code while iterating over the
map's entries.

The fix is simply to do what the spec says and queue up a task. This way
the processing gets deferred to a later time.

To avoid stepping into this problem again, I've also added a reentrancy
check in ModuleMap.

This fixes a sporadic crash in HTML::ModuleMap::add() caught by ASAN.
In particular, this was happening regularly on https://shopify.com/

2023-12-16 20:47:16 +01:00

1.9 KiB

Raw Blame History

View Raw