eliott/ort
1
0
Fork 0
mirror of https://github.com/pykeio/ort synced 2026-04-25 16:34:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: replace usage of assume_init_mut with as_mut_ptr (#562)

Browse Source 
Usage of assume_init_mut is unsafe if the memory is uninitialized, as
forming a reference to uninitialized memory is undefined behavior. Using
&raw mut prevents the creation of an unsafe intermediate reference.
This commit is contained in:
imjakingit
2026-03-27 22:12:48 -07:00
committed by GitHub
parent 17ed727770
commit d85e776925
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/session/mod.rs
View File

@@ -467,18 +467,18 @@ impl Session {
unsafe {
use core::ptr::write;
let ctx = ctx.assume_init_mut();
write(&mut ctx.inner, Arc::clone(&async_inner));
let ctx = ctx.as_mut_ptr();
write(&raw mut (*ctx).inner, Arc::clone(&async_inner));
// everything allocated within `run_inner_async` needs to be kept alive until we are certain inference has completed and
// ONNX Runtime no longer needs the data - i.e. when `async_callback` is called. `async_callback` will free all of
// this data just like we do in `run_inner`
write(&mut ctx.input_ort_values, input_ort_values);
write(&mut ctx._input_inner_holders, input_inner_holders);
write(&mut ctx.input_name_ptrs, input_name_ptrs);
write(&mut ctx.output_name_ptrs, output_name_ptrs);
write(&mut ctx.output_names, output_names);
write(&mut ctx.output_value_ptrs, output_tensor_ptrs);
write(&mut ctx.session_inner, &self.inner);
write(&raw mut (*ctx).input_ort_values, input_ort_values);
write(&raw mut (*ctx)._input_inner_holders, input_inner_holders);
write(&raw mut (*ctx).input_name_ptrs, input_name_ptrs);
write(&raw mut (*ctx).output_name_ptrs, output_name_ptrs);
write(&raw mut (*ctx).output_names, output_names);
write(&raw mut (*ctx).output_value_ptrs, output_tensor_ptrs);
write(&raw mut (*ctx).session_inner, &self.inner);
};
let ctx = Box::leak(unsafe { ctx.assume_init() });
crate::logging::create!(AsyncInferenceContext, ctx);