eliott/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2026-05-05 22:52:10 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Throw when delete-ing a non-configurable property in strict mode

Browse Source
This commit is contained in:
Idan Horowitz
2021-06-16 13:13:01 +03:00
committed by Linus Groh
parent c619ad4fec
commit 07992c8da6
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Libraries/LibJS/Runtime/Object.cpp
View File

@@ -781,8 +781,11 @@ bool Object::delete_property(const PropertyName& property_name)
auto metadata = shape().lookup(property_name.to_string_or_symbol());
if (!metadata.has_value())
return true;
if (!metadata.value().attributes.is_configurable())
if (!metadata.value().attributes.is_configurable()) {
if (vm().in_strict_mode())
vm().throw_exception<TypeError>(global_object(), ErrorType::DescChangeNonConfigurable, property_name.to_string_or_symbol().to_display_string());
return false;
}
size_t deleted_offset = metadata.value().offset;