eliott/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2026-04-25 17:15:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Everywhere: Prefer = default; to define [con,des]tructors

Browse Source 
These lines would change with the new clang-format, so we might as well
use the preferred `= default`.
This commit is contained in:
Lucas CHOLLET
2025-10-08 15:27:36 +02:00
committed by Tim Schumacher
parent eb978a5053
commit 27e8dc5cbf
19 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
AK/RedBlackTree.h
View File

@@ -42,7 +42,7 @@ public:
Node()
{
}
virtual ~Node() {};
virtual ~Node() = default;
};
protected:

2
Kernel/Devices/Storage/NVMe/NVMeInterruptQueue.h
View File

@@ -16,7 +16,7 @@ class NVMeInterruptQueue : public NVMeQueue
public:
static ErrorOr<NonnullLockRefPtr<NVMeInterruptQueue>> try_create(PCI::Device& device, NonnullOwnPtr<Memory::Region> rw_dma_region, NonnullRefPtr<Memory::PhysicalRAMPage> rw_dma_page, u16 qid, u8 irq, u32 q_depth, OwnPtr<Memory::Region> cq_dma_region, OwnPtr<Memory::Region> sq_dma_region, Doorbell db_regs);
void submit_sqe(NVMeSubmission& submission) override;
virtual ~NVMeInterruptQueue() override {};
virtual ~NVMeInterruptQueue() override = default;
virtual StringView purpose() const override { return "NVMe"sv; }
void initialize_interrupt_queue();

2
Kernel/Devices/Storage/NVMe/NVMePollQueue.h
View File

@@ -14,7 +14,7 @@ class NVMePollQueue : public NVMeQueue {
public:
static ErrorOr<NonnullLockRefPtr<NVMePollQueue>> try_create(NonnullOwnPtr<Memory::Region> rw_dma_region, NonnullRefPtr<Memory::PhysicalRAMPage> rw_dma_page, u16 qid, u32 q_depth, OwnPtr<Memory::Region> cq_dma_region, OwnPtr<Memory::Region> sq_dma_region, Doorbell db_regs);
void submit_sqe(NVMeSubmission& submission) override;
virtual ~NVMePollQueue() override {};
virtual ~NVMePollQueue() override = default;
protected:
NVMePollQueue(NonnullOwnPtr<Memory::Region> rw_dma_region, NonnullRefPtr<Memory::PhysicalRAMPage> rw_dma_page, u16 qid, u32 q_depth, OwnPtr<Memory::Region> cq_dma_region, OwnPtr<Memory::Region> sq_dma_region, Doorbell db_regs);

2
Kernel/FileSystem/SysFS/Component.h
View File

@@ -92,7 +92,7 @@ public:
protected:
virtual bool is_root_directory() const { return false; }
SysFSDirectory() {};
SysFSDirectory() = default;
explicit SysFSDirectory(SysFSDirectory const& parent_directory);
ChildList m_child_components {};
};

2
Kernel/FileSystem/SysFS/Subsystems/Bus/PCI/DeviceAttribute.h
View File

@@ -18,7 +18,7 @@ public:
static NonnullRefPtr<PCIDeviceAttributeSysFSComponent> create(PCIDeviceSysFSDirectory const& device, PCI::RegisterOffset offset, size_t field_bytes_width);
virtual ErrorOr<size_t> read_bytes(off_t, size_t, UserOrKernelBuffer&, OpenFileDescription*) const override;
virtual ~PCIDeviceAttributeSysFSComponent() {};
virtual ~PCIDeviceAttributeSysFSComponent() = default;
virtual StringView name() const override;

2
Kernel/FileSystem/SysFS/Subsystems/Bus/PCI/DeviceExpansionROM.h
View File

@@ -18,7 +18,7 @@ public:
static NonnullRefPtr<PCIDeviceExpansionROMSysFSComponent> create(PCIDeviceSysFSDirectory const& device);
virtual ErrorOr<size_t> read_bytes(off_t, size_t, UserOrKernelBuffer&, OpenFileDescription*) const override;
virtual ~PCIDeviceExpansionROMSysFSComponent() {};
virtual ~PCIDeviceExpansionROMSysFSComponent() = default;
virtual StringView name() const override { return "rom"sv; }

2
Kernel/FileSystem/SysFS/Subsystems/Devices/Graphics/DisplayConnector/DeviceAttribute.h
View File

@@ -28,7 +28,7 @@ public:
static NonnullRefPtr<DisplayConnectorAttributeSysFSComponent> must_create(DisplayConnectorSysFSDirectory const& device_directory, Type);
virtual ErrorOr<size_t> read_bytes(off_t, size_t, UserOrKernelBuffer&, OpenFileDescription*) const override;
virtual ~DisplayConnectorAttributeSysFSComponent() {};
virtual ~DisplayConnectorAttributeSysFSComponent() = default;
virtual StringView name() const override;

2
Kernel/FileSystem/SysFS/Subsystems/Devices/Storage/DeviceAttribute.h
View File

@@ -24,7 +24,7 @@ public:
static NonnullRefPtr<StorageDeviceAttributeSysFSComponent> must_create(StorageDeviceSysFSDirectory const& device_directory, Type);
virtual ErrorOr<size_t> read_bytes(off_t, size_t, UserOrKernelBuffer&, OpenFileDescription*) const override;
virtual ~StorageDeviceAttributeSysFSComponent() {};
virtual ~StorageDeviceAttributeSysFSComponent() = default;
virtual StringView name() const override;

2
Userland/Applications/Help/ManualModel.h
View File

@@ -19,7 +19,7 @@ public:
return adopt_nonnull_ref_or_enomem(new (nothrow) ManualModel);
}
virtual ~ManualModel() override {};
virtual ~ManualModel() override = default;
Optional<GUI::ModelIndex> index_from_path(StringView) const;

2
Userland/Applications/KeyboardSettings/KeyboardSettingsWidget.cpp
View File

@@ -115,7 +115,7 @@ private:
class KeymapModel final : public GUI::Model {
public:
KeymapModel() {};
KeymapModel() = default;
int row_count(GUI::ModelIndex const&) const override { return m_data.size(); }
int column_count(GUI::ModelIndex const&) const override { return 1; }

2
Userland/Applications/PixelPaint/Filters/Filter.h
View File

@@ -26,7 +26,7 @@ public:
virtual StringView filter_name() const = 0;
virtual ~Filter() {};
virtual ~Filter() = default;
Filter(ImageEditor* editor);

2
Userland/Applications/PixelPaint/MainWidget.h
View File

@@ -37,7 +37,7 @@ class MainWidget : public GUI::Widget {
C_OBJECT(MainWidget);
public:
virtual ~MainWidget() {};
virtual ~MainWidget() = default;
ErrorOr<void> initialize_menubar(GUI::Window&);

2
Userland/Applications/SpaceAnalyzer/Tree.h
View File

@@ -49,7 +49,7 @@ public:
{
return adopt_nonnull_own_or_enomem(new (nothrow) Tree(move(root_name)));
}
~Tree() {};
~Tree() = default;
TreeNode& root()
{

2
Userland/Libraries/LibGUI/Button.h
View File

@@ -91,7 +91,7 @@ class DialogButton final : public Button {
C_OBJECT(DialogButton);
public:
virtual ~DialogButton() override {};
virtual ~DialogButton() override = default;
explicit DialogButton(String text = {})
: Button(move(text))
{

2
Userland/Libraries/LibGfx/Font/Font.h
View File

@@ -154,7 +154,7 @@ public:
virtual NonnullRefPtr<Font> clone() const = 0;
virtual ErrorOr<NonnullRefPtr<Font>> try_clone() const = 0;
virtual ~Font() {};
virtual ~Font() = default;
virtual FontPixelMetrics pixel_metrics() const = 0;

6
Userland/Libraries/LibJS/AST.h
View File

@@ -720,7 +720,7 @@ public:
virtual bool has_name() const = 0;
virtual Value instantiate_ordinary_function_expression(VM&, DeprecatedFlyString given_name) const = 0;
virtual ~FunctionNode() {};
virtual ~FunctionNode() = default;
protected:
FunctionNode(RefPtr<Identifier const> name, ByteString source_text, NonnullRefPtr<Statement const> body, Vector<FunctionParameter> parameters, i32 function_length, FunctionKind kind, bool is_strict_mode, FunctionParsingInsights parsing_insights, bool is_arrow_function, Vector<DeprecatedFlyString> local_variables_names)
@@ -780,7 +780,7 @@ public:
bool has_name() const override { return true; }
Value instantiate_ordinary_function_expression(VM&, DeprecatedFlyString) const override { VERIFY_NOT_REACHED(); }
virtual ~FunctionDeclaration() {};
virtual ~FunctionDeclaration() = default;
private:
bool m_is_hoisted { false };
@@ -807,7 +807,7 @@ public:
Value instantiate_ordinary_function_expression(VM&, DeprecatedFlyString given_name) const override;
virtual ~FunctionExpression() {};
virtual ~FunctionExpression() = default;
private:
virtual bool is_function_expression() const override { return true; }

2
Userland/Libraries/LibMedia/VideoDecoder.h
View File

@@ -16,7 +16,7 @@ namespace Media {
class VideoDecoder {
public:
virtual ~VideoDecoder() {};
virtual ~VideoDecoder() = default;
virtual DecoderErrorOr<void> receive_sample(Duration timestamp, ReadonlyBytes sample) = 0;
DecoderErrorOr<void> receive_sample(Duration timestamp, ByteBuffer const& sample) { return receive_sample(timestamp, sample.span()); }

2
Userland/Libraries/LibWeb/Painting/PaintStyle.h
View File

@@ -51,7 +51,7 @@ public:
ReadonlySpan<ColorStop> color_stops() const { return m_color_stops; }
Optional<float> repeat_length() const { return m_repeat_length; }
virtual ~SVGGradientPaintStyle() {};
virtual ~SVGGradientPaintStyle() = default;
protected:
Vector<ColorStop, 4> m_color_stops;

2
Userland/Utilities/shot.cpp
View File

@@ -27,7 +27,7 @@
class SelectableLayover final : public GUI::Widget {
C_OBJECT(SelectableLayover)
public:
virtual ~SelectableLayover() override {};
virtual ~SelectableLayover() override = default;
Gfx::IntRect region() const
{