eliott/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2026-04-25 17:15:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

AK: Use correct built-in overload for several math functions

Browse Source 
sqrt, sin, cos, tan, atan, atan2, log, log10 used to always call the
double built-in.

Now the float overload calls the float built-in, the double overload the
double built-in, and the long double overload the long double built-in.

Ideally, we'd stop calling built-ins for these (see #26662),
but as long as we do, we should call the right ones.

Similar to the last two commits in #18998.
This commit is contained in:
Nico Weber
2026-04-04 20:33:15 -04:00
committed by Sönke Holz
parent b81d9d040d
commit 65209b7a9a
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
AK/Math.h
View File

@@ -598,7 +598,7 @@ constexpr T sqrt(T x)
// TODO: Add implementation for this function.
TODO();
# endif
return __builtin_sqrt(x);
CALL_BUILTIN(sqrt, x);
#endif
}
@@ -706,7 +706,7 @@ constexpr T sin(T angle)
T angle_squared = angle * angle;
return sign * (angle + angle * angle_squared * f(angle_squared));
# else
return __builtin_sin(angle);
CALL_BUILTIN(sin, angle);
# endif
#endif
}
@@ -769,7 +769,7 @@ constexpr T cos(T angle)
T angle_squared = angle * angle;
return sign * (1 + angle_squared * f(angle_squared));
# else
return __builtin_cos(angle);
CALL_BUILTIN(cos, angle);
# endif
#endif
}
@@ -810,7 +810,7 @@ constexpr T tan(T angle)
# if defined(AK_OS_SERENITY)
return sin(angle) / cos(angle);
# else
return __builtin_tan(angle);
CALL_BUILTIN(tan, angle);
# endif
#endif
}
@@ -923,7 +923,7 @@ constexpr T atan(T value)
T squared = value * value;
return value + value * squared * f(squared);
# endif
return __builtin_atan(value);
CALL_BUILTIN(atan, value);
#endif
}
@@ -1001,7 +1001,7 @@ constexpr T atan2(T y, T x)
// y < 0 && x > 0
return atan(y / x);
# else
return __builtin_atan2(y, x);
CALL_BUILTIN(atan2, y, x);
# endif
#endif
}
@@ -1120,7 +1120,7 @@ constexpr T log(T x)
// FIXME: Adjust the polynomial and formula in log2 to fit this
return log2<T>(x) / L2_E<T>;
#else
return __builtin_log(x);
CALL_BUILTIN(log, x);
#endif
}
@@ -1142,7 +1142,7 @@ constexpr T log10(T x)
// FIXME: Adjust the polynomial and formula in log2 to fit this
return log2<T>(x) / L2_10<T>;
#else
return __builtin_log10(x);
CALL_BUILTIN(log10, x);
#endif
}