eliott/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2026-05-14 10:56:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Update spec steps for destroying a DOM document

Browse Source 
This just updates our copied spec steps - new steps are not implemented
here. This is mostly just to highlight new steps we are missing around
MessagePorts.

No behavior change, but this does resolve an outstanding FIXME around
spec step ordering.

(cherry picked from commit 83be2606dba7ac430bab4d61a70e926d12d452ee)
This commit is contained in:
Timothy Flynn
2024-10-17 07:43:34 -04:00
committed by Nico Weber
parent cc4c7917d5
commit fb4e032c8f
1 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
Userland/Libraries/LibWeb/DOM/Document.cpp
View File

@@ -3273,22 +3273,26 @@ void Document::run_unloading_cleanup_steps()
// https://html.spec.whatwg.org/multipage/document-lifecycle.html#destroy-a-document
void Document::destroy()
{
// NOTE: Abort needs to happen before destory. There is currently bug in the spec: https://github.com/whatwg/html/issues/9148
// 4. Abort document.
// FIXME: 1. Assert: this is running as part of a task queued on document's relevant agent's event loop.
// 2. Abort document.
abort();
// 2. Set document's salvageable state to false.
// 3. Set document's salvageable state to false.
m_salvageable = false;
// 3. Run any unloading document cleanup steps for document that are defined by this specification and other applicable specifications.
// FIXME: 4. Let ports be the list of MessagePorts whose relevant global object's associated Document is document.
// FIXME: 5. For each port in ports, disentangle port.
// 6. Run any unloading document cleanup steps for document that are defined by this specification and other applicable specifications.
run_unloading_cleanup_steps();
// 5. Remove any tasks whose document is document from any task queue (without running those tasks).
// 7. Remove any tasks whose document is document from any task queue (without running those tasks).
HTML::main_thread_event_loop().task_queue().remove_tasks_matching([this](auto& task) {
return task.document() == this;
});
// 6. Set document's browsing context to null.
// 8. Set document's browsing context to null.
m_browsing_context = nullptr;
// Not in the spec:
@@ -3297,14 +3301,12 @@ void Document::destroy()
HTML::all_navigables().remove(navigable_container->content_navigable());
}
// 7. Set document's node navigable's active session history entry's document state's document to null.
if (navigable()) {
navigable()->active_session_history_entry()->document_state()->set_document(nullptr);
}
// 9. Set document's node navigable's active session history entry's document state's document to null.
if (auto navigable = this->navigable())
navigable->active_session_history_entry()->document_state()->set_document(nullptr);
// FIXME: 8. Remove document from the owner set of each WorkerGlobalScope object whose set contains document.
// FIXME: 9. For each workletGlobalScope in document's worklet global scopes, terminate workletGlobalScope.
// FIXME: 10. Remove document from the owner set of each WorkerGlobalScope object whose set contains document.
// FIXME: 11. For each workletGlobalScope in document's worklet global scopes, terminate workletGlobalScope.
}
// https://html.spec.whatwg.org/multipage/browsing-the-web.html#make-document-unsalvageable