mirror of
https://github.com/servo/servo
synced 2026-04-25 17:15:48 +02:00
release: Only mark scheduled runs as latest nightly. (#44086)
If we make manual releases, e.g. for release candidate testing, then they shouldn't appear on the nightly download page on servo.org, which just displays the release that is marked as "latest". Since the Github API documentation updated to a new API version, also opt-in to the new version while we are at it. There seem to be no changes affecting the usage in release.yml, but probably the old API will be removed eventually, so why not switch to the new version now. See https://docs.github.com/en/rest/releases/releases?apiVersion=2026-03-10#create-a-release Testing: [Manual release workflow run](https://github.com/servo/servo/actions/runs/24241705213). The release should not be marked as latest after the run finishes. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
This commit is contained in:
committed by
GitHub
parent
046a8346c8
commit
03a7d42cf5
19
.github/workflows/release.yml
vendored
19
.github/workflows/release.yml
vendored
@@ -46,7 +46,7 @@ jobs:
|
||||
TEMP_TAG=$(basename "$RELEASE_URL")
|
||||
RELEASE_ID=$( \
|
||||
gh api -H "Accept: application/vnd.github+json" \
|
||||
-H "X-GitHub-Api-Version: 2022-11-28" \
|
||||
-H "X-GitHub-Api-Version: 2026-03-10" \
|
||||
"/repos/${RELEASE_REPO}/releases/tags/${TEMP_TAG}" \
|
||||
| jq '.id' \
|
||||
)
|
||||
@@ -67,24 +67,29 @@ jobs:
|
||||
name: Publish GH Release
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- name: Publish as latest (success)
|
||||
- name: Publish release (success)
|
||||
if: ${{ !contains(needs.*.result, 'failure') && (!contains(needs.*.result, 'cancelled') && !cancelled()) }}
|
||||
env:
|
||||
MAKE_LATEST: ${{ github.event_name == 'schedule' && 'true' || 'false' }}
|
||||
run: |
|
||||
gh api \
|
||||
--method PATCH \
|
||||
-H "Accept: application/vnd.github+json" \
|
||||
-H "X-GitHub-Api-Version: 2022-11-28" \
|
||||
-H "X-GitHub-Api-Version: 2026-03-10" \
|
||||
/repos/${RELEASE_REPO}/releases/${RELEASE_ID} \
|
||||
-F draft=false
|
||||
- name: Publish as latest (failure)
|
||||
-F draft=false \
|
||||
-f make_latest="${MAKE_LATEST}"
|
||||
- name: Publish release (failure)
|
||||
if: ${{ contains(needs.*.result, 'failure') || (contains(needs.*.result, 'cancelled') || cancelled()) }}
|
||||
run: |
|
||||
gh api \
|
||||
--method PATCH \
|
||||
-H "Accept: application/vnd.github+json" \
|
||||
-H "X-GitHub-Api-Version: 2022-11-28" \
|
||||
-H "X-GitHub-Api-Version: 2026-03-10" \
|
||||
/repos/${RELEASE_REPO}/releases/${RELEASE_ID} \
|
||||
-F prerelease=true -F draft=false
|
||||
-F prerelease=true \
|
||||
-F draft=false \
|
||||
-f make_latest=false
|
||||
env:
|
||||
GITHUB_TOKEN: ${{ inputs.regular_release && github.token || secrets.NIGHTLY_REPO_TOKEN }}
|
||||
RELEASE_ID: ${{ needs.create-draft-release.outputs.release-id }}
|
||||
|
||||
Reference in New Issue
Block a user