mirror of
https://github.com/servo/servo
synced 2026-04-30 11:27:28 +02:00
script: use Element::create instead of DOM struct constructors (#39325)
Creating elements by directly calling their interface constructors leads to some state not being intialized correctly (see #39285). It is also not in line with the specifications as many of them refer to the [`create an element`][1] algorithm when an element needs to be created, which directly maps to `Element::create` in the script crate. So, switch all such places where elements are created by script to use `Element::create`. [1]: https://dom.spec.whatwg.org/#concept-create-element Testing: Existing WPT tests. Fixes: #39285 Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
This commit is contained in:
committed by
GitHub
parent
2b261b02bf
commit
07b2ff5d60
@@ -5,7 +5,7 @@
|
||||
use std::cmp::Ordering;
|
||||
|
||||
use dom_struct::dom_struct;
|
||||
use html5ever::local_name;
|
||||
use html5ever::{QualName, local_name, ns};
|
||||
|
||||
use crate::dom::bindings::codegen::Bindings::ElementBinding::ElementMethods;
|
||||
use crate::dom::bindings::codegen::Bindings::HTMLCollectionBinding::HTMLCollectionMethods;
|
||||
@@ -20,7 +20,7 @@ use crate::dom::bindings::inheritance::Castable;
|
||||
use crate::dom::bindings::reflector::reflect_dom_object;
|
||||
use crate::dom::bindings::root::DomRoot;
|
||||
use crate::dom::bindings::str::DOMString;
|
||||
use crate::dom::element::Element;
|
||||
use crate::dom::element::{CustomElementCreationMode, Element, ElementCreator};
|
||||
use crate::dom::html::htmlcollection::{CollectionFilter, HTMLCollection};
|
||||
use crate::dom::html::htmloptionelement::HTMLOptionElement;
|
||||
use crate::dom::html::htmlselectelement::HTMLSelectElement;
|
||||
@@ -61,8 +61,15 @@ impl HTMLOptionsCollection {
|
||||
let document = root.owner_document();
|
||||
|
||||
for _ in 0..count {
|
||||
let element =
|
||||
HTMLOptionElement::new(local_name!("option"), None, &document, None, can_gc);
|
||||
let element = Element::create(
|
||||
QualName::new(None, ns!(html), local_name!("option")),
|
||||
None,
|
||||
&document,
|
||||
ElementCreator::ScriptCreated,
|
||||
CustomElementCreationMode::Asynchronous,
|
||||
None,
|
||||
can_gc,
|
||||
);
|
||||
let node = element.upcast::<Node>();
|
||||
root.AppendChild(node, can_gc)?;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user