eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-04-28 10:27:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

script: Refactors HTMLInputElement.rs into type specific files (#43325)

Browse Source 
Refactors HTMLInputElement.rs to split lots of type specific input code
into their own files. These SpecificInputTypes are responsible for their
own shadow trees and also for element specific data such as
FileInputType's filelist.

Testing: Covered by WPTs
Fixes: https://github.com/servo/servo/issues/38263
Fixes: https://github.com/servo/servo/issues/43351

Signed-off-by: Luke Warlow <lwarlow@igalia.com>
Co-authored-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
Luke Warlow
2026-03-26 11:59:22 +00:00
committed by GitHub
parent 75d6338825
commit 087c50657f
39 changed files with 3006 additions and 1674 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
components/script/dom/html/htmlformelement.rs
View File

@@ -68,13 +68,14 @@ use crate::dom::html::htmlelement::HTMLElement;
use crate::dom::html::htmlfieldsetelement::HTMLFieldSetElement;
use crate::dom::html::htmlformcontrolscollection::HTMLFormControlsCollection;
use crate::dom::html::htmlimageelement::HTMLImageElement;
use crate::dom::html::htmlinputelement::{HTMLInputElement, InputType};
use crate::dom::html::htmllabelelement::HTMLLabelElement;
use crate::dom::html::htmllegendelement::HTMLLegendElement;
use crate::dom::html::htmlobjectelement::HTMLObjectElement;
use crate::dom::html::htmloutputelement::HTMLOutputElement;
use crate::dom::html::htmlselectelement::HTMLSelectElement;
use crate::dom::html::htmltextareaelement::HTMLTextAreaElement;
use crate::dom::html::input_element::HTMLInputElement;
use crate::dom::input_element::input_type::InputType;
use crate::dom::node::{
BindContext, Node, NodeFlags, NodeTraits, UnbindContext, VecPreOrderInsertionHelper,
};
@@ -168,7 +169,7 @@ impl HTMLFormElement {
{
if let Some(inp) = child.downcast::<HTMLInputElement>() {
// input, only return it if it's not image-button state
return inp.input_type() != InputType::Image;
return !matches!(*inp.input_type(), InputType::Image(_));
} else {
// control, but not an input
return true;
@@ -382,7 +383,7 @@ impl HTMLFormElementMethods<crate::DomTypeHolder> for HTMLFormElement {
},
HTMLElementTypeId::HTMLInputElement => {
let input_elem = elem.downcast::<HTMLInputElement>().unwrap();
if input_elem.input_type() == InputType::Image {
if matches!(*input_elem.input_type(), InputType::Image(_)) {
return false;
}
input_elem.form_owner()
@@ -1286,7 +1287,10 @@ impl HTMLFormElement {
let input_matches = child_element
.downcast::<HTMLInputElement>()
.is_some_and(|input| {
matches!(input.input_type(), InputType::Text | InputType::Search)
matches!(
*input.input_type(),
InputType::Text(_) | InputType::Search(_)
)
});
let textarea_matches = child_element.is::<HTMLTextAreaElement>();
let dirname = child_element.get_string_attribute(&local_name!("dirname"));