embedding: Use non-advertised (standard) shortcut (#44223)

Right now we are using [advertised
shortcut](https://learn.microsoft.com/en-au/windows/win32/msi/advertisement).
This is drastically different from standard Windows shortcut. For
example, when you right click,
then click "open file position", nothing happens. 

Advertisement is mostly for "install-on-demand", but that is not the
case for our installer, as files already
installed in the path even if you do not launch. This change makes it so
that servoshell works as other apps.

Reference: [Advanced
installer](https://www.advancedinstaller.com/versus/wix-toolset/how-to-create-non-advertised-shortcuts-using-wix.html).
(Yes, they make great business by making it easier to build MSI
installer)


Testing: [Windows
Try](https://github.com/servo/servo/actions/runs/24436253745).

---------

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This commit is contained in:
Euclid Ye
2026-04-15 16:27:18 +08:00
committed by GitHub
parent 1099aceb39
commit 0f935df0c8

View File

@@ -32,12 +32,6 @@
DiskId="1"
Source="${windowize(exe_path)}\servoshell.exe"
KeyPath="yes">
<Shortcut Id="StartMenuServoTechDemo"
Directory="ProgramMenuDir"
Name="Servo Tech Demo"
WorkingDirectory="INSTALLDIR"
Icon="servoshell.exe"
Advertise="yes"/>
</File>
${include_dependencies()}
</Component>
@@ -56,6 +50,12 @@
Type="string"
Value=""
KeyPath="yes"/>
<Shortcut Id="StartMenuServoTechDemo"
Directory="ProgramMenuDir"
Name="Servo Tech Demo"
Target="[INSTALLDIR]servoshell.exe"
WorkingDirectory="INSTALLDIR"
Icon="servoshell.exe"/>
</Component>
</Directory>
</Directory>