eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-05-02 04:17:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

script: add CanGc as argument to VirtualMethods.post_connection_steps (#40329)

Browse Source 
script: add `CanGc` as argument to
`VirtualMethods.post_connection_steps`

Testing: These changes do not require tests because they are a refactor.
Addresses part of https://github.com/servo/servo/issues/34573

Signed-off-by: Yerkebulan Tulibergenov <yerkebulan@gmail.com>
This commit is contained in:
Yerkebulan Tulibergenov
2025-11-01 03:01:15 -07:00
committed by GitHub
parent 5571c09523
commit 1713f0c8f2
5 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
components/script/dom/html/htmliframeelement.rs
View File

@@ -814,9 +814,9 @@ impl VirtualMethods for HTMLIFrameElement {
}
/// <https://html.spec.whatwg.org/multipage/#the-iframe-element:html-element-post-connection-steps>
fn post_connection_steps(&self) {
fn post_connection_steps(&self, can_gc: CanGc) {
if let Some(s) = self.super_type() {
s.post_connection_steps();
s.post_connection_steps(can_gc);
}
// This isn't mentioned any longer in the specification, but still seems important. This is
@@ -829,14 +829,14 @@ impl VirtualMethods for HTMLIFrameElement {
debug!("<iframe> running post connection steps");
// Step 1. Create a new child navigable for insertedNode.
self.create_nested_browsing_context(CanGc::note());
self.create_nested_browsing_context(can_gc);
// Step 2: If insertedNode has a sandbox attribute, then parse the sandboxing directive
// given the attribute's value and insertedNode's iframe sandboxing flag set.
self.parse_sandbox_attribute();
// Step 3. Process the iframe attributes for insertedNode, with initialInsertion set to true.
self.process_the_iframe_attributes(ProcessingMode::FirstTime, CanGc::note());
self.process_the_iframe_attributes(ProcessingMode::FirstTime, can_gc);
}
fn bind_to_tree(&self, context: &BindContext, can_gc: CanGc) {