eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-04-26 01:25:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

script: Use OnceCell instead of RefCell for some module fields. (#42119)

Browse Source 
This better reflects the intention of the code, which is that these
fields are set at most one time.

Testing: No behaviour change expected, so existing tests suffice.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews
2026-01-24 01:53:33 -05:00
committed by GitHub
parent 34955ec1e3
commit 7925a26a99
3 changed files with 43 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
components/script/dom/html/htmlscriptelement.rs
View File

@@ -1049,18 +1049,14 @@ impl HTMLScriptElement {
// Step 6.
{
let module_error = module_tree.get_rethrow_error().borrow();
let network_error = module_tree.get_network_error().borrow();
let network_error = module_tree.get_network_error();
if module_error.is_some() && network_error.is_none() {
module_tree.report_error(global, can_gc);
return;
}
}
let record = module_tree
.get_record()
.borrow()
.as_ref()
.map(|record| record.handle());
let record = module_tree.get_record().map(|record| record.handle());
if let Some(record) = record {
rooted!(in(*GlobalScope::get_cx()) let mut rval = UndefinedValue());