eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-04-26 01:25:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

script: Pass &mut JSContext in FetchResponseListener::process_response_eof (#42729)

Browse Source 
`process_response_eof` is the only method that needs cx at least right
now. This PR removes one temp_cx and introduces one, removing that one
will is hard (needs VirtualMethods and a lot of work)

Testing: Just refactor
Part of #40600

---------

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This commit is contained in:
Sam
2026-02-20 17:03:21 +01:00
committed by GitHub
parent 0bc3b61a74
commit 9f1e5d084e
20 changed files with 89 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
components/script/dom/html/htmlscriptelement.rs
View File

@@ -375,6 +375,7 @@ impl FetchResponseListener for ClassicContext {
/// step 4-9
fn process_response_eof(
mut self,
cx: &mut js::context::JSContext,
_: RequestId,
response: Result<(), NetworkError>,
timing: ResourceFetchTiming,
@@ -388,11 +389,11 @@ impl FetchResponseListener for ClassicContext {
self.kind,
self.url.clone(),
Err(()),
CanGc::note(),
CanGc::from_cx(cx),
);
// Resource timing is expected to be available before "error" or "load" events are fired.
network_listener::submit_timing(&self, &response, &timing, CanGc::note());
network_listener::submit_timing(&self, &response, &timing, CanGc::from_cx(cx));
return;
},
_ => {},
@@ -469,11 +470,11 @@ impl FetchResponseListener for ClassicContext {
self.kind,
self.url.clone(),
Ok(load),
CanGc::note(),
CanGc::from_cx(cx),
);
// }
network_listener::submit_timing(&self, &response, &timing, CanGc::note());
network_listener::submit_timing(&self, &response, &timing, CanGc::from_cx(cx));
}
fn process_csp_violations(&mut self, _request_id: RequestId, violations: Vec<Violation>) {