eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-05-01 20:07:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Script: Change script/dom/{bluetooth,canvas,html} to not rely on Deref<str> for DOMString (#39480)

Browse Source 
This is part of the future work of implementing LazyDOMString as
outlined in https://github.com/servo/servo/issues/39479.

We use str() method or direct implementations on DOMString for these
methods. We also change some types.

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>


Testing: This is essentially just renaming a method and a type and
should not change functionality.

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
This commit is contained in:
Narfinger
2025-09-25 17:53:21 +02:00
committed by GitHub
parent 1e471b9b41
commit a4c8ffe753
23 changed files with 97 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
components/script/dom/html/htmloptionelement.rs
View File

@@ -215,13 +215,13 @@ impl HTMLOptionElementMethods<crate::DomTypeHolder> for HTMLOptionElement {
if node.is::<Text>() {
let characterdata = node.downcast::<CharacterData>().unwrap();
content.push_str(&characterdata.Data());
content.push_str(characterdata.Data().str());
}
iterator.next();
}
DOMString::from(str_join(split_html_space_chars(&content), " "))
DOMString::from(str_join(split_html_space_chars(content.str()), " "))
}
/// <https://html.spec.whatwg.org/multipage/#dom-option-text>