eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-04-26 01:25:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

script: propagate VirtualMethods::unbind_from_tree with &mut JSContext (#44422)

Browse Source 
Propagate `&mut JSContext` in `VirtualMethods::unbind_from_tree`

Testing: Successful build is enough
Fixes: #42837

---------

Signed-off-by: Emmanuel Paul Elom <elomemmanuel007@gmail.com>
This commit is contained in:
elomscansio
2026-04-23 15:09:11 +01:00
committed by GitHub
parent ff0e9655a8
commit aa7eca43b7
25 changed files with 71 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
components/script/dom/html/htmlbaseelement.rs
View File

@@ -21,7 +21,6 @@ use crate::dom::html::htmlelement::HTMLElement;
use crate::dom::node::{BindContext, Node, NodeTraits, UnbindContext};
use crate::dom::security::csp::CspReporting;
use crate::dom::virtualmethods::VirtualMethods;
use crate::script_runtime::CanGc;
#[dom_struct]
pub(crate) struct HTMLBaseElement {
@@ -177,8 +176,8 @@ impl VirtualMethods for HTMLBaseElement {
document.refresh_base_element();
}
fn unbind_from_tree(&self, context: &UnbindContext, can_gc: CanGc) {
self.super_type().unwrap().unbind_from_tree(context, can_gc);
fn unbind_from_tree(&self, cx: &mut JSContext, context: &UnbindContext) {
self.super_type().unwrap().unbind_from_tree(cx, context);
// https://html.spec.whatwg.org/multipage/#frozen-base-url
// > The base element becomes the first base element in tree order with an href content attribute in its Document.
let document = self.owner_document();