eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-04-26 01:25:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

Revert "script: Fire select events for user input selections (#42806)" (#42876)

Browse Source 
This reverts commit 1f42551042.

This change led to a decrease in Speedometer performance and needs to be
reworked to avoid that.

Testing: This is just a revert.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson
2026-02-26 12:52:36 +01:00
committed by GitHub
parent 9321ca0920
commit aac17cd4a8
11 changed files with 109 additions and 196 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
components/script/dom/html/htmltextareaelement.rs
View File

@@ -34,7 +34,7 @@ use crate::dom::compositionevent::CompositionEvent;
use crate::dom::document::Document;
use crate::dom::document_embedder_controls::ControlElement;
use crate::dom::element::{AttributeMutation, Element, LayoutElementHelpers};
use crate::dom::event::{Event, EventBubbles, EventCancelable};
use crate::dom::event::Event;
use crate::dom::html::htmlelement::HTMLElement;
use crate::dom::html::htmlfieldsetelement::HTMLFieldSetElement;
use crate::dom::html::htmlformelement::{FormControl, HTMLFormElement};
@@ -295,57 +295,24 @@ impl TextControlElement for HTMLTextAreaElement {
}
fn maybe_update_shared_selection(&self) {
let (offsets, direction) = {
let textinput = self.textinput.borrow();
(
textinput.sorted_selection_offsets_range(),
textinput.selection_direction(),
)
};
let offsets = self.textinput.borrow().sorted_selection_offsets_range();
let (start, end) = (offsets.start.0, offsets.end.0);
let range = TextByteRange::new(ByteIndex(start), ByteIndex(end));
let enabled = self.upcast::<Element>().focus_state();
let mut shared_selection = self.shared_selection.borrow_mut();
if shared_selection.is_equivalent_to(&range, enabled, direction) {
if range == shared_selection.range && enabled == shared_selection.enabled {
return;
}
let old_selection = std::mem::replace(
&mut *shared_selection,
ScriptSelection {
direction,
range,
character_range: self
.textinput
.borrow()
.sorted_selection_character_offsets_range(),
enabled,
},
);
// The direction does not currently matter for rendering purposes.
if old_selection.range != shared_selection.range ||
old_selection.enabled != shared_selection.enabled
{
self.owner_window().layout().set_needs_new_display_list();
}
// The enabled status does not matter for deciding whether to send `select` events.
if old_selection.range != shared_selection.range ||
old_selection.direction != shared_selection.direction
{
self.owner_global()
.task_manager()
.user_interaction_task_source()
.queue_event(
self.upcast(),
atom!("select"),
EventBubbles::Bubbles,
EventCancelable::NotCancelable,
);
}
*shared_selection = ScriptSelection {
range,
character_range: self
.textinput
.borrow()
.sorted_selection_character_offsets_range(),
enabled,
};
self.owner_window().layout().set_needs_new_display_list();
}
}