mirror of
https://github.com/servo/servo
synced 2026-05-05 06:32:13 +02:00
Convert various helper traits from &JSRef to JSRef
I converted them all with a few exceptions: - Methods that were used by trait objects, since trait objects don't work with `self` methods. - Methods that take an &'b JSRef<'a, T> and return an &'b. In reality, many (all?) could return an &'a instead, but this isn't allowed by the Deref trait. - Methods that internally rely on the same issue with Deref. - I left out the traits involved in layout entirely, even though not all of their methods suffer from one of the above problems. There will probably be solutions to all of these problems in the future.
This commit is contained in:
@@ -48,7 +48,7 @@ impl HTMLScriptElement {
|
||||
pub trait HTMLScriptElementHelpers {
|
||||
/// Prepare a script (<http://www.whatwg.org/html/#prepare-a-script>),
|
||||
/// steps 6 and 7.
|
||||
fn is_javascript(&self) -> bool;
|
||||
fn is_javascript(self) -> bool;
|
||||
}
|
||||
|
||||
/// Supported script types as defined by
|
||||
@@ -73,8 +73,8 @@ static SCRIPT_JS_MIMES: StaticStringVec = &[
|
||||
];
|
||||
|
||||
impl<'a> HTMLScriptElementHelpers for JSRef<'a, HTMLScriptElement> {
|
||||
fn is_javascript(&self) -> bool {
|
||||
let element: JSRef<Element> = ElementCast::from_ref(*self);
|
||||
fn is_javascript(self) -> bool {
|
||||
let element: JSRef<Element> = ElementCast::from_ref(self);
|
||||
match element.get_attribute(Null, "type").root().map(|s| s.Value()) {
|
||||
Some(ref s) if s.is_empty() => {
|
||||
// type attr exists, but empty means js
|
||||
|
||||
Reference in New Issue
Block a user