eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-05-02 04:17:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

Treat undefined arguments in JS as missing

Browse Source
This commit is contained in:
Keith Yeung
2015-12-05 23:05:46 -08:00
parent d6708a2fea
commit db92a8b030
15 changed files with 8 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
components/script/dom/bindings/codegen/CodegenRust.py
View File

@@ -1142,7 +1142,6 @@ class CGArgumentConverter(CGThing):
"argc": argc,
"args": args
}
condition = string.Template("${index} < ${argc}").substitute(replacer)
replacementVariables = {
"val": string.Template("${args}.get(${index})").substitute(replacer),
@@ -1164,17 +1163,18 @@ class CGArgumentConverter(CGThing):
if not argument.variadic:
if argument.optional:
condition = "{args}.get({index}).is_undefined()".format(**replacer)
if argument.defaultValue:
assert default
template = CGIfElseWrapper(condition,
CGGeneric(template),
CGGeneric(default)).define()
CGGeneric(default),
CGGeneric(template)).define()
else:
assert not default
declType = CGWrapper(declType, pre="Option<", post=">")
template = CGIfElseWrapper(condition,
CGGeneric("Some(%s)" % template),
CGGeneric("None")).define()
CGGeneric("None"),
CGGeneric("Some(%s)" % template)).define()
else:
assert not default