tanishka
7fbd2a521e
CanGc fixes from eventtarget.rs ( #33973 )
...
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-22 22:43:52 +00:00
Daniel Adams
7b392db02f
crypto: Add support for AES-CTR operations ( #33963 )
...
* Add support for AES-CTR operations
Signed-off-by: Daniel Adams <msub2official@gmail.com >
* Update expectations
Signed-off-by: Daniel Adams <msub2official@gmail.com >
* clippy
Signed-off-by: Daniel Adams <msub2official@gmail.com >
* Consolidate encrypt/decrypt for AES-CTR
Signed-off-by: Daniel Adams <msub2official@gmail.com >
* Update expectations
Signed-off-by: Daniel Adams <msub2official@gmail.com >
---------
Signed-off-by: Daniel Adams <msub2official@gmail.com >
2024-10-22 22:32:41 +00:00
tanishka
78d48ae2fb
Fix GC borrow hazard in XRSession::UpdateTargetFrameRate ( #33929 )
...
* Fix GC borrow hazard in XRSession::UpdateTargetFrameRate
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* Limit borrow scope
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
---------
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-22 17:01:42 +00:00
tanishka
7015e0fb5f
CanGc fixes in errorevent.rs ( #33960 )
...
* CanGc fixes in errorevent.rs
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* Allow too_many_arguments to avoid lint error
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
---------
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-22 10:08:55 +00:00
Josh Matthews
575e885529
Mark promise creation methods with CanGc ( #33928 )
...
* Add CanGc annotations to promise constructor.
Signed-off-by: Josh Matthews <josh@joshmatthews.net >
* Propagate CanGc arguments for Promise::new_in_current_realm.
Signed-off-by: Josh Matthews <josh@joshmatthews.net >
* Fix out-of-order entries.
Signed-off-by: Josh Matthews <josh@joshmatthews.net >
* Propagate CanGc from Promise::new.
Signed-off-by: Josh Matthews <josh@joshmatthews.net >
* Suppress clippy warning.
Signed-off-by: Josh Matthews <josh@joshmatthews.net >
* Formatting.
Signed-off-by: Josh Matthews <josh@joshmatthews.net >
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net >
2024-10-22 09:35:20 +00:00
chickenleaf
ebfea9b352
CanGc fixes in several files ( #33958 )
...
* few cangc fixes
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
* few cangc fixes
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
---------
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
2024-10-21 21:32:22 +00:00
Josh Matthews
dc03d1f3e2
Mark CompileFunction as a potential GC operation. ( #33937 )
...
Signed-off-by: Josh Matthews <josh@joshmatthews.net >
2024-10-21 12:29:50 +00:00
chickenleaf
9acb25521e
CanGc changes from fontfaceset.rs ( #33920 )
...
* CanGc changes from fontfaceset.rs
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
* Update components/script/dom/bindings/codegen/Bindings.conf
Co-authored-by: Josh Matthews <josh@joshmatthews.net >
Signed-off-by: chickenleaf <lashwinib@gmail.com >
---------
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
Signed-off-by: chickenleaf <lashwinib@gmail.com >
Co-authored-by: Josh Matthews <josh@joshmatthews.net >
2024-10-21 12:28:56 +00:00
tanishka
66695d2f7e
clippy: Fix warnings in subtlecrypto.rs ( #33943 )
...
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-21 10:43:47 +00:00
Daniel Adams
45267c9f28
crypto: Implement encrypt/decrypt for AES-CBC + JWK support ( #33795 )
...
* Add support for raw importKey with AES-CBC
Signed-off-by: Daniel Adams <msub2official@gmail.com >
* Support JWK import/export, importKey for AES-CBC
Signed-off-by: Daniel Adams <msub2official@gmail.com >
* Implement encrypt/decrypt for AES-CBC
Signed-off-by: Daniel Adams <msub2official@gmail.com >
* Update expectations
Signed-off-by: Daniel Adams <msub2official@gmail.com >
* Update Cargo.lock
Signed-off-by: Daniel Adams <msub2official@gmail.com >
* Pass MutableHandleObject as arg instead of returning raw pointer
Signed-off-by: Daniel Adams <msub2official@gmail.com >
* Swap order of checks in generate_key_aes_cbc
- Fixes WPT tests that expect to error on algorithm first before usages
Signed-off-by: Daniel Adams <msub2official@gmail.com >
* Avoid potential GC hazard with array_buffer_ptr
Signed-off-by: Daniel Adams <msub2official@gmail.com >
* Update expectations for discards context
Signed-off-by: Daniel Adams <msub2official@gmail.com >
---------
Signed-off-by: Daniel Adams <msub2official@gmail.com >
2024-10-21 07:32:19 +00:00
tanishka
4d11b2dc84
CanGc fixes from constantsourcenode.rs & window.rs ( #33931 )
...
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-20 19:54:02 +00:00
Oriol Brufau
c75f6627ba
Upgrade Stylo to 2024-10-04 ( #33767 )
...
* Upgrade Stylo to 2024-10-04
Signed-off-by: Oriol Brufau <obrufau@igalia.com >
* Fixup for https://phabricator.services.mozilla.com/D220285
Signed-off-by: Oriol Brufau <obrufau@igalia.com >
* Fixup for https://bugzilla.mozilla.org/show_bug.cgi?id=1918093
Signed-off-by: Oriol Brufau <obrufau@igalia.com >
* Fixup for https://phabricator.services.mozilla.com/D222817
Signed-off-by: Oriol Brufau <obrufau@igalia.com >
* Fixup for https://phabricator.services.mozilla.com/D222856
Signed-off-by: Oriol Brufau <obrufau@igalia.com >
* Fixup for https://phabricator.services.mozilla.com/D222532
Signed-off-by: Oriol Brufau <obrufau@igalia.com >
* Fixup for https://phabricator.services.mozilla.com/D222533
Signed-off-by: Oriol Brufau <obrufau@igalia.com >
* Fixup for https://phabricator.services.mozilla.com/D222534
Signed-off-by: Oriol Brufau <obrufau@igalia.com >
* Fixup for https://phabricator.services.mozilla.com/D223878
Signed-off-by: Oriol Brufau <obrufau@igalia.com >
---------
Signed-off-by: Oriol Brufau <obrufau@igalia.com >
2024-10-20 19:53:38 +00:00
tanishka
65c866285f
Multiple CanGc fixes in components/script/dom ( #33924 )
...
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-20 16:07:15 +00:00
Wulan Seruniati Salim
a14b65f30b
Replace CanGc::note() with arguments passed by callers ( #33917 )
...
Signed-off-by: Wulan Seruniati Salim <lauwwulan1806@gmail.com >
remove not necessary comment
Co-authored-by: Wulan Seruniati Salim <lauwwulan1806@gmail.com >
2024-10-20 08:24:36 +00:00
tanishka
a57b6a3f79
CanGc fixes through focusevent.rs & hashchangeevent.rs ( #33921 )
...
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-20 08:05:11 +00:00
chickenleaf
c242822eeb
Fix GC borrow hazard in HTMLImageElement::finish_reacting_to_environment_change ( #33904 )
...
* Fix GC borrow hazard in HTMLImageElement::finish_reacting_to_environment_change
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
* Fixed clippy error
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
---------
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
2024-10-19 21:03:03 +00:00
Samson
76bedf28e0
replace sparkle with glow in components/script ( #33911 )
...
* replace sparkle's GlType with canvas_traits's GlType
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
* remove sparkle from components/servo
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
* remove sparkle from script
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
---------
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com >
2024-10-19 10:40:03 +00:00
tanishka
a008b6fc73
Fix GC borrow hazard in ResizeObserver::broadcast_active_resize_observations ( #33875 )
...
* Fix GC borrow hazard in ResizeObserver
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* Use borrow instead of borrow_mut
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* Refactor to avoid borrow conflicts
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* Copy value out of borrowed value
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
---------
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-19 04:13:21 +00:00
Josh Matthews
b85093ad74
Prevent moving CanGc values between threads/tasks ( #33902 )
...
* Make CanGc non-sendable, and add documentation.
Signed-off-by: Josh Matthews <josh@joshmatthews.net >
* Update CanGc usage to fix usages that were moved between threads/tasks.
Signed-off-by: Josh Matthews <josh@joshmatthews.net >
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net >
2024-10-18 17:26:54 +00:00
chickenleaf
1ae90dcd95
clippy: Fix a variety of clippy warnings in fonts, layout_2020 and the DOM code ( #33894 )
...
* fixed some clippy warnings
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
* Delete extra file
Signed-off-by: chickenleaf <lashwinib@gmail.com >
* preserved newline in compositionevent.rs
Co-authored-by: Martin Robinson <mrobinson@igalia.com >
Signed-off-by: chickenleaf <lashwinib@gmail.com >
* removed the newline in PrototypeList
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
* removed the trailing whitespace
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
---------
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
Signed-off-by: chickenleaf <lashwinib@gmail.com >
Co-authored-by: Martin Robinson <mrobinson@igalia.com >
2024-10-18 13:57:13 +00:00
chickenleaf
af6154cf63
More files with CanGc fixes ( #33892 )
...
* More files with CanGc fixes
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
* removed the can_gc inside !task
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
---------
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
2024-10-18 13:42:43 +00:00
chickenleaf
fde8d72aca
Various CanGc fixes in 8 files ( #33893 )
...
* Various CanGc fixes in 8 files
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
* fixed merge conflicts and formatting
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
---------
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
2024-10-18 11:54:32 +00:00
tanishka
6b87ecc291
Some CanGc fixes in components/script/dom ( #33895 )
...
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-18 11:52:37 +00:00
Simon Wülker
e33bae6d0a
Use ROUTER::add_typed_route instead of ROUTER::add_route everywhere ( #33866 )
...
* Use ROUTER::add_typed_route where possible
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de >
* Update webxr, media and ipc-channel
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de >
---------
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de >
2024-10-18 10:47:52 +00:00
komuhangi
ff374c1428
clippy: Rename RequestId::new() to RequestId::next() and fix one more issue in servo/lib.rs ( #33881 )
...
* clippy: fix clippy warnings in components/
Signed-off-by: jahielkomu <ktumuhairwe24@gmail.com >
* Addressed changes from the PR
Signed-off-by: jahielkomu <ktumuhairwe24@gmail.com >
---------
Signed-off-by: jahielkomu <ktumuhairwe24@gmail.com >
2024-10-18 09:45:40 +00:00
tanishka
f826698d6e
CanGc fixes in components/script/dom ( #33891 )
...
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-17 22:36:04 +00:00
chickenleaf
9c893c7f4d
More CanGc fixes ( #33888 )
...
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
2024-10-17 19:36:42 +00:00
Simon Wülker
4a58616770
Fix type mismatches in Router::add_route calls ( #33882 )
...
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de >
2024-10-17 13:09:48 +00:00
lwz23
595aab10dc
fix clippy warning in components/script ( #33878 )
...
Signed-off-by: lwz23 <wenzhaoliao@ruc.edu.cn >
2024-10-17 12:58:28 +00:00
tanishka
cd7b66be58
CanGc fixes in components/script/dom ( #33880 )
...
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-17 12:49:00 +00:00
evuez
72ff89620b
Handle multibyte characters in img srcset ( #33873 )
...
This was causing this web platform test to crash:
https://wpt.fyi/results/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute.html
Signed-off-by: evuez <julien@mulga.net >
2024-10-17 08:13:18 +00:00
Martin Robinson
036e74524a
net: Start reducing number of IPCs channels used for fetch with a FetchThread ( #33863 )
...
Instead of creating a `ROUTER` for each fetch, create a fetch thread
which handles all incoming and outcoming fetch requests. Now messages
involving fetches carry a "request id" which indicates which fetch is
being addressed by the message. This greatly reduces the number of file
descriptors used by fetch.
In addition, the interface for kicking off fetches is simplified when
using the `Listener` with `Document`s and the `GlobalScope`.
This does not fix all leaked file descriptors / mach ports, but greatly
eliminates the number used. Now tests can be run without limiting
procesess on modern macOS systems.
Followup work:
1. There are more instances where fetch is done using the old method.
Some of these require more changes in order to be converted to the
`FetchThread` approach.
2. Eliminate usage of IPC channels when doing redirects.
3. Also eliminate the IPC channel used for cancel handling.
4. This change opens up the possiblity of controlling the priority of
fetch requests.
Fixes #29834 .
Signed-off-by: Martin Robinson <mrobinson@igalia.com >
2024-10-16 16:53:24 +00:00
Taym Haddadi
2115267328
Add missing XRWebGLBinding constructor spec steps ( #33731 )
...
* Add missing XRWebGLBinding constructor spec steps
Signed-off-by: Taym <haddadi.taym@gmail.com >
* Update test expectation
Signed-off-by: Taym <haddadi.taym@gmail.com >
---------
Signed-off-by: Taym <haddadi.taym@gmail.com >
2024-10-16 16:12:37 +00:00
tanishka
cde6931f4b
clippy: Fix warnings in components/script/dom ( #33860 )
...
* clippy: Fix warnings in components/script/dom
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* Move allow to WRAP level
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
---------
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-16 15:48:53 +00:00
tanishka
a646c850c6
clippy: Fix warnings in components/script/dom & components/servo ( #33853 )
...
* clippy: Fix warnings in components/script/dom & components/servo
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* Move allow to the level of the named field
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* Add blank lines before & after field
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* remove trailing whitespace
Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com >
---------
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com >
Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com >
2024-10-16 15:34:14 +00:00
komuhangi
b0a33d6b02
Some CanGc Fixes ( #33865 )
...
Signed-off-by: jahielkomu <ktumuhairwe24@gmail.com >
2024-10-16 15:14:28 +00:00
tanishka
2b9527262c
CanGc fixes in components/script/dom ( #33862 )
...
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-16 14:18:07 +00:00
chickenleaf
2e0fbfcb95
Fix GC borrow hazard in XRInputSourceArray ( #33857 )
...
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
2024-10-16 11:08:31 +00:00
komuhangi
0a71c736f0
clippy: fix clippy warnings in components/script ( #33849 )
...
* Clippy:Fix clippy warnings in components/script
Signed-off-by: jahielkomu <ktumuhairwe24@gmail.com >
* Addressed changes suggested in #33849
Signed-off-by: jahielkomu <ktumuhairwe24@gmail.com >
---------
Signed-off-by: jahielkomu <ktumuhairwe24@gmail.com >
2024-10-16 10:21:25 +00:00
Martin Robinson
30abb99287
clippy: Add safety documentation and clean up unsafe methods ( #33748 )
...
This change:
1. Adds safety documentation where it was missing.
2. Limits the scope of unsafe code in some cases to where it is actually
unsafe.
3. Converts some free functions to associated functions and methods,
thereby making them more likely to be called safely.
Signed-off-by: Martin Robinson <mrobinson@igalia.com >
2024-10-16 08:11:31 +00:00
chickenleaf
a2f81d69c1
CanGc fixes ( #33852 )
...
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
2024-10-16 02:50:28 +00:00
tanishka
c37fb2e453
clippy: Fix type_complexity warning in components/script/dom ( #33835 )
...
* clippy: Fix type_complexity warning in components/script/dom/bluetoothdevice.rs
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* Fix clippy warnings due to code changes
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* Move documentation comment
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* Root the new struct
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
---------
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-15 07:39:15 +00:00
chickenleaf
b088a8b8f1
Fix Clippy warning: remove unneeded late initialization of string ( #33840 )
...
* Fix Clippy warning: remove unneeded late initialization of string
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
* Fixed the comments placement
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
---------
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
2024-10-15 06:09:26 +00:00
tanishka
46d6c0c883
CanGc fixes in components/script/dom ( #33843 )
...
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-15 04:45:16 +00:00
chickenleaf
1e39787573
CanGc fixes and checks in multiple files ( #33836 )
...
* CanGc fixes and checks in multiple files
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
* CanGc fixes in storageevent.rs
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
---------
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
2024-10-15 04:30:48 +00:00
tanishka
cfd15dd14d
CanGc fixes originating from gamepadevent.rs & stereopannernode.rs ( #33828 )
...
* CanGc fixes originating from gamepadevent.rs & stereopannernode.rs
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
* Revert changes within task! macro
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
---------
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com >
2024-10-14 13:22:08 +00:00
komuhangi
717baff17b
Fixed same_enum_variation clippy warnings in components/script/dom ( #33818 )
...
Signed-off-by: jahielkomu <ktumuhairwe24@gmail.com >
2024-10-14 04:12:19 +00:00
chickenleaf
fc0835bae3
CanGc fixes in focusevent.rs oscillartornode.rs response.rs resizeobserversize.rs animationevent.rs ( #33827 )
...
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
2024-10-13 21:35:59 +00:00
chickenleaf
92f12ff7cd
Propagate CanGc through dommatrix, dommatrixreadonly, and testbindings ( #33822 )
...
* CanGc fixes starting from dommatrix.rs
fixed conflicts
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
~
* cleaning up
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
* fixed cannot find value can_gc in this scope error
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
---------
Signed-off-by: L Ashwin B <lashwinib@gmail.com >
2024-10-13 16:11:46 +00:00
Simon Wülker
bdd5fb2e5b
Use document encoding when parsing url in href setter ( #33825 )
...
* Implement encoding-parse-a-url algorithm
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de >
* Parse url with encoding when setting href on HtmlAnchorElement
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de >
* Update WPT expectations
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de >
---------
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de >
2024-10-13 15:12:51 +00:00