mirror of
https://github.com/servo/servo
synced 2026-04-25 17:15:48 +02:00
0ea42bc774
Follow-up to #44443. This helps investigating the cold-start timeline, and could be used by tooling to A/B compare branches affecting the cold-start time. Additionally also change the `handle_request::select` span, so that we can see the blocked time (which was probably what was intended), since the actual time spent on recv after select is insignificant. Testing: Tracing output is not covered by automatic tests. --------- Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
81 lines
2.2 KiB
Rust
81 lines
2.2 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
use std::process::Child;
|
|
|
|
use crossbeam_channel::{Receiver, Select};
|
|
use log::{debug, warn};
|
|
use profile_traits::mem::{ProfilerChan, ProfilerMsg};
|
|
|
|
pub enum Process {
|
|
Unsandboxed(Child),
|
|
Sandboxed(u32),
|
|
}
|
|
|
|
impl Process {
|
|
fn pid(&self) -> u32 {
|
|
match self {
|
|
Self::Unsandboxed(child) => child.id(),
|
|
Self::Sandboxed(pid) => *pid,
|
|
}
|
|
}
|
|
|
|
fn wait(&mut self) {
|
|
match self {
|
|
Self::Unsandboxed(child) => {
|
|
let _ = child.wait();
|
|
},
|
|
Self::Sandboxed(_pid) => {
|
|
// TODO: use nix::waitpid() on supported platforms.
|
|
warn!("wait() is not yet implemented for sandboxed processes.");
|
|
},
|
|
}
|
|
}
|
|
}
|
|
|
|
type ProcessReceiver = Receiver<Result<(), ipc_channel::IpcError>>;
|
|
|
|
pub(crate) struct ProcessManager {
|
|
processes: Vec<(Process, ProcessReceiver)>,
|
|
mem_profiler_chan: ProfilerChan,
|
|
}
|
|
|
|
impl ProcessManager {
|
|
pub fn new(mem_profiler_chan: ProfilerChan) -> Self {
|
|
Self {
|
|
processes: vec![],
|
|
mem_profiler_chan,
|
|
}
|
|
}
|
|
|
|
pub fn add(&mut self, receiver: ProcessReceiver, process: Process) {
|
|
debug!("Adding process pid={}", process.pid());
|
|
self.processes.push((process, receiver));
|
|
}
|
|
|
|
pub fn register<'a>(&'a self, select: &mut Select<'a>) {
|
|
for (_, receiver) in &self.processes {
|
|
select.recv(receiver);
|
|
}
|
|
}
|
|
|
|
pub fn receiver_at(&self, index: usize) -> &ProcessReceiver {
|
|
let (_, receiver) = &self.processes[index];
|
|
receiver
|
|
}
|
|
|
|
#[servo_tracing::instrument(skip_all)]
|
|
pub fn remove(&mut self, index: usize) {
|
|
let (mut process, _) = self.processes.swap_remove(index);
|
|
debug!("Removing process pid={}", process.pid());
|
|
// Unregister this process system memory profiler
|
|
self.mem_profiler_chan
|
|
.send(ProfilerMsg::UnregisterReporter(format!(
|
|
"system-content-{}",
|
|
process.pid()
|
|
)));
|
|
process.wait();
|
|
}
|
|
}
|