mirror of
https://github.com/servo/servo
synced 2026-05-14 19:06:31 +02:00
0353f11ee2
TL;DR: We increase stack size of `ScriptThread` to 8MiB, and set Stylo stack size environment var to 8 MiB for all builds. This only reserves virtual memory space which is basically unlimited for 64-bit machine, matches the recursion depth of Chromium for the example, which also uses 8MiB. Stylo stack increase is necessary to prevent overflow when refreshing/navigating to the example, probably because initial load restyle incrementally but not refresh. Testing: Added a Servo-specific test. --- For example in #43845, we get stack overflow when we got more than 394 nested shadow roots. For Chromium, it happens for more than 1631: <img width="290" height="127" alt="image" src="https://github.com/user-attachments/assets/b3d75627-4e80-4586-9b85-4b58d8a0cd33" /> For Firefox, it overflows for more than 1052. Initially I thought we didn't implement this optimally, and have unnecessary recursion depth. But the real reason is explained in Rust std: > The default stack size is platform-dependent and subject to change. Currently, it is 2 MiB on all Tier-1 platforms. For Chromium, the visual studio dumpbin shows the stack size : ``` Dump of file C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe OPTIONAL HEADER VALUES 800000 size of stack reserve ``` This is hex value, which is $8*16^5$, exactly 8MiB. After we make the same change in Servo, we are fine at 1601 and overflows at 1602. This matches Chromium behaviour, defeating firefox, and should not create much overhead, as this only reserves virtual memory space: I tried to increase the value to 512MiB, but task manager still says 73MB RAM used, and we won't crash even with 10000 nested shadow roots. But that is just for more evidence and uncalled for. Fixes: #43845 --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>