mirror of
https://github.com/servo/servo
synced 2026-05-14 19:06:31 +02:00
7b00b54ee8
Back in #41067, we added webdriver touch support for all platforms. All touch-related testdriver tests which faked to work has been CRASH instead, as we assume that touch down event always happens before touch move and touch up. But the assumption above is not wrong, as I observed embedder events dispatched from OHOS/Android when interacting as human. It is just that the tests are flawed: almost all of them have pointermove first even for touch, and spec didn't consider touch/pen support well enough: #41042. Luckily, our embedder `MouseMove` event would also update the webdriver pointer status, which effectively allow touch down/touch up to happen at right point. It **doesn't matter** whether the website has mouse listener or not. Testing: Tested manually on a touch-event-only complicated website. Also, tests no longer crash, also with expectations different from before https://github.com/servo/servo/pull/41067, e.g. [this](https://github.com/servo/servo/pull/41067/files#diff-db149f4025dab43bd5a3c8a412ea2ac9e521f4745c0f982925b4d15b236ff955) had been failing but now passes. --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>