Files
servo/components/script/image_animation.rs
Narfinger d41bb930e1 painter: Insert a cache for animation with smarter updates (#41956)
This inserts a cache in painter that keeps data for animating images in
Painter.
We then can send cheap ImageUpdate::UpdateAnimation to just get the
required bytes from the cache.

There are some warts with the current design:
- ImageUpdate::AddImage only adds images in the cache that have the data
in SerializableImageData::Raw. Potentially there could be image
animations in other ways which then for a following
ImageUpdate::UpdateAnimation we do not have the data. We can probably
fix this on the sender side.

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

Testing: Tested on the usecase in
https://github.com/servo/servo/issues/41818 and WPT test here:
https://github.com/Narfinger/servo/actions/runs/21063721427
Fixes: https://github.com/servo/servo/issues/41818

---------

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
2026-01-28 14:07:27 +00:00

128 lines
4.4 KiB
Rust

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
use std::cell::Cell;
use std::sync::Arc;
use std::time::Duration;
use layout_api::AnimatingImages;
use malloc_size_of::MallocSizeOf;
use paint_api::ImageUpdate;
use parking_lot::RwLock;
use script_bindings::codegen::GenericBindings::WindowBinding::WindowMethods;
use timers::{TimerEventRequest, TimerId};
use crate::dom::bindings::refcounted::Trusted;
use crate::dom::node::Node;
use crate::dom::window::Window;
use crate::script_thread::with_script_thread;
#[derive(Clone, Default, JSTraceable)]
#[cfg_attr(crown, crown::unrooted_must_root_lint::must_root)]
pub struct ImageAnimationManager {
/// The set of [`AnimatingImages`] which is used to communicate the addition
/// and removal of animating images from layout.
#[no_trace]
animating_images: Arc<RwLock<AnimatingImages>>,
/// The [`TimerId`] of the currently scheduled animated image update callback.
#[no_trace]
callback_timer_id: Cell<Option<TimerId>>,
}
impl MallocSizeOf for ImageAnimationManager {
fn size_of(&self, ops: &mut malloc_size_of::MallocSizeOfOps) -> usize {
(*self.animating_images.read()).size_of(ops)
}
}
impl ImageAnimationManager {
pub(crate) fn animating_images(&self) -> Arc<RwLock<AnimatingImages>> {
self.animating_images.clone()
}
fn duration_to_next_frame(&self, now: f64) -> Option<Duration> {
self.animating_images
.read()
.node_to_state_map
.values()
.map(|state| state.duration_to_next_frame(now))
.min()
}
pub(crate) fn update_active_frames(&self, window: &Window, now: f64) {
if self.animating_images.read().is_empty() {
return;
}
let updates = self
.animating_images
.write()
.node_to_state_map
.values_mut()
.filter_map(|state| {
if !state.update_frame_for_animation_timeline_value(now) {
return None;
}
let image = &state.image;
let frame = image
.frame_data(state.active_frame)
.expect("No frame found")
.clone();
if let Some(mut descriptor) =
image.webrender_image_descriptor_and_offset_for_frame()
{
descriptor.offset = frame.byte_range.start as i32;
Some(ImageUpdate::UpdateImageForAnimation(
image.id.unwrap(),
descriptor,
))
} else {
error!("Doing normal image update which will be slow!");
None
}
})
.collect();
window
.paint_api()
.update_images(window.webview_id().into(), updates);
self.maybe_schedule_update(window, now);
}
/// After doing a layout, if the set of animating images was updated in some way,
/// schedule a new animation update.
pub(crate) fn maybe_schedule_update_after_layout(&self, window: &Window, now: f64) {
if self.animating_images().write().clear_dirty() {
self.maybe_schedule_update(window, now);
}
}
fn maybe_schedule_update(&self, window: &Window, now: f64) {
with_script_thread(|script_thread| {
if let Some(current_timer_id) = self.callback_timer_id.take() {
self.callback_timer_id.set(None);
script_thread.cancel_timer(current_timer_id);
}
if let Some(duration) = self.duration_to_next_frame(now) {
let trusted_window = Trusted::new(window);
let timer_id = script_thread.schedule_timer(TimerEventRequest {
callback: Box::new(move || {
let window = trusted_window.root();
window.Document().set_has_pending_animated_image_update();
}),
duration,
});
self.callback_timer_id.set(Some(timer_id));
}
})
}
pub(crate) fn cancel_animations_for_node(&self, node: &Node) {
self.animating_images().write().remove(node.to_opaque());
}
}