mirror of
https://github.com/servo/servo
synced 2026-04-26 01:25:32 +02:00
4041256e24
this patch cleans up a few minor issues in our accessibility code: - we remove the initial synchronous TreeUpdate in [WebView::set_accessibility_active()](https://doc.servo.org/servo/struct.WebView.html#method.set_accessibility_active). it’s not actually necessary, because AccessKit only requires that subtree updates happen after the graft node is created in the parent, but those subtree updates can be delayed indefinitely. removing it simplifies our API a bit. - we rename notify_accessibility_tree_id() to notify_document_accessibility_tree_id(), and do the same to the underlying ConstellationToEmbedderMsg variant. this helps clarify that we’re referring to the (active top-level) document’s accessibility tree. - we make that method pub(crate) too. it doesn’t need to be pub. - we remove the label property from webview-to-pipeline graft nodes. properties set on graft nodes are only visible in the accesskit_consumer API, not in the platform accessibility API, and we don’t need it in our tests, so there’s no longer any reason to keep setting it. Testing: updated the relevant libservo accessibility tests Fixes: part of #4344 Signed-off-by: delan azabani <dazabani@igalia.com> Co-authored-by: Alice Boxhall <alice@igalia.com>
55 lines
2.6 KiB
Rust
55 lines
2.6 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
use accesskit::TreeId;
|
|
use embedder_traits::{
|
|
InputEventOutcome, JSValue, JavaScriptEvaluationError, JavaScriptEvaluationId,
|
|
MediaSessionEvent, NewWebViewDetails, TraversalId,
|
|
};
|
|
use servo_base::generic_channel::GenericSender;
|
|
use servo_base::id::{PipelineId, WebViewId};
|
|
use servo_url::ServoUrl;
|
|
|
|
/// Messages sent from the `Constellation` to the embedder.
|
|
pub enum ConstellationToEmbedderMsg {
|
|
/// Informs the embedder that the constellation has completed shutdown.
|
|
/// Required because the constellation can have pending calls to make
|
|
/// (e.g. SetFrameTree) at the time that we send it an ExitMsg.
|
|
ShutdownComplete,
|
|
/// Report a complete sampled profile
|
|
ReportProfile(Vec<u8>),
|
|
/// All webviews lost focus for keyboard events.
|
|
WebViewBlurred,
|
|
/// A history traversal operation completed.
|
|
HistoryTraversalComplete(WebViewId, TraversalId),
|
|
/// Notifies the embedder about media session events
|
|
/// (i.e. when there is metadata for the active media session, playback state changes...).
|
|
MediaSessionEvent(WebViewId, MediaSessionEvent),
|
|
/// A pipeline panicked. First string is the reason, second one is the backtrace.
|
|
Panic(WebViewId, String, Option<String>),
|
|
/// A webview potentially gained focus for keyboard events.
|
|
/// If the boolean value is false, the webiew could not be focused.
|
|
WebViewFocused(WebViewId, bool),
|
|
/// Inform the embedding layer that a particular `InputEvent` was handled by Servo
|
|
/// and the embedder can continue processing it, if necessary.
|
|
InputEventsHandled(WebViewId, Vec<InputEventOutcome>),
|
|
/// A webview was destroyed.
|
|
WebViewClosed(WebViewId),
|
|
/// Inform the embedding layer that a JavaScript evaluation has
|
|
/// finished with the given result.
|
|
FinishJavaScriptEvaluation(
|
|
JavaScriptEvaluationId,
|
|
Result<JSValue, JavaScriptEvaluationError>,
|
|
),
|
|
/// Whether or not to allow script to open a new tab/browser
|
|
AllowOpeningWebView(WebViewId, GenericSender<Option<NewWebViewDetails>>),
|
|
/// Whether or not to allow a pipeline to load a url.
|
|
AllowNavigationRequest(WebViewId, PipelineId, ServoUrl),
|
|
/// The history state has changed.
|
|
HistoryChanged(WebViewId, Vec<ServoUrl>, usize),
|
|
/// Notifies the embedder that the AccessKit [`TreeId`] for the top-level document in this
|
|
/// WebView has been changed (or initially set).
|
|
DocumentAccessibilityTreeIdChanged(WebViewId, TreeId),
|
|
}
|