Sam 0f9f601eb9 script: Correctly handle Reflector with AssociatedMemory and remove associated memory in finalize instead of drop (#42271) ...

Reviewable per commits:

As noted in
https://github.com/servo/servo/pull/42180#discussion_r2749861902
transmuting `&Reflector<AssociatedMemory>` to `&Reflector<()>` will
ignore AssociatedMemory information and thus it will not remove extra
associated memory. By returning `&Reflector<Self::ReflectorType>` from
`DomObject::reflector()` we will preserve this information and thus
correctly handle cases with associated memory. We also do not need
`overrideMemoryUsage` in bindings.conf anymore. 🎉

Instead of removing associated memory in drop code we should do it as
part of finalizers, otherwise we have problems in nested (inherited)
structs, where drop is run for both parent and child, but we only added
associated memory for child (on init_reflector) which already included
size of parent. The only exception here is promise, because it is RCed
and not finalized.

Testing: Tested locally that it fixes speedometer.
Fixes #42269

---------

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>

2026-02-01 10:57:08 +00:00

..

Cargo.toml

Merge DomObject proc-macro into #[dom_struct] (#42262)

2026-01-31 18:06:25 +00:00

domobject.rs

script: Correctly handle Reflector with AssociatedMemory and remove associated memory in finalize instead of drop (#42271)

2026-02-01 10:57:08 +00:00

lib.rs

script: Correctly handle Reflector with AssociatedMemory and remove associated memory in finalize instead of drop (#42271)

2026-02-01 10:57:08 +00:00