bors-servo
989d2fd532
Auto merge of #19644 - Xanewok:root-seq-any, r=jdm
...
Root sequence<any> params using CustomAutoRooter
<!-- Please describe your changes on the following line: -->
Attempt at https://github.com/servo/servo/issues/16678 . At the moment this pulls an external [remove-handle-conv](https://github.com/Xanewok/rust-mozjs/tree/remove-handle-conv ) branch for rust-mozjs (removing `FromJSValConvertible` implementation for `HandleValue` and adding one for `*mut JSObject`)
In short, this roots the `sequence<any>` and `sequence<object>` function arguments using `CustomAutoRooter` (introduced in https://github.com/servo/rust-mozjs/pull/382 ).
As per https://github.com/servo/servo/issues/16678#issuecomment-302224110 the underlying vector contains raw gc thing pointers instead of handles. To do that, this introduces new possible `isMember = "AutoRoot"` value in CodegenRust.py.
The rooted argument is passed to a function wrapped in a `CustomAutoRooterGuard` [RAII root guard](ed5e37a288/src/rust.rs (L586-L588) ) (e.g. as `CustomAutoRooterGuard<Vec<JSVal>>`)
I felt quite out of my depth when trying to adapt CodegenRust.py code, so I'd appreciate any help with how can be done better/in a more clean manner.
Also the name `CustomAutoRooterGuard` is quite lengthy, so I'm also open to changing it (`AutoRoot`? `AutoRootGuard`?)
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #16678 (github issue number if applicable).
<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19644 )
<!-- Reviewable:end -->
2018-01-05 14:02:53 -06:00
..
2018-01-05 18:21:25 +01:00
2017-11-30 16:18:57 +00:00
2017-10-31 21:38:39 +01:00
2017-10-18 22:20:37 +11:00
2018-01-05 14:02:53 -06:00
2017-08-23 21:38:44 +02:00
2017-10-16 17:16:20 +02:00
2017-10-18 09:15:55 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-11-09 16:56:39 +01:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-02-24 01:50:51 +01:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-12-18 10:51:00 -05:00
2017-11-27 20:19:08 +08:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-06-16 17:55:25 -04:00
2017-11-06 17:08:14 +01:00
2017-10-18 22:20:37 +11:00
2017-10-30 23:36:06 +01:00
2017-10-17 11:24:57 -07:00
2017-10-18 22:20:37 +11:00
2017-10-18 22:20:37 +11:00
2017-10-18 22:20:37 +11:00
2017-10-18 22:20:37 +11:00
2017-10-18 22:20:37 +11:00
2017-10-30 23:36:06 +01:00
2017-10-18 22:20:37 +11:00
2017-09-26 09:49:10 +02:00
2017-10-18 22:20:37 +11:00
2017-11-21 14:26:16 +01:00
2017-10-18 22:20:37 +11:00
2017-10-18 22:20:37 +11:00
2017-10-17 11:24:57 -07:00
2017-10-30 23:36:06 +01:00
2017-10-18 22:20:37 +11:00
2017-10-18 22:20:37 +11:00
2017-10-18 22:20:37 +11:00
2017-10-30 23:36:06 +01:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-12-14 16:48:19 -06:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-11-22 14:06:27 -08:00
2017-10-16 17:16:20 +02:00
2017-12-08 14:32:28 +01:00
2017-11-22 14:06:27 -08:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-12-08 05:35:12 +01:00
2017-10-18 22:20:37 +11:00
2017-10-18 22:20:37 +11:00
2017-11-17 15:59:59 -08:00
2017-11-30 16:18:57 +00:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-11-01 10:16:11 +01:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-11-15 19:28:03 +08:00
2017-10-16 17:16:20 +02:00
2017-10-17 11:24:57 -07:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-17 11:24:57 -07:00
2017-10-17 11:24:57 -07:00
2017-10-16 17:16:20 +02:00
2017-10-30 23:36:06 +01:00
2017-10-27 12:53:11 +02:00
2017-11-06 17:08:14 +01:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-12-06 21:11:39 +01:00
2017-10-16 17:16:20 +02:00
2017-10-30 23:36:06 +01:00
2017-10-17 11:24:57 -07:00
2017-10-16 17:16:20 +02:00
2017-12-06 21:11:39 +01:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-17 11:24:57 -07:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-30 23:36:06 +01:00
2017-10-24 17:02:18 -05:00
2017-12-17 16:57:01 +08:00
2017-10-16 17:16:20 +02:00
2017-12-09 20:26:48 +01:00
2017-10-16 17:16:20 +02:00
2017-11-09 16:56:39 +01:00
2017-10-16 17:16:20 +02:00
2017-11-24 10:18:36 +01:00
2017-11-09 16:56:39 +01:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-10-30 23:36:06 +01:00
2017-10-30 23:36:06 +01:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-11-09 16:56:39 +01:00
2017-10-30 23:36:06 +01:00
2017-10-17 11:24:57 -07:00
2017-10-16 17:16:20 +02:00
2017-11-30 16:18:57 +00:00
2017-10-16 17:16:20 +02:00
2017-09-26 09:49:04 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-17 11:24:57 -07:00
2017-12-08 21:07:05 +01:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 20:19:56 +02:00
2017-10-16 17:16:20 +02:00
2017-10-30 23:36:06 +01:00
2017-10-16 17:16:20 +02:00
2017-11-09 16:56:39 +01:00
2017-10-16 17:16:20 +02:00
2017-10-30 23:36:06 +01:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-09-26 09:49:10 +02:00
2017-10-16 17:16:20 +02:00
2017-11-18 22:33:05 +01:00
2017-10-18 09:15:55 +02:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-11-09 16:56:39 +01:00
2017-10-16 17:16:20 +02:00
2017-08-23 17:16:30 +02:00
2018-01-04 14:45:54 +01:00
2017-10-19 22:01:30 +08:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-12-08 14:32:28 +01:00
2017-10-17 11:24:57 -07:00
2017-12-22 10:47:23 +01:00
2017-12-07 07:26:39 +01:00
2017-10-16 17:16:20 +02:00
2017-09-06 13:33:30 +02:00
2017-09-06 13:33:30 +02:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-12-07 07:26:39 +01:00
2017-12-14 16:48:19 -06:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-09-26 09:49:10 +02:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-20 09:11:38 -07:00
2017-10-18 22:20:37 +11:00
2017-12-06 21:11:39 +01:00
2017-10-18 22:20:37 +11:00
2017-11-16 13:36:22 +08:00
2017-10-18 22:20:37 +11:00
2017-11-13 21:32:10 +01:00
2017-10-16 17:16:20 +02:00
2017-11-09 16:56:39 +01:00
2017-10-30 23:36:06 +01:00
2017-10-16 17:16:20 +02:00
2017-10-17 11:24:57 -07:00
2017-10-16 17:16:20 +02:00
2017-10-17 11:24:57 -07:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-05-03 12:57:49 -05:00
2017-05-03 12:57:49 -05:00
2017-10-16 17:16:20 +02:00
2017-11-06 13:00:14 -05:00
2018-01-05 18:21:25 +01:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-03-13 17:38:33 +01:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-12-08 21:07:05 +01:00
2017-11-09 16:56:39 +01:00
2017-10-16 20:19:56 +02:00
2017-10-17 11:24:57 -07:00
2017-10-17 11:24:57 -07:00
2017-10-17 11:24:57 -07:00
2017-10-16 17:16:20 +02:00
2017-10-21 15:13:04 -05:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-10-31 19:08:26 +01:00
2017-03-13 21:57:50 +08:00
2016-11-23 22:46:57 -08:00
2017-10-30 23:36:06 +01:00
2017-11-06 17:08:14 +01:00
2017-10-16 17:16:20 +02:00
2017-10-27 12:53:11 +02:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-10-18 22:20:37 +11:00
2017-10-16 20:19:56 +02:00
2017-10-16 20:19:56 +02:00
2017-10-18 22:20:37 +11:00
2017-11-02 15:12:35 +01:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-02-24 01:50:51 +01:00
2017-10-18 22:20:37 +11:00
2017-10-18 22:20:37 +11:00
2017-11-13 14:58:06 +01:00
2017-11-13 14:58:06 +01:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-10-16 17:16:20 +02:00
2017-11-09 16:56:39 +01:00
2017-11-30 16:18:57 +00:00
2017-10-16 17:16:20 +02:00
2017-10-18 22:20:37 +11:00
2017-11-01 20:45:22 +00:00
2017-10-16 17:16:20 +02:00
2017-10-16 17:16:20 +02:00
2017-10-30 23:36:06 +01:00
2017-10-18 22:20:37 +11:00
2017-11-22 14:06:27 -08:00
2017-11-23 17:19:57 +01:00
2017-09-01 11:54:09 +02:00
2017-10-16 17:16:20 +02:00