servo

mirror of https://github.com/servo/servo synced 2026-05-10 17:12:23 +02:00

Files

Euclid Ye 6b79b031fe webdriver: Serialize script String argument correctly to prevent injection attack (#39715 )

The previous serialization is problematic when dealing with string
argument with special characters. In addition, it was vulnerable to
injection attack like below:

```rust
let s = r#""); alert(1); //"#;
let args_string = format!("\"{}\"", s);
let script = format!("(function() {{ {}\n}})({})", "/* body */", args_string); 
// script becomes: (function() { /* body */ })(""); alert(1); //")
```

Testing: Added four new tests in
[wdspec](https://web-platform-tests.org/writing-tests/wdspec.html).
Before this PR, we would get "javascript error" for the new tests, and
trigger user prompts. Now it passes. This should also fix some
testdriver tests.

---------

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>

2025-10-09 03:18:36 +00:00

actions.rs

webdriver: Stop making fields RefCell (#39679 )

2025-10-08 06:18:35 +00:00

capabilities.rs

Rework webdriver session (#38225 )

2025-07-28 10:14:14 +00:00

Cargo.toml

Cargo.toml cleanup (#39403 )

2025-09-20 03:09:37 +00:00

elements.rs

webdriver: Serialize script String argument correctly to prevent injection attack (#39715 )