mirror of
https://github.com/servo/servo
synced 2026-05-12 01:46:28 +02:00
afa4b524ab
Fonts: Added `language` field in the struct `ShapingOptions` so Harfbuzz can also consider language when shaping glyphs. Testing: Existing WPT. Most recent try run: [link](https://github.com/RichardTjokroutomo/servo/actions/runs/23334049878) 2 new passes, 5 new fails. Failures: - `/css/css-text-decor/text-emphasis-punctuation-2.html` should be a false positive since `text-emphasis` shorthand hasn't been supported on stylo yet. - Not quite sure about this, but `/css/css-text/text-spacing-trim/text-spacing-trim-quote-001.html?class=halt,htb&lang=ja` tests `text-spacing-trim` default behavior on `JA` texts. Since this property is not defined in Stylo, I believe that this property's behavior (including default) hasn't been considered in Servo. So Servo previously passing the test should be a false positive. As a side note, this test also fails on Firefox. - `/html/canvas/element/manual/text/canvas.2d.lang.dynamic.html`, `/html/canvas/element/manual/text/canvas.2d.lang.html`, `/html/canvas/element/manual/text/canvas.2d.lang.inherit.disconnected.canvas.html` fail because canvas' experimental [`lang` attribute](https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/lang) hasn't been supported yet. credits to @mrobinson for figuring out the reason for last 3 failing WPT tests! Fixes: #41825 --------- Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>