mirror of
https://github.com/servo/servo
synced 2026-05-10 00:52:08 +02:00
The versions of `cargo-deny` older than 0.18.6 have a bug which causes the executions of `cargo-deny check` to prematurely fail when reading the advisory db (https://github.com/EmbarkStudios/cargo-deny/issues/804). This error is ignored by `test-tidy` since the error message doesn't have the expected JSON fields, causing `test-tidy` to succeed even when there are valid issues in `deny.toml` or `Cargo.lock`. So upgrade the `cargo-deny` version installed by `mach` to be the latest version and ensure that at least the version with the fix is installed on the system. Also fix the `test-tidy` code to always fail when the exit code from `cargo-deny` is non-zero. This patch also updates `deny.toml` to include exceptions to allow `./mach test-tidy` to pass. Some of these need to be investigated separately from this change. Fixes #41845. Fixes #38945. Testing: Tested locally on NixOS. --------- Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>