mirror of
https://github.com/servo/servo
synced 2026-05-11 17:37:21 +02:00
Make HTMLOptionsCollection constructor accept a HTMLSelectElement argument. Fixes #15521 <!-- Please describe your changes on the following line: --> Moves the `HTMLSelectElement.upcast()` call into the `HTMLOptionsCollection` constructors, replacing their signatures with `&HTMLSelectElement` references. This limits the surface area for misuse by only allowing `HTMLSelectElement` instances to be passed in rather than `Node` instances. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15521. <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because: the linked issue explicitly says building without errors is good enough. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15527) <!-- Reviewable:end -->