bors-servo db41cc00be Auto merge of #19461 - jonleighton:issue-19171-4, r=KiChjang ...

Handle cases where selection API doesn't apply

The selection API only applies to certain <input> types:

https://html.spec.whatwg.org/multipage/#do-not-apply

This commit ensures that we handle that correctly.

Some notes:

1. TextControl::set_dom_selection_direction now calls
   set_selection_range(), which means that setting selectionDirection will
   now fire a selection event, as it should per the spec.

2. There is a test for the firing of the select event in
   tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/select-event.html,
   however the test did not run due to this syntax error:

   (pid:26017) "ERROR:script::dom::bindings::error: Error at http://web-platform.test:8000/html/semantics/forms/textfieldselection/select-event.html:50:11 missing = in const declaration"

   This happens due to the us of the "for (const foo of ...)" construct.
   Per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of
   this should actually work, so it's somewhat unsatisfying to have to
   change the test.

3. I removed tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-textarea.html
   because it doesn't seem to add any extra value - the selection API
   always applies to textarea elements, and the API is tested elsewhere.

4. If an `<input>`'s type is unset, it defaults to a text, and the
   selection API applies. Also, if an `<input>`'s type is set to an
   invalid value, it defaults to a text too. This second case doesn't
   currently work, and I'll need to do more restructuring of the code in
   a future commit. See discussion with nox in IRC:
   https://mozilla.logbot.info/servo/20171201#c13946454-c13946594

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19461)
<!-- Reviewable:end -->

2017-12-10 18:37:58 -06:00

..

docs

…

dom

Auto merge of #19461 - jonleighton:issue-19171-4, r=KiChjang

2017-12-10 18:37:58 -06:00

task_source

added pipelines to all task sources

2017-10-25 14:25:58 +01:00

body.rs

…

build.rs

…

Cargo.toml

Update euclid, azure, skia, offscreen_gl_context, plane-split, webrender

2017-12-08 14:32:28 +01:00

clipboard_provider.rs

…

CMakeLists.txt

…

devtools.rs

Bump bitflags to 1.0 in every servo crate

2017-10-30 23:36:06 +01:00

document_loader.rs

Fetch cancellation: Add cancel_chan to FetchContext

2017-11-17 15:59:59 -08:00

fetch.rs

Add FetchCanceller RAII handle

2017-11-21 16:45:03 -08:00

layout_image.rs

…

lib.rs

Make script depend on gecko-media

2017-11-14 17:33:25 +01:00

mem.rs

…

microtask.rs

…

network_listener.rs

…

script_runtime.rs

Bump bitflags to 1.0 in every servo crate

2017-10-30 23:36:06 +01:00

script_thread.rs

Print url of recorded PWM

2017-12-07 20:58:31 +01:00

serviceworker_manager.rs

…

serviceworkerjob.rs

added pipelines to all task sources

2017-10-25 14:25:58 +01:00

stylesheet_loader.rs

Use encoding-rs instead of rust-encoding for CSS parsing

2017-10-31 19:08:43 +01:00

task.rs

…

test.rs

…

textinput.rs

Handle cases where selection API doesn't apply

2017-12-08 21:07:05 +01:00

timers.rs

…

unpremultiplytable.rs

…

webdriver_handlers.rs

…