Feature: improve transfer matcher UI copy (#1526)

* refactor: improve UI copy for transaction matcher drawer

* refactor: transfer matcher UI copy

* fix: improvement

* feat: use i18n

app/views/transactions/show.html.erb

@@ -349,7 +349,7 @@
           <div class="flex items-center justify-between gap-4 p-3">
             <div class="text-sm space-y-1">
               <h4 class="text-primary">Transfer or Debt Payment?</h4>
-              <p class="text-secondary">Transfers and payments are special types of transactions that indicate money movement between 2 accounts.</p>
+              <p class="text-secondary"><%= t(".transfer_matcher_description") %></p>
             </div>
             <%= render DS::Link.new(
               text: "Open matcher",

app/views/transfer_matches/new.html.erb

@@ -1,5 +1,5 @@
 <%= render DS::Dialog.new do |dialog| %>
-  <% dialog.with_header(title: "Match transfer or payment") %>
+  <% dialog.with_header(title: t(".header.title"), subtitle: t(".header.subtitle")) %>
   <% dialog.with_body do %>
     <%= styled_form_with(
           url: transaction_transfer_match_path(@entry),

config/locales/views/transactions/en.yml

@@ -45,6 +45,7 @@ en:
       convert_to_trade_title: Convert to Security Trade
       convert_to_trade_description: Convert this transaction into a Buy or Sell trade with security details for portfolio tracking.
       convert_to_trade_button: Convert to Trade
+      transfer_matcher_description: Connect this transaction to its counterpart in another account.
       pending_duplicate_merger_title: Duplicate of Posted Transaction?
       pending_duplicate_merger_description: Manually merge this pending transaction with its posted version.
       pending_duplicate_merger_button: Open merger

config/locales/views/transfer_matches/en.yml

@@ -0,0 +1,7 @@
+---
+en:
+  transfer_matches:
+    new:
+      header:
+        title: Match transfer or payment
+        subtitle: Match the corresponding transaction in another account or create one if it doesn't exist.