eliott/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure synced 2026-04-25 17:15:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: preserve Generic investment subtypes in account creation form (#1465)

Browse Source 
* Addressable RegExp Denial of Service

* fix: preserve Generic investment subtypes in account creation form

The .compact call in Investment.subtypes_grouped_for_select removed
all nil values from the region order array, which inadvertently
excluded Generic subtypes (region: nil) from the dropdown for all
users regardless of currency setting.

Replace .compact with conditional logic that preserves nil in the
region order while still handling the user_region placement.

Closes #1446

* Breakage on `main` reverted

* style: fix SpaceInsideArrayLiteralBrackets lint offense

Add spaces inside array literal brackets to match project Rubocop rules.

---------

Co-authored-by: Juan José Mata <jjmata@jjmata.com>
Co-authored-by: khanhkhanhlele <namkhanh2172@gmail.com>
This commit is contained in:
xinmotlanthua
2026-04-16 01:10:22 +07:00
committed by GitHub
parent 9c199a6dcd
commit 92e1b64d03
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/models/investment.rb
View File

@@ -102,7 +102,11 @@ class Investment < ApplicationRecord
# Build region order: user's region first (if known), then Generic, then others
other_regions = %w[us uk ca au eu] - [ user_region ].compact
region_order = [ user_region, nil, *other_regions ].compact.uniq
region_order = if user_region
[ user_region, nil, *other_regions ].uniq
else
[ nil, *other_regions ].uniq
end
region_order.filter_map do |region|
next unless grouped[region]