eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-04-25 17:15:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

net: Update expected Accept-Language header in tests to use current locale. (#44340)

Browse Source 
Our choice is to either override the user's locale or updated the
expected result to depend on the locale. Updating the expectation seemed
easier.

Testing: Unit tests pass locally, but CI runs with the en-US locale so
there's no observable difference.
Fixes: #43069

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews
2026-04-19 04:08:01 -04:00
committed by GitHub
parent 345fd4573f
commit 4e267b2f09
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
components/net/tests/fetch.rs
View File

@@ -41,7 +41,7 @@ use net_traits::request::{
use net_traits::response::{CacheState, Response, ResponseBody, ResponseType};
use net_traits::{
FetchTaskTarget, IncludeSubdomains, NetworkError, ReferrerPolicy, ResourceFetchTiming,
ResourceTimingType,
ResourceTimingType, get_current_locale,
};
use parking_lot::Mutex;
use servo_arc::Arc as ServoArc;
@@ -1449,7 +1449,7 @@ fn test_fetch_with_devtools() {
headers.insert(header::ACCEPT, HeaderValue::from_static("*/*"));
headers.insert(header::ACCEPT_LANGUAGE, HeaderValue::from_static("en-US"));
headers.insert(header::ACCEPT_LANGUAGE, get_current_locale().1.clone());
headers.typed_insert::<UserAgent>(DEFAULT_USER_AGENT.parse().unwrap());

6
components/net/tests/http_loader.rs
View File

@@ -41,7 +41,7 @@ use net_traits::request::{
TraversableForUserPrompts, create_request_body_with_content,
};
use net_traits::response::{Response, ResponseBody};
use net_traits::{CookieSource, FetchTaskTarget, NetworkError, ReferrerPolicy};
use net_traits::{CookieSource, FetchTaskTarget, NetworkError, ReferrerPolicy, get_current_locale};
use parking_lot::{Mutex, RwLock};
use servo_base::id::{TEST_PIPELINE_ID, TEST_WEBVIEW_ID};
use servo_url::{ImmutableOrigin, ServoUrl};
@@ -202,7 +202,7 @@ fn test_check_default_headers_loaded_in_every_request() {
HeaderValue::from_static("text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8"),
);
headers.insert(header::ACCEPT_LANGUAGE, HeaderValue::from_static("en-US"));
headers.insert(header::ACCEPT_LANGUAGE, get_current_locale().1.clone());
headers.typed_insert::<UserAgent>(crate::DEFAULT_USER_AGENT.parse().unwrap());
@@ -360,7 +360,7 @@ fn test_request_and_response_data_with_network_messages() {
HeaderValue::from_static("text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8"),
);
headers.insert(header::ACCEPT_LANGUAGE, HeaderValue::from_static("en-US"));
headers.insert(header::ACCEPT_LANGUAGE, get_current_locale().1.clone());
headers.typed_insert::<UserAgent>(crate::DEFAULT_USER_AGENT.parse().unwrap());