eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-04-25 17:15:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

wpt: Disable proxy for test-wpt unless users know what they are doing (#41441)

Browse Source 
Nowadays Servo automatically loads system default proxy. It has enabled
my NSA colleagues to visit external networks without modifying transport
layer, whereas `test-wpt` has been failing after it.

We disable the proxy unless users know what they are doing.

Testing: Tested in different physical locations with different proxy
networks.
Fixes: #41440

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This commit is contained in:
Euclid Ye
2025-12-21 15:22:06 +08:00
committed by GitHub
parent bbacb7e119
commit 6964956110
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
python/wpt/run.py
View File

@@ -79,8 +79,16 @@ def run_tests(default_binary_path: str, **kwargs: Any) -> int:
prefs = kwargs.pop("prefs")
kwargs.setdefault("binary_args", [])
given_http_proxy_uri = False
if prefs:
kwargs["binary_args"] += ["--pref=" + pref for pref in prefs]
for pref in prefs:
kwargs["binary_args"].append("--pref=" + pref)
given_http_proxy_uri |= "network_http_proxy_uri" in pref
# We clearly dictates no proxy unless users know what they are doing.
# This is to override potential default http_proxy/https_proxy.
if not given_http_proxy_uri:
kwargs["binary_args"].append("--pref=network_http_proxy_uri=")
if not kwargs.get("no_default_test_types"):
test_types = {