eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-04-25 17:15:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

script: Make Node::clean_up_style_and_layout_data work as named (#44072)

Browse Source 
Do not `cancel_animations_for_node` for this function.
We can then reuse it more often.

Testing: Just a refactor.

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This commit is contained in:
Euclid Ye
2026-04-10 08:11:19 +08:00
committed by GitHub
parent 65b917bd4f
commit 8b61ca94fc
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
components/script/dom/node/node.rs
View File

@@ -374,7 +374,6 @@ impl Node {
}
pub(crate) fn clean_up_style_and_layout_data(&self) {
self.owner_doc().cancel_animations_for_node(self);
self.style_data.borrow_mut().take();
self.layout_data.borrow_mut().take();
}
@@ -411,6 +410,7 @@ impl Node {
// Since both the initial traversal in light dom and the inner traversal
// in shadow DOM share the same code, we define a closure to prevent omissions.
let cleanup_node = |node: &Node| {
node.owner_doc().cancel_animations_for_node(node);
node.clean_up_style_and_layout_data();
// Step 11 & 14.1. Run the removing steps.
@@ -466,8 +466,7 @@ impl Node {
// Since both the initial traversal in light dom and the inner traversal
// in shadow DOM share the same code, we define a closure to prevent omissions.
let cleanup_node = |node: &Node| {
node.style_data.borrow_mut().take();
node.layout_data.borrow_mut().take();
node.clean_up_style_and_layout_data();
};
for node in root.traverse_preorder(ShadowIncluding::No) {