eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-04-25 17:15:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

servoshell: Always exit via RunningAppState::schedule_exit (#40953)

Browse Source 
This prevents crashes when exiting servoshell in different situations.
For instance, this fixes a crash when running WPT tests on some systems.

Testing: This fixes an issue when running WPT tests locally.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson
2025-11-29 12:26:25 +01:00
committed by GitHub
parent b5e78199a1
commit 8c24a80a04
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ports/servoshell/egl/app.rs
View File

@@ -349,7 +349,7 @@ impl App {
/// Request shutdown. Will call on_shutdown_complete.
pub fn request_shutdown(&self) {
self.state.servo.start_shutting_down();
self.state.schedule_exit();
self.spin_event_loop();
}

2
ports/servoshell/running_app_state.rs
View File

@@ -297,7 +297,7 @@ impl RunningAppState {
}
if self.servoshell_preferences.exit_after_stable_image && self.achieved_stable_image.get() {
self.servo.start_shutting_down();
self.schedule_exit();
}
// When a ServoShellWindow has no more WebViews, close it. When no more windows are open, exit

2
ports/servoshell/webdriver.rs
View File

@@ -142,7 +142,7 @@ impl RunningAppState {
let _ = sender.send(());
},
WebDriverCommandMsg::Shutdown => {
self.servo().start_shutting_down();
self.schedule_exit();
},
WebDriverCommandMsg::IsWebViewOpen(webview_id, sender) => {
let context = self.webview_by_id(webview_id);