eliott/servo
1
0
Fork 0
mirror of https://github.com/servo/servo synced 2026-04-25 17:15:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

layout: Avoid unnecessary borrow in TextRun::segment_text_by_font() (#44279)

Browse Source 
No need to borrow `self.inline_styles.style` when the result is already
available as a parameter of the function.

Also, avoid calling `parent_style.get_font()` multiple times.

Testing: Not needed, no behavior change

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
Oriol Brufau
2026-04-16 19:17:37 +02:00
committed by GitHub
parent 2cb556a87a
commit 9ef8fe5e42
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
components/layout/flow/inline/text_run.rs
View File

@@ -442,20 +442,17 @@ impl TextRun {
bidi_info: &BidiInfo,
parent_style: &ServoArc<ComputedValues>,
) -> Vec<TextRunSegment> {
let font_group = layout_context
.font_context
.font_group(parent_style.clone_font());
let font_style = parent_style.clone_font();
let language = font_style._x_lang.0.parse().unwrap_or(Language::UND);
let font_size = font_style.font_size.computed_size().into();
let font_group = layout_context.font_context.font_group(font_style);
let mut current: Option<TextRunSegment> = None;
let mut results = Vec::new();
let x_lang = parent_style.get_font()._x_lang.clone();
let language = x_lang.0.parse().unwrap_or(Language::UND);
let text_run_text = &formatting_context_text[self.text_range.clone()];
let char_iterator = TwoCharsAtATimeIterator::new(text_run_text.chars());
let parent_style = self.inline_styles.style.borrow().clone();
let inherited_text_style = parent_style.get_inherited_text().clone();
let font_size = parent_style.get_font().font_size.computed_size().into();
let word_spacing = Some(inherited_text_style.word_spacing.to_used_value(font_size));
let letter_spacing = inherited_text_style
.letter_spacing