replaceWith <document> in a cycle should not panic (linux-wpt)

{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "coverage": false, "build_args": "", "wpt_args": "", "number_of_wpt_chunks": 20}]}

.clippy.toml

@@ -0,0 +1,2 @@
+# Lint for https://github.com/advisories/GHSA-r6v5-fh4h-64xc until we upgrade to time >=0.3.47
+disallowed-types = ["time::format_description::well_known::Rfc2822"]

.config/nextest.toml

@@ -1,6 +1,7 @@
 [profile.default]
 # Print a slow warning after period, terminate unit-test after 4x period.
 slow-timeout = { period = "5s", terminate-after = 4 }
+status-level = "leak"
 
 [profile.ci]
 fail-fast = false

.devcontainer/Dockerfile

@@ -1,48 +0,0 @@
-# Dockerfile for the servo devcontainer environment.
-# Note that the build-context is the repository root.
-# We use a multi-stage build to keep the final image size down.
-
-# We use a prebuilt image for `uv` to speed up builds and later copy the artifacts
-# into the final stage.
-FROM ghcr.io/astral-sh/uv:latest AS uv
-
-FROM ubuntu:24.04 AS base
-
-# Install apt dependencies.
-COPY python/servo/platform/linux_packages /tmp/linux_packages
-RUN apt-get update \
-    &&  /tmp/linux_packages/generate_pkg_list.sh /tmp/linux_packages/apt/* | xargs apt-get install -y --no-install-recommends \
-    && curl --version
-
-# Please keep `RUST_VERSION` in sync with the `rust-toolchain.toml` file.
-ENV RUSTUP_HOME=/usr/local/rustup \
-    CARGO_HOME=/usr/local/cargo \
-    PATH=/usr/local/cargo/bin:$PATH \
-    UV_TOOL_BIN_DIR=/usr/local/bin \
-    RUST_VERSION=1.92.0
-
-# Keep the list of components in sync with `rust-toolchain.toml` file.
-RUN curl https://sh.rustup.rs -sSf \
-        | sh -s -- --default-toolchain ${RUST_VERSION} -y --component clippy,llvm-tools,llvm-tools-preview,rustc-dev,rustfmt,rust-src \
-    && \
-    rustup --version; \
-    cargo --version; \
-    rustc --version;
-
-# prebuilt rust tools we use
-FROM base AS rust_builder
-
-# TODO: We would need to use `ARG` and install specific versions, to ensure
-# that the tools are updated and not always cached.
-RUN cargo install cargo-deny cargo-nextest taplo-cli cargo-about --locked
-
-
-FROM base AS final
-
-COPY --from=rust_builder \
-    /usr/local/cargo/bin/cargo-deny \
-    /usr/local/cargo/bin/cargo-nextest \
-    /usr/local/cargo/bin/taplo \
-    /usr/local/cargo/bin/cargo-about \
-    /usr/local/cargo/bin/
-COPY --from=uv /uv /uvx /bin/

.devcontainer/Ubuntu.Dockerfile

@@ -0,0 +1,51 @@
+# Dockerfile for the servo devcontainer environment.
+# Note that the build-context is the repository root.
+# We use a multi-stage build to keep the final image size down.
+
+# We use a prebuilt image for `uv` to speed up builds and later copy the artifacts
+# into the final stage.
+FROM ghcr.io/astral-sh/uv:latest AS uv
+
+FROM ubuntu:24.04 AS base
+
+# Install apt dependencies.
+COPY python/servo/platform/linux_packages /tmp/linux_packages
+RUN apt-get update \
+    &&  /tmp/linux_packages/generate_pkg_list.sh /tmp/linux_packages/apt/* | xargs apt-get install -y --no-install-recommends \
+    && curl --version
+
+# Required due to https://github.com/servo/servo/issues/35029
+RUN apt purge -y fonts-droid-fallback
+
+# Please keep `RUST_VERSION` in sync with the `rust-toolchain.toml` file.
+ENV RUSTUP_HOME=/usr/local/rustup \
+    CARGO_HOME=/usr/local/cargo \
+    PATH=/usr/local/cargo/bin:$PATH \
+    UV_TOOL_BIN_DIR=/usr/local/bin \
+    RUST_VERSION=1.92.0
+
+# Keep the list of components in sync with `rust-toolchain.toml` file.
+RUN curl https://sh.rustup.rs -sSf \
+        | sh -s -- --default-toolchain ${RUST_VERSION} -y --component clippy,llvm-tools,llvm-tools-preview,rustc-dev,rustfmt,rust-src \
+    && \
+    rustup --version; \
+    cargo --version; \
+    rustc --version;
+
+# prebuilt rust tools we use
+FROM base AS rust_builder
+
+# TODO: We would need to use `ARG` and install specific versions, to ensure
+# that the tools are updated and not always cached.
+RUN cargo install cargo-deny cargo-nextest taplo-cli cargo-about --locked
+
+
+FROM base AS final
+
+COPY --from=rust_builder \
+    /usr/local/cargo/bin/cargo-deny \
+    /usr/local/cargo/bin/cargo-nextest \
+    /usr/local/cargo/bin/taplo \
+    /usr/local/cargo/bin/cargo-about \
+    /usr/local/cargo/bin/
+COPY --from=uv /uv /uvx /bin/

.devcontainer/Ubuntu.Dockerfile.dockerignore

@@ -0,0 +1,3 @@
+*
+!/.devcontainer
+!/python/servo/platform/linux_packages

.devcontainer/devcontainer.json

@@ -2,10 +2,12 @@
 // README at: https://github.com/devcontainers/templates/tree/main/src/ubuntu
 {
 	"name": "Ubuntu",
-	"build": {
-		"dockerfile": "Dockerfile",
-		"context": ".."
-	},
+	"image": "ghcr.io/servo/servo/devcontainer-ubuntu:latest",
+	// Alternatively, uncomment the "build" property below to build the image from the Dockerfile in this folder.
+	// "build": {
+	// 	"dockerfile": "Ubuntu.Dockerfile",
+	// 	"context": ".."
+	// },
 
 
 	// Most dependencies are installed in the image, but we run mach bootstrap to ensure
@@ -14,9 +16,17 @@
 	"postCreateCommand":
 		"./mach bootstrap --yes",
 
+	"mounts": [
+		"source=servo-cargo-target,target=/var/servo-cargo-target,type=volume"
+	],
+
 	"containerEnv": {
 		"CC": "clang",
 		"CXX": "clang++",
+		// at least on macOS the workspace directory can be mounted as case-insensitve,
+		// which causes build errors in mozjs. Using a volume avoids this issue, and can
+		// also improve performance.
+		"CARGO_TARGET_DIR": "/var/servo-cargo-target",
 		"UV_PROJECT_ENVIRONMENT": ".devcontainer-venv"
 	}
 }

.github/CODEOWNERS

@@ -39,6 +39,10 @@
 # Reviewers for XPath related code
 /components/xpath @simonwuelker
 
+# Reviewers for DevTools
+/components/devtools @atbrakhi @eerii
+/components/shared/devtools @atbrakhi @eerii
+
 # Reviewers for CI related code
 /.github/workflows @sagudev
 /.github/actions @sagudev

.github/ISSUE_TEMPLATE/roadmap.md

@@ -0,0 +1,25 @@
+---
+name: Roadmap Issue
+about: Create an issue to track in the Servo roadmap
+title: ''
+labels: B-roadmap
+assignees: ''
+
+---
+
+## Roadmap Issue
+
+**Description:**
+A clear and concise description of the work that will be done.
+
+**Area:** e.g. Layout, Script, Performance, ...
+
+**People:** Who are planning to work on this task.
+
+Leave it blank if it's just something interesting for the project,
+but nobody is planning to work on at the moment.
+
+---
+
+Feel free to add any other comments on the issue after this line.
+

.github/actions/parse_msrv/action.yml

@@ -12,10 +12,10 @@ runs:
       id: parse_version
       shell: bash
       run:  |
-        msrv=$(cargo metadata --no-deps --format-version 1 | jq -r '.packages[] | select(.name == "libservo") | .rust_version')
+        msrv=$(cargo metadata --no-deps --format-version 1 | jq -r '.packages[] | select(.name == "servo") | .rust_version')
         if [[ "${msrv}" == "null" ]]; then
-          echo "Failed to determine MSRV of libservo"
+          echo "Failed to determine MSRV of servo"
           exit 1
         fi
-        echo "libservo has a minimum supported Rust version of ${msrv}."
+        echo "servo has a minimum supported Rust version of ${msrv}."
         echo "LIBSERVO_RUST_VERSION=${msrv}" >> "$GITHUB_OUTPUT"

.github/actions/setup-python/action.yml

@@ -15,7 +15,7 @@ runs:
     # symlink to this version.
     - name: Setup system python
       if: ${{ inputs.skip-python-setup != 'true' }}
-      uses: actions/setup-python@v5
+      uses: actions/setup-python@v6
       with:
         python-version-file: ${{ inputs.python-version-file-path }}
     - name: Install uv

.github/dependabot.yml

@@ -52,6 +52,11 @@ updates:
     objc2-related:
       patterns:
         - "objc2*"
+    rustls-webpki-related:
+      patterns:
+        - rustls-webpki
+        - webpki-roots
+        - webpki-root-certs
     sea-query-related:
       patterns:
         - "sea-query"

.github/workflows/android.yml

@@ -70,7 +70,7 @@ jobs:
         timeout-minutes: 30
         run: sudo apt update && ./mach bootstrap --yes --skip-lints --skip-nextest
       - name: Set up JDK 17
-        uses: actions/setup-java@v4
+        uses: actions/setup-java@v5
         with:
           java-version: '17'
           distribution: 'temurin'
@@ -107,29 +107,32 @@ jobs:
           APK_SIGNING_KEY_PASS: ${{ secrets.APK_SIGNING_KEY_PASS }}
         run: |
           ./mach build --use-crown --locked --target ${{ matrix.target }} --profile ${{ inputs.profile }}
-          cp -r target/cargo-timings target/cargo-timings-android-${{ matrix.target }}
+          mv target/cargo-timings target/cargo-timings-android-${{ matrix.target }}
       # TODO: This is disabled since APK crashes during startup.
       # See https://github.com/servo/servo/issues/31134
       # - name: Script tests
       #   run: ./mach test-android-startup
       - name: Archive build timing
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: cargo-timings-android-${{ matrix.target }}-${{ inputs.profile }}
           # Using a wildcard here ensures that the archive includes the path.
           path: target/cargo-timings-*
+          if-no-files-found: error
       - name: Upload APK artifact
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         id: upload-apk
         with:
           name: ${{ inputs.profile }}-binary-android-${{ matrix.target }}
           path: target/android/${{ matrix.target }}/${{ inputs.profile }}/servoapp.apk
+          if-no-files-found: error
       - name: Upload AAR artifact
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         id: upload-aar
         with:
           name: ${{ inputs.profile }}-library-android-${{ matrix.target }}
           path: target/android/${{ matrix.target }}/${{ inputs.profile }}/servoview.aar
+          if-no-files-found: error
       - name: Collect artifact IDs needed by the release workflow
         if: matrix.target == 'aarch64-linux-android'
         id: artifact_ids

.github/workflows/bencher.yml

@@ -58,7 +58,7 @@ jobs:
     steps:
       - name: Runner select
         id: select
-        uses: servo/ci-runners/actions/runner-select@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
+        uses: servo/ci-runners/actions/runner-select@f0b81b95522256c64ee207b4236ec71fc23b99a1
         with:
           GITHUB_TOKEN: ${{ github.token }}
           github-hosted-runner-label: ubuntu-22.04
@@ -77,8 +77,8 @@ jobs:
     name: Bencher (${{ inputs.target }}) [${{ needs.runner-select.outputs.unique-id }}]
     runs-on: ${{ needs.runner-select.outputs.selected-runner-label }}
     steps:
-      - uses: servo/ci-runners/actions/checkout@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
-      - uses: actions/download-artifact@v4
+      - uses: servo/ci-runners/actions/checkout@f0b81b95522256c64ee207b4236ec71fc23b99a1
+      - uses: actions/download-artifact@v8
         with:
           name: ${{ inputs.profile }}-binary-${{ inputs.target }}
           path: ${{ inputs.profile }}-binary-${{ inputs.target }}

.github/workflows/book-export.yml

@@ -0,0 +1,70 @@
+name: Book Export
+on:
+  push:
+    branches:
+      - main
+
+jobs:
+  upstream:
+    # Run job only on servo/servo
+    if: github.repository == 'servo/servo'
+    runs-on: ubuntu-latest
+    environment:
+      name: book-sync
+      deployment: false
+    steps:
+      - name: Check out Servo
+        uses: actions/checkout@v6
+        with:
+          sparse-checkout: |
+            python/servo/platform/linux_packages
+          fetch-depth: '2'
+      - name: Check out Servo book
+        uses: actions/checkout@v6
+        with:
+          path: book
+          repository: 'servo/book'
+          token: ${{ secrets.BOOK_SYNC_TOKEN }}
+      - name: Check for changes
+        working-directory: python/servo/platform/linux_packages
+        id: changes
+        run: |
+          # Note: This check assumes the action only runs on `main`.
+          if git diff --quiet HEAD HEAD^ -- . ; then
+            echo "No changes detected, exiting."
+            echo "CHANGES=false" >> $GITHUB_OUTPUT
+          else
+            echo "Changes detected, exporting book."
+            ./generate_pkg_list.sh apt/apt_common.txt > ${{github.workspace}}/book/src/building/linux_packages/apt_common.txt
+            ./generate_pkg_list.sh apt/apt_ubuntu_only.txt > ${{github.workspace}}/book/src/building/linux_packages/apt_ubuntu_only.txt
+            ./generate_pkg_list.sh dnf/dnf_base.txt > ${{github.workspace}}/book/src/building/linux_packages/dnf_base.txt
+            ./generate_pkg_list.sh xbps/xbps_base.txt > ${{github.workspace}}/book/src/building/linux_packages/xbps_base.txt
+            echo "CHANGES=true" >> $GITHUB_OUTPUT
+          fi
+      - name: Commit changes
+        working-directory: book
+        if: ${{ steps.changes.outputs.CHANGES == 'true'}}
+        run: |
+          git config --local user.email "ghbot+book-sync@servo.org"
+          git config --local user.name "Book Sync Bot"
+          git add src/building/linux_packages/
+          git commit -m "linux: Update dependency list based on servo/servo@${GITHUB_SHA::13}"
+      - name: Push changes
+        if: ${{ steps.changes.outputs.CHANGES == 'true'}}
+        working-directory: book
+        run: git push 'https://${{ secrets.BOOK_SYNC_TOKEN }}@github.com/servo-bot/book.git' 'HEAD:linux_pkgs_sync_${{ github.sha }}'
+      - name: Open PR
+        if: ${{ steps.changes.outputs.CHANGES == 'true'}}
+        env:
+          GH_TOKEN: ${{ secrets.BOOK_SYNC_CREATE_PR_TOKEN }}
+          UPDATE_BRANCH: linux_pkgs_sync_${{ github.sha }}
+        working-directory: book
+        run: |
+          BODY=$(cat <<EOF
+          Update dependency list based on servo/servo@${GITHUB_SHA}
+          EOF
+          )
+          gh pr create \
+            --title "Sync Linux packages with servo (${GITHUB_SHA::7})" \
+            --repo servo/book \
+            --body "$BODY" --head servo-bot:${{ env.UPDATE_BRANCH }}

.github/workflows/docker.yml

@@ -0,0 +1,128 @@
+name: Build Docker image and push to GitHub Packages
+
+# This workflow file is adapted from the example at https://docs.github.com/en/packages/managing-github-packages-using-github-actions-workflows/publishing-and-installing-a-package-with-github-actions#upgrading-a-workflow-that-accesses-a-registry-using-a-personal-access-token
+on:
+  push:
+    branches:
+      - main
+    # Only rebuild if the Dockerfile or dependencies change.
+    paths: &container-paths
+      - '.devcontainer/**'
+      - 'python/servo/platform/linux_packages/**'
+      - '.github/workflows/docker.yml'
+  workflow_dispatch:
+  pull_request:
+    branches:
+      - main
+    paths: *container-paths
+
+env:
+  IMAGE_NAME: devcontainer-ubuntu
+  IMAGE_DOWNLOAD_PATH: docker-image-artifacts
+  # AMD64 and ARM64 label names are what docker chose
+  AMD64_IMAGE_ARCHIVE: devcontainer-ubuntu-amd64.tar
+  ARM64_IMAGE_ARCHIVE: devcontainer-ubuntu-arm64.tar
+  AMD64_IMAGE_ARTIFACT_NAME: devcontainer-ubuntu-image-amd64
+  ARM64_IMAGE_ARTIFACT_NAME: devcontainer-ubuntu-image-arm64
+
+jobs:
+  devcontainer_ubuntu_build:
+    runs-on: ${{ matrix.runner }}
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - arch: amd64
+            platform: linux/amd64
+            runner: ubuntu-24.04
+            image_archive: devcontainer-ubuntu-amd64.tar
+            image_artifact_name: devcontainer-ubuntu-image-amd64
+          - arch: arm64
+            platform: linux/arm64
+            runner: ubuntu-24.04-arm
+            image_archive: devcontainer-ubuntu-arm64.tar
+            image_artifact_name: devcontainer-ubuntu-image-arm64
+    permissions:
+      contents: read
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Build ${{ matrix.arch }} image
+        run: |
+          docker build . \
+            --file .devcontainer/Ubuntu.Dockerfile \
+            --platform ${{ matrix.platform }} \
+            --tag ${{ env.IMAGE_NAME }}:${{ matrix.arch }} \
+            --label "runnumber=${GITHUB_RUN_ID}"
+
+      - name: Save ${{ matrix.arch }} image
+        if: github.event_name != 'pull_request'
+        run: docker save --output "${{ matrix.image_archive }}" "${{ env.IMAGE_NAME }}:${{ matrix.arch }}"
+
+      - name: Upload ${{ matrix.arch }} image artifact
+        if: github.event_name != 'pull_request'
+        uses: actions/upload-artifact@v7
+        with:
+          name: ${{ matrix.image_artifact_name }}
+          path: ${{ matrix.image_archive }}
+          archive: false
+          if-no-files-found: error
+
+  devcontainer_ubuntu_publish:
+    runs-on: ubuntu-24.04
+    needs:
+      - devcontainer_ubuntu_build
+    # Use manual workflow dispatch in your fork to test changes.
+    if: (github.event_name == 'push' && github.repository_owner == 'servo') || github.event_name == 'workflow_dispatch'
+    permissions:
+      contents: read
+      packages: write
+    steps:
+      - uses: actions/download-artifact@v8
+        with:
+          path: ${{ env.IMAGE_DOWNLOAD_PATH }}
+          merge-multiple: true
+
+      - name: List downloaded image artifacts
+        run: ls -R "${{ env.IMAGE_DOWNLOAD_PATH }}"
+
+      - name: Derive image metadata
+        id: image_meta
+        run: |
+          IMAGE_ID=ghcr.io/${{ github.repository_owner }}/servo/${{ env.IMAGE_NAME }}
+
+          # This changes all uppercase characters to lowercase.
+          IMAGE_ID=$(echo "$IMAGE_ID" | tr '[A-Z]' '[a-z]')
+          # This strips the git ref prefix from the version.
+          VERSION=$(echo "${{ github.ref }}" | sed -e 's,.*/\(.*\),\1,')
+
+          # This uses the Docker `latest` tag convention.
+          [ "$VERSION" = "main" ] && VERSION=latest
+          
+          echo "IMAGE_ID=$IMAGE_ID"
+          echo "VERSION=$VERSION"
+
+          echo "image_id=$IMAGE_ID" >> "$GITHUB_OUTPUT"
+          echo "version=$VERSION" >> "$GITHUB_OUTPUT"
+          echo "multiarch_tag=$IMAGE_ID:$VERSION" >> "$GITHUB_OUTPUT"
+
+      - name: Log in to registry
+        run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin
+
+      - name: Push platform images and publish manifest list
+        run: |
+          for archive in "${{ env.AMD64_IMAGE_ARCHIVE }}" "${{ env.ARM64_IMAGE_ARCHIVE }}"; do
+            docker load --input "${{ env.IMAGE_DOWNLOAD_PATH }}/$archive"
+          done
+
+          IMAGE_TAGS=()
+
+          for arch in amd64 arm64; do
+            IMAGE=${{ steps.image_meta.outputs.image_id }}:$arch-${{ steps.image_meta.outputs.version }}
+            IMAGE_TAGS+=("$IMAGE")
+            docker tag ${{ env.IMAGE_NAME }}:$arch "$IMAGE"
+            docker push "$IMAGE"
+          done
+
+          # This pushes to the registry
+          docker buildx imagetools create --tag ${{ steps.image_meta.outputs.multiarch_tag }} "${IMAGE_TAGS[@]}"

.github/workflows/lint.yml

@@ -21,7 +21,7 @@ jobs:
     steps:
       - name: Runner select
         id: select
-        uses: servo/ci-runners/actions/runner-select@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
+        uses: servo/ci-runners/actions/runner-select@f0b81b95522256c64ee207b4236ec71fc23b99a1
         with:
           GITHUB_TOKEN: ${{ github.token }}
           # Before updating the GH action runner image for the nightly job, ensure
@@ -42,7 +42,7 @@ jobs:
     name: Lint [${{ needs.runner-select.outputs.unique-id }}]
     runs-on: ${{ needs.runner-select.outputs.selected-runner-label }}
     steps:
-      - uses: servo/ci-runners/actions/checkout@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
+      - uses: servo/ci-runners/actions/checkout@f0b81b95522256c64ee207b4236ec71fc23b99a1
         with:
           fetch-depth: 2
 

.github/workflows/linux-wpt.yml

@@ -46,7 +46,7 @@ jobs:
     steps:
       - name: Runner select
         id: select
-        uses: servo/ci-runners/actions/runner-select@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
+        uses: servo/ci-runners/actions/runner-select@f0b81b95522256c64ee207b4236ec71fc23b99a1
         with:
           GITHUB_TOKEN: ${{ github.token }}
           # Before updating the GH action runner image for the nightly job, ensure
@@ -80,7 +80,7 @@ jobs:
         if: github.event_name == 'pull_request_target'
         with:
           ref: refs/pull/${{ github.event.number }}/head
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         with:
           name: ${{ inputs.profile }}-binary-linux
           path: ${{ inputs.profile }}-binary-linux
@@ -101,9 +101,6 @@ jobs:
           sudo apt install -qy --no-install-recommends mesa-vulkan-drivers fonts-noto-cjk fonts-dejavu-extra
           # FIXME #35029
           sudo apt purge -y fonts-droid-fallback
-          sudo apt install -y jackd2 libjack-jackd2-0
-      - name: Start Dummy Audio Device
-        run: jackd -d dummy &
       - name: Sync from upstream WPT
         if: ${{ inputs.wpt-sync-from-upstream }}
         run: |
@@ -126,17 +123,19 @@ jobs:
         env:
           GITHUB_CONTEXT: ${{ toJson(github) }}
       - name: Archive results (filtered)
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         if: ${{ always() }}
         with:
           name: wpt-filtered-logs-linux-${{ matrix.chunk_id }}
           path: wpt-filtered-logs/*/
+          if-no-files-found: error
       - name: Archive results (full)
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         if: ${{ always() }}
         with:
           name: wpt-full-logs-linux-${{ matrix.chunk_id }}
           path: wpt-full-logs/*/
+          if-no-files-found: error
 
   report-test-results:
     name: Process WPT Results
@@ -145,14 +144,14 @@ jobs:
     needs: linux-wpt
     steps:
       - name: Merge logs (full)
-        uses: actions/upload-artifact/merge@v4
+        uses: actions/upload-artifact/merge@v7
         with:
           name: wpt-full-logs-linux
           pattern: wpt-full-logs-linux-*
           delete-merged: true
       # This job needs to be last. If no filtered results were uploaded, it will fail, but we want to merge other archives in that case.
       - name: Merge logs (filtered)
-        uses: actions/upload-artifact/merge@v4
+        uses: actions/upload-artifact/merge@v7
         with:
           name: wpt-filtered-logs-linux
           pattern: wpt-filtered-logs-linux-*
@@ -165,7 +164,7 @@ jobs:
         if: ${{ !cancelled() && !inputs.wpt-sync-from-upstream && github.event_name == 'pull_request_target' }}
         with:
           ref: refs/pull/${{ github.event.number }}/head
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         if: ${{ !cancelled() && !inputs.wpt-sync-from-upstream }}
         with:
           name: wpt-filtered-logs-linux
@@ -177,10 +176,11 @@ jobs:
           cat results/linux/*.log > stable-unexpected-results.log || true
       - name: Upload aggregated results
         if: ${{ !cancelled() && !inputs.wpt-sync-from-upstream }}
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: stable-unexpected-results-linux
           path: stable-unexpected-results.log
+          if-no-files-found: error
       - name: Report results
         if: ${{ !cancelled() && !inputs.wpt-sync-from-upstream }}
         run: |

.github/workflows/linux.yml

@@ -105,7 +105,7 @@ jobs:
     steps:
       - name: Runner select
         id: select
-        uses: servo/ci-runners/actions/runner-select@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
+        uses: servo/ci-runners/actions/runner-select@f0b81b95522256c64ee207b4236ec71fc23b99a1
         with:
           GITHUB_TOKEN: ${{ github.token }}
           # Before updating the GH action runner image for the nightly job, ensure
@@ -128,7 +128,7 @@ jobs:
     outputs:
       artifact_ids: ${{ steps.artifact_ids.outputs.artifact_ids }}
     steps:
-      - uses: servo/ci-runners/actions/checkout@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
+      - uses: servo/ci-runners/actions/checkout@f0b81b95522256c64ee207b4236ec71fc23b99a1
       - name: Free Disk Space (Ubuntu)
         uses: jlumbroso/free-disk-space@main
         if: ${{ runner.environment != 'self-hosted' }}
@@ -145,7 +145,9 @@ jobs:
       - name: Change Mirror Priorities
         if: ${{ runner.environment != 'self-hosted' }}
         uses: ./.github/actions/apt-mirrors
-      - uses: taiki-e/install-action@v2
+      - name: Install cargo nextest
+        if: ${{ inputs.unit-tests }}
+        uses: taiki-e/install-action@v2
         with:
           tool: nextest
       - name: Bootstrap dependencies
@@ -155,7 +157,7 @@ jobs:
           sudo apt update
           echo "wireshark-common wireshark-common/install-setuid boolean true" | sudo debconf-set-selections
           sudo apt install -qy tshark
-          ./mach bootstrap --yes --skip-lints
+          ./mach bootstrap --yes --skip-lints --skip-nextest
 
       # Always install crown, even on self-hosted runners, because it is tightly
       # coupled to the rustc version, and we may have the wrong version if the
@@ -166,7 +168,7 @@ jobs:
       - name: Build (${{ inputs.profile }})
         run: |
           ./mach build --use-crown --locked --profile ${{ inputs.profile }} ${{ inputs.build-args }}
-          cp -r target/cargo-timings target/cargo-timings-linux
+          mv target/cargo-timings target/cargo-timings-linux
       - name: Smoketest
         run: xvfb-run ./mach smoketest --profile ${{ inputs.profile  }}
       - name: Script tests
@@ -195,19 +197,21 @@ jobs:
         if: ${{ false && inputs.unit-tests }} # FIXME #39273
         run: ./mach test-devtools --profile ${{ inputs.profile }}
       - name: Archive build timing
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: cargo-timings-linux-${{ inputs.profile }}
           # Using a wildcard here ensures that the archive includes the path.
           path: target/cargo-timings-*
+          if-no-files-found: error
       - name: Build mach package
         run: ./mach package --profile ${{ inputs.profile }}
       - name: Upload artifact for mach package
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         id: upload-tarball
         with:
           name: ${{ inputs.profile }}-binary-linux
           path: target/${{ inputs.profile }}/servo-tech-demo.tar.gz
+          if-no-files-found: error
       - name: Collect artifact IDs needed by the release workflow
         id: artifact_ids
         shell: bash
@@ -224,7 +228,7 @@ jobs:
       profile: ${{ inputs.profile }}
       wpt-sync-from-upstream: ${{ inputs.wpt-sync-from-upstream }}
       number-of-wpt-chunks: ${{ inputs. number-of-wpt-chunks }}
-      binary-path: servo/servo
+      binary-path: servo/servoshell
     secrets: inherit
 
   bencher:
@@ -235,7 +239,7 @@ jobs:
       target: "linux"
       profile: ${{ inputs.profile }}
       compressed-file-path: ${{ inputs.profile }}-binary-linux/servo-tech-demo.tar.gz
-      binary-path: servo/servo
+      binary-path: servo/servoshell
       file-size: true
       # We only evaluate speedometer and dromaeo score in release
       speedometer: ${{ inputs.profile == 'release' }}
@@ -276,9 +280,18 @@ jobs:
         uses: dtolnay/rust-toolchain@master
         with:
           toolchain: ${{ steps.msrv.outputs.rust_version }}
+      # We can remove this after upgrading to Rust 1.90, but for now
+      # installing lld is the easiest way to get it in path.
+      - name: install lld
+        run: sudo apt-get install -y lld
       - name: Compile libservo with MSRV
+        env:
+          # lld seems to use less memory and prevents OOM errors during linking.
+          # We can remove this after upgrading to Rust 1.90, where lld will be the default.
+          RUSTFLAGS: "-C link-arg=-fuse-ld=lld"
+          LLVM_OBJDUMP: llvm-objdump-14
         run: |
-          cargo +${{ steps.msrv.outputs.rust_version }} build -p libservo --locked --all-targets
+          cargo +${{ steps.msrv.outputs.rust_version }} build -p servo --locked
 
   # Runs the underlying job (“workload”) on a self-hosted runner if available.
   runner-select-coverage:
@@ -291,7 +304,7 @@ jobs:
     steps:
       - name: Runner select
         id: select
-        uses: servo/ci-runners/actions/runner-select@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
+        uses: servo/ci-runners/actions/runner-select@f0b81b95522256c64ee207b4236ec71fc23b99a1
         with:
           GITHUB_TOKEN: ${{ github.token }}
           # Before updating the GH action runner image for the nightly job, ensure
@@ -313,7 +326,7 @@ jobs:
     runs-on: ${{ needs.runner-select-coverage.outputs.selected-runner-label }}
     continue-on-error: true
     steps:
-      - uses: servo/ci-runners/actions/checkout@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
+      - uses: servo/ci-runners/actions/checkout@f0b81b95522256c64ee207b4236ec71fc23b99a1
       - name: Free Disk Space (Ubuntu)
         uses: jlumbroso/free-disk-space@main
         if: ${{ runner.environment != 'self-hosted' }}
@@ -380,6 +393,13 @@ jobs:
         if: github.event_name != 'pull_request_target'
         with:
           fetch-depth: 1
+      # This is necessary to checkout the pull request if this run was triggered via a
+      # `pull_request_target` event.
+      - uses: actions/checkout@v5
+        if: github.event_name == 'pull_request_target'
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+          fetch-depth: 1
       - name: Change Mirror Priorities
         uses: ./.github/actions/apt-mirrors
       - name: Install Dependencies
@@ -393,6 +413,7 @@ jobs:
             gstreamer1.0-plugins-good \
             gstreamer1.0-plugins-ugly \
             gstreamer1.0-tools \
+            jackd2 \
             libasound2-plugins \
             libfaad2 \
             libffi7 \

.github/workflows/mac-arm64.yml

@@ -72,6 +72,11 @@ on:
 env:
   RUST_BACKTRACE: 1
   SHELL: /bin/bash
+  # Increment this to purge the cache (https://github.com/mozilla/sccache/blob/main/docs/GHA.md)
+  SCCACHE_GHA_VERSION: 1
+  SCCACHE_GHA_ENABLED: "true"
+  RUSTC_WRAPPER: "sccache"
+  CCACHE: "sccache"
   CARGO_INCREMENTAL: 0
 
 jobs:
@@ -104,13 +109,17 @@ jobs:
       - if: ${{ runner.environment == 'self-hosted' }}
         # Same as `git switch --detach FETCH_HEAD`, but fixes up dirty working
         # trees, in case the runner image was baked with a dirty working tree.
+        # Safeguard: -- means FETCH_HEAD is revision instead of path.
+        # See <https://github.com/servo/servo/pull/44309>
         run: |
           git switch --detach
-          git reset --hard FETCH_HEAD
+          git reset --hard FETCH_HEAD --
 
       - if: runner.environment != 'self-hosted'
         name: Setup Python
         uses: ./.github/actions/setup-python
+      - name: Run sccache-cache
+        uses: mozilla-actions/sccache-action@v0.0.9
 
       # Always install crown, even on self-hosted runners, because it is tightly
       # coupled to the rustc version, and we may have the wrong version if the
@@ -118,19 +127,21 @@ jobs:
       - name: Install crown
         run: cargo install --path support/crown
 
-      - uses: taiki-e/install-action@v2
+      - name: Install cargo nextest
+        if: ${{ inputs.unit-tests }}
+        uses: taiki-e/install-action@v2
         with:
           tool: nextest
 
       - if: runner.environment != 'self-hosted'
         name: Bootstrap
         run: |
-          ./mach bootstrap --yes --skip-lints
+          ./mach bootstrap --yes --skip-lints --skip-nextest
           brew install gnu-tar
       - name: Build (${{ inputs.profile }})
         run: |
           ./mach build --use-crown --locked --profile ${{ inputs.profile }}  ${{ inputs.build-args }}
-          cp -r target/cargo-timings target/cargo-timings-macos-arm64
+          mv target/cargo-timings target/cargo-timings-macos-arm64
       - name: Smoketest
         uses: nick-fields/retry@v3
         with: # See https://github.com/servo/servo/issues/30757
@@ -170,29 +181,32 @@ jobs:
           max_attempts: 2
           command: ./etc/ci/macos_package_smoketest.sh target/${{ inputs.profile }}/servo-tech-demo.dmg
       - name: Archive build timing
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: cargo-timings-macos-arm64-${{ inputs.profile }}
           # Using a wildcard here ensures that the archive includes the path.
           path: target/cargo-timings-*
+          if-no-files-found: error
       - name: Upload artifact for mach package
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         id: upload-dmg
         with:
           name: ${{ inputs.profile }}-binary-mac-arm64
           path: target/${{ inputs.profile }}/servo-tech-demo.dmg
+          if-no-files-found: error
       - name: Collect artifact IDs needed by the release workflow
         id: artifact_ids
         shell: bash
         run: |
           echo "artifact_ids=${{ steps.upload-dmg.outputs.artifact-id }}" >> $GITHUB_OUTPUT
       - name: Build package for target
-        run: gtar -czf target.tar.gz target/${{ inputs.profile }}/servo target/${{ inputs.profile }}/lib/*.dylib resources
+        run: gtar -czf target.tar.gz target/${{ inputs.profile }}/servoshell target/${{ inputs.profile }}/lib/*.dylib resources
       - name: Upload package for target
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: ${{ inputs.profile }}-binary-macos-arm64
           path: target.tar.gz
+          if-no-files-found: error
 
   wpt-2020:
     if: ${{ inputs.wpt }}
@@ -213,7 +227,7 @@ jobs:
       target: 'macos-arm64'
       profile: ${{ inputs.profile }}
       compressed-file-path: ${{ inputs.profile }}-binary-macos-arm64/target.tar.gz
-      binary-path: target/${{ inputs.profile }}/servo
+      binary-path: target/${{ inputs.profile }}/servoshell
       file-size: true
       speedometer: false
       dromaeo: false
@@ -246,4 +260,4 @@ jobs:
           toolchain: ${{ steps.msrv.outputs.rust_version }}
       - name: Compile libservo with MSRV
         run: |
-          cargo +${{ steps.msrv.outputs.rust_version }} build -p libservo --locked --all-targets
+          cargo +${{ steps.msrv.outputs.rust_version }} build -p servo --locked

.github/workflows/mac-wpt.yml

@@ -38,7 +38,7 @@ jobs:
         if: github.event_name == 'pull_request_target'
         with:
           ref: refs/pull/${{ github.event.number }}/head
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         with:
           name: ${{ inputs.profile }}-binary-${{ env.NAME }}
       - name: Setup Python
@@ -62,17 +62,19 @@ jobs:
             --filter-intermittents wpt-filtered-logs/${{ env.NAME }}/${{ matrix.chunk_id }}.json
             ${{ inputs.wpt-args }}
       - name: Archive results (filtered)
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         if: ${{ always() }}
         with:
           name: wpt-filtered-logs-${{ env.NAME }}-${{ matrix.chunk_id }}
           path: wpt-filtered-logs/*/
+          if-no-files-found: error
       - name: Archive results (full)
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         if: ${{ always() }}
         with:
           name: wpt-full-logs-${{ env.NAME }}-${{ matrix.chunk_id }}
           path: wpt-full-logs/*/
+          if-no-files-found: error
 
   report-test-results:
     name: Process WPT Results
@@ -81,13 +83,13 @@ jobs:
     needs: mac-wpt
     steps:
       - name: Merge logs (filtered)
-        uses: actions/upload-artifact/merge@v4
+        uses: actions/upload-artifact/merge@v7
         with:
           name: wpt-filtered-logs-${{ env.NAME }}
           pattern: wpt-filtered-logs-${{ env.NAME }}-*
           delete-merged: true
       - name: Merge logs (full)
-        uses: actions/upload-artifact/merge@v4
+        uses: actions/upload-artifact/merge@v7
         with:
           name: wpt-full-logs-${{ env.NAME }}
           pattern: wpt-full-logs-${{ env.NAME }}-*
@@ -103,11 +105,12 @@ jobs:
           cat results/${{ env.NAME }}/*.log > stable-unexpected-results.log || true
       - name: Upload aggregated results
         if: ${{ !cancelled() && !inputs.wpt-sync-from-upstream }}
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: stable-unexpected-results-${{ env.NAME }}
           path: stable-unexpected-results.log
-      - uses: actions/download-artifact@v4
+          if-no-files-found: error
+      - uses: actions/download-artifact@v8
         if: ${{ !cancelled() }}
         with:
           name: wpt-filtered-logs-${{ env.NAME }}

.github/workflows/mac.yml

@@ -87,7 +87,7 @@ jobs:
     steps:
       - name: Runner select
         id: select
-        uses: servo/ci-runners/actions/runner-select@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
+        uses: servo/ci-runners/actions/runner-select@f0b81b95522256c64ee207b4236ec71fc23b99a1
         with:
           GITHUB_TOKEN: ${{ github.token }}
           github-hosted-runner-label: macos-15-intel
@@ -114,7 +114,7 @@ jobs:
       - name: Kill XProtectBehaviorService
         run: |
           echo Killing XProtect.; sudo pkill -9 XProtect >/dev/null || true;
-      - uses: servo/ci-runners/actions/checkout@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
+      - uses: servo/ci-runners/actions/checkout@f0b81b95522256c64ee207b4236ec71fc23b99a1
 
       - if: runner.environment != 'self-hosted'
         name: Setup Python
@@ -126,19 +126,21 @@ jobs:
       - name: Install crown
         run: cargo install --path support/crown
 
-      - uses: taiki-e/install-action@v2
+      - name: Install cargo nextest
+        if: ${{ inputs.unit-tests }}
+        uses: taiki-e/install-action@v2
         with:
           tool: nextest
 
       - if: runner.environment != 'self-hosted'
         name: Bootstrap
         run: |
-          ./mach bootstrap --yes --skip-lints
+          ./mach bootstrap --yes --skip-lints --skip-nextest
           brew install gnu-tar
       - name: Build (${{ inputs.profile }})
         run: |
           ./mach build --use-crown --locked --profile ${{ inputs.profile }}  ${{ inputs.build-args }}
-          cp -r target/cargo-timings target/cargo-timings-macos
+          mv target/cargo-timings target/cargo-timings-macos
       - name: Smoketest
         uses: nick-fields/retry@v3
         with: # See https://github.com/servo/servo/issues/30757
@@ -178,29 +180,32 @@ jobs:
           max_attempts: 2
           command: ./etc/ci/macos_package_smoketest.sh target/${{ inputs.profile }}/servo-tech-demo.dmg
       - name: Archive build timing
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: cargo-timings-macos-${{ inputs.profile }}
           # Using a wildcard here ensures that the archive includes the path.
           path: target/cargo-timings-*
+          if-no-files-found: error
       - name: Upload artifact for mach package
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         id: upload-dmg
         with:
           name: ${{ inputs.profile }}-binary-mac
           path: target/${{ inputs.profile }}/servo-tech-demo.dmg
+          if-no-files-found: error
       - name: Collect artifact IDs needed by the release workflow
         id: artifact_ids
         shell: bash
         run: |
           echo "artifact_ids=${{ steps.upload-dmg.outputs.artifact-id }}" >> $GITHUB_OUTPUT
       - name: Build package for target
-        run: gtar -czf target.tar.gz target/${{ inputs.profile }}/servo target/${{ inputs.profile }}/lib/*.dylib resources
+        run: gtar -czf target.tar.gz target/${{ inputs.profile }}/servoshell target/${{ inputs.profile }}/lib/*.dylib resources
       - name: Upload package for target
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: ${{ inputs.profile }}-binary-macos
           path: target.tar.gz
+          if-no-files-found: error
 
   wpt-2020:
     if: ${{ inputs.wpt }}
@@ -221,7 +226,7 @@ jobs:
       target: 'macos'
       profile: ${{ inputs.profile }}
       compressed-file-path: ${{ inputs.profile }}-binary-macos/target.tar.gz
-      binary-path: target/${{ inputs.profile }}/servo
+      binary-path: target/${{ inputs.profile }}/servoshell
       file-size: true
       speedometer: false
       dromaeo: false
@@ -254,4 +259,4 @@ jobs:
           toolchain: ${{ steps.msrv.outputs.rust_version }}
       - name: Compile libservo with MSRV
         run: |
-          cargo +${{ steps.msrv.outputs.rust_version }} build -p libservo --locked --all-targets
+          cargo +${{ steps.msrv.outputs.rust_version }} build -p servo --locked

.github/workflows/main.yml

@@ -36,7 +36,7 @@ jobs:
         run: |
           {
             echo 'result<<EOF'
-            python ./python/servo/try_parser.py ${{ github.event_name == 'pull_request' && 'linux-unit-tests lint' || github.event_name == 'push' && 'full macos bencher production-bencher coverage' || 'fail-fast full macos-arm-unit-tests' }}
+            python ./python/servo/try_parser.py ${{ github.event_name == 'pull_request' && 'linux-unit-tests lint' || github.event_name == 'push' && 'full macos bencher production-bencher coverage' || 'fail-fast full' }}
             echo EOF
            } >> $GITHUB_OUTPUT
 
@@ -71,7 +71,7 @@ jobs:
       - build
     steps:
       - name: Merge build timings
-        uses: actions/upload-artifact/merge@v4
+        uses: actions/upload-artifact/merge@v7
         with:
           name: cargo-timings
           pattern: cargo-timings-*

.github/workflows/ohos.yml

@@ -16,7 +16,7 @@ on:
         type: boolean
     outputs:
       artifact_ids:
-        value: ${{ jobs.build.outputs.artifact_ids }}
+        value: ${{ jobs.build-openharmony.outputs.artifact_ids }}
         description: Comma-separated list of artifact IDs for the release artifacts
       optional_job_status:
         description: "Status of optional jobs (as an object)"
@@ -46,7 +46,7 @@ jobs:
   build-openharmony:
     name: OpenHarmony Build
     timeout-minutes: 60
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     strategy:
       matrix:
         target: ["aarch64-unknown-linux-ohos", "x86_64-unknown-linux-ohos"]
@@ -54,13 +54,13 @@ jobs:
       artifact_ids: ${{ steps.artifact_ids.outputs.artifact_ids }}
       signed: ${{ steps.signing_config.outputs.signed }}
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
         if: github.event_name != 'pull_request_target'
         with:
           fetch-depth: 2
       # This is necessary to checkout the pull request if this run was triggered via a
       # `pull_request_target` event.
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
         if: github.event_name == 'pull_request_target'
         with:
           ref: ${{ github.event.pull_request.head.sha }}
@@ -81,9 +81,9 @@ jobs:
           version: "6.0.0.1" # api 20 in openharmony
           fixup-path: true
       - name: Install node for hvigor
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
-          node-version: 18
+          node-version: 24
       - name: Install hvigor modules
         run: |
           mkdir ~/hvigor-installation
@@ -108,34 +108,38 @@ jobs:
           OHOS_BASE_SDK_HOME: ${{ steps.setup_sdk.outputs.ohos-base-sdk-home }}
         run: |
           ./mach build --locked --target ${{ matrix.target }} --profile ${{ inputs.profile }}
-          cp -r target/cargo-timings target/cargo-timings-ohos-${{ matrix.target }}
+          mv target/cargo-timings target/cargo-timings-ohos-${{ matrix.target }}
       - name: Archive build timing
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: cargo-timings-ohos-${{ matrix.target }}-${{ inputs.profile }}
           # Using a wildcard here ensures that the archive includes the path.
           path: target/cargo-timings-*
+          if-no-files-found: error
       - name: Upload shared library
         if: ${{ inputs.upload_library }}
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         id: upload-library
         with:
           name: ${{ inputs.profile }}-library-ohos-${{ matrix.target }}
-          path: target/aarch64-unknown-linux-ohos/production/libservoshell.so
+          path: target/${{ matrix.target }}/${{ inputs.profile }}/libservoshell.so
+          if-no-files-found: error
       - name: Upload signed HAP artifact
         if: ${{ env.SERVO_OHOS_SIGNING_CONFIG != '' }} # Build output has different name if not signed.
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         id: upload-hap-signed
         with:
           name: ${{ inputs.profile }}-binary-ohos-${{ matrix.target }}
           path: target/openharmony/${{ matrix.target }}/${{ inputs.profile }}/entry/build/default/outputs/default/servoshell-default-signed.hap
+          if-no-files-found: error
       - name: Upload unsigned HAP artifact
         if: ${{ env.SERVO_OHOS_SIGNING_CONFIG == '' }} # Build output has different name if not signed.
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         id: upload-hap-unsigned
         with:
           name: ${{ inputs.profile }}-binary-ohos-${{ matrix.target }}
           path: target/openharmony/${{ matrix.target }}/${{ inputs.profile }}/entry/build/default/outputs/default/servoshell-default-unsigned.hap
+          if-no-files-found: error
       - name: Collect artifact IDs needed by the release workflow
         # The implicit assumption here is that `upload_library` is true and the signed hap is uploaded,
         # since this output will only be consumed by the release workflow.
@@ -155,7 +159,7 @@ jobs:
     with:
       target: ohos-${{ matrix.target }}
       profile: ${{ inputs.profile }}
-      compressed-file-path: ${{ inputs.profile }}-binary-ohos-${{ matrix.target }}/servoshell-default-${{ needs.build.outputs.signed && 'signed' || 'unsigned' }}.hap
+      compressed-file-path: ${{ inputs.profile }}-binary-ohos-${{ matrix.target }}/servoshell-default-${{ needs.build-openharmony.outputs.signed && 'signed' || 'unsigned' }}.hap
       binary-path: libs/${{ matrix.target == 'aarch64-unknown-linux-ohos' && 'arm64-v8a' || matrix.target == 'x86_64-unknown-linux-ohos' && 'x86_64' }}/libservoshell.so
       file-size: true
       speedometer: false
@@ -178,19 +182,22 @@ jobs:
         run: git fetch --depth=1 origin $GITHUB_SHA
       - if: ${{ github.event_name == 'pull_request_target' }}
         run: git fetch --depth=1 origin ${{ github.event.pull_request.head.sha }}
+      # Safeguard: -- means FETCH_HEAD is revision instead of path.
+      # See <https://github.com/servo/servo/pull/44309>
       - run: |
           git switch --detach
-          git reset --hard FETCH_HEAD
+          git reset --hard FETCH_HEAD --
       - name: Adding test files to directory
         run: cp -r support/hitrace-bencher/* support/openharmony/AppScope/resources/resfile/
       - name: Build for aarch64 HarmonyOS
         run: |
           ./mach build --locked --target aarch64-unknown-linux-ohos --profile=${{ inputs.profile }} --flavor=harmonyos --no-default-features --features tracing,tracing-hitrace
-      - uses: actions/upload-artifact@v6
+      - uses: actions/upload-artifact@v7
         with:
           # Upload the **unsigned** artifact - We don't have the signing materials in pull request workflows
           name: servoshell-hos-${{ inputs.profile }}.hap
           path: target/openharmony/aarch64-unknown-linux-ohos/${{ inputs.profile }}/entry/build/harmonyos/outputs/default/servoshell-default-unsigned.hap
+          if-no-files-found: error
       - name: Save result as job output
         id: result
         if: always()
@@ -209,7 +216,7 @@ jobs:
       job_status: ${{ steps.result.outputs.JOB_STATUS }}
     if: github.repository == 'servo/servo' && needs.build-harmonyos-aarch64.outputs.job_status == 'success'
     steps:
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         with:
           # Name of the artifact to download.
           # If unspecified, all artifacts for the run are downloaded.
@@ -228,13 +235,13 @@ jobs:
           # to make sure we don't use a previous version if installation failed for some reason.
           hdc uninstall org.servo.servo
           hdc install -r servoshell-hos-signed.hap
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
         if: github.event_name != 'pull_request_target'
         with:
           fetch-depth: 0
       # This is necessary to checkout the pull request if this run was triggered via a
       # `pull_request_target` event.
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
         if: github.event_name == 'pull_request_target'
         with:
           ref: ${{ github.event.pull_request.head.sha }}
@@ -305,10 +312,11 @@ jobs:
         run: hitrace-bench -r support/hitrace-bencher/runs.json --bencher -p ${{ inputs.profile }}
       - name: Upload failure screenshots
         if: ${{ steps.hitrace_bench.success == 'failure' }}
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: bencher-${{ inputs.profile }}-failure-screenshot
           path: "/tmp/servo.jpeg"
+          if-no-files-found: error
       - name: Run speedometer
         id: speedometer
         run: uv run ./etc/ci/scenario/servo_speedometer.py ${{ inputs.profile }}
@@ -323,11 +331,12 @@ jobs:
           hdc file recv /data/local/tmp/servo.jpeg speedometer_error_logs/servo_hos_screenshot.jpeg
           # Todo: Upload logs. This is currently not possible since the test-speedometer-ohos command
           # sets a log filter, which filters everything except JS console output.
-      - uses: actions/upload-artifact@v6
+      - uses: actions/upload-artifact@v7
         if: ${{ !cancelled() && steps.speedometer.outcome == 'failure' }}
         with:
           name: ohos-speedometer-failure-${{ matrix.target }}-${{ inputs.profile }}
           path: speedometer_error_logs
+          if-no-files-found: error
       - name: Combining bencher files
         if: ${{ !cancelled() && steps.setup_complete.outcome == 'success' }}
         run: jq --compact-output --slurp add speedometer.json bench.json > combined-bencher.json
@@ -367,7 +376,7 @@ jobs:
       # This will ensure the scenario pyproject.toml is picked up and the correct venv used.
       UV_PROJECT: "etc/ci/scenario"
     steps:
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         with:
           # Name of the artifact to download.
           # If unspecified, all artifacts for the run are downloaded.
@@ -387,7 +396,7 @@ jobs:
           hdc uninstall org.servo.servo
           hdc install -r servoshell-hos-signed.hap
       - name: Checkout scenario scripts
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
         with:
           sparse-checkout: |
             etc/ci/scenario
@@ -420,10 +429,11 @@ jobs:
         run: uv run ./etc/ci/scenario/servo_test_slide.py
       - name: Upload failure screenshots
         if: ${{ steps.install_hap.outcome == 'success' && failure() }}
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: hos-${{ inputs.profile }}-scenario-failures-screenshots
           path: "servo_scenario_*_error.jpg"
+          if-no-files-found: error
       - name: Save result as job output
         id: result
         if: always()

.github/workflows/release.yml

@@ -13,6 +13,10 @@ on:
         description: '`true` to create a release on this repo, false to release to the nightly-releases repo'
         type: boolean
         default: false
+      crates_io:
+        description: '`true` to publish to crates.io'
+        type: boolean
+        default: false
       release_tag:
         required: true
         type: string
@@ -28,6 +32,9 @@ jobs:
     if: github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch'
     name: Create Draft GH Release
     runs-on: ubuntu-latest
+    environment: &publish-environment
+      name: publish
+      deployment: false
     steps:
       - id: create-release
         run: |
@@ -46,7 +53,7 @@ jobs:
           TEMP_TAG=$(basename "$RELEASE_URL")
           RELEASE_ID=$( \
             gh api -H "Accept: application/vnd.github+json" \
-            -H "X-GitHub-Api-Version: 2022-11-28" \
+            -H "X-GitHub-Api-Version: 2026-03-10" \
             "/repos/${RELEASE_REPO}/releases/tags/${TEMP_TAG}" \
             | jq '.id' \
           )
@@ -66,37 +73,64 @@ jobs:
         && (inputs.regular_release || false) == false
     name: Publish GH Release
     runs-on: ubuntu-latest
+    environment: *publish-environment
     steps:
-      - name: Publish as latest (success)
-        if: ${{ !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') }}
+      - name: Publish release (success)
+        if: ${{ !contains(needs.*.result, 'failure') && (!contains(needs.*.result, 'cancelled') && !cancelled()) }}
+        env:
+          MAKE_LATEST: ${{ github.event_name == 'schedule' && 'true' || 'false' }}
         run: |
           gh api \
             --method PATCH \
             -H "Accept: application/vnd.github+json" \
-            -H "X-GitHub-Api-Version: 2022-11-28" \
+            -H "X-GitHub-Api-Version: 2026-03-10" \
             /repos/${RELEASE_REPO}/releases/${RELEASE_ID} \
-            -F draft=false
-      - name: Publish as latest (failure)
-        if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}
+            -F draft=false \
+            -f make_latest="${MAKE_LATEST}"
+      - name: Publish release (failure)
+        if: ${{ contains(needs.*.result, 'failure') || (contains(needs.*.result, 'cancelled') || cancelled()) }}
         run: |
           gh api \
             --method PATCH \
             -H "Accept: application/vnd.github+json" \
-            -H "X-GitHub-Api-Version: 2022-11-28" \
+            -H "X-GitHub-Api-Version: 2026-03-10" \
             /repos/${RELEASE_REPO}/releases/${RELEASE_ID} \
-            -F prerelease=true -F draft=false
+            -F prerelease=true \
+            -F draft=false \
+            -f make_latest=false
     env:
       GITHUB_TOKEN: ${{ inputs.regular_release && github.token || secrets.NIGHTLY_REPO_TOKEN }}
       RELEASE_ID: ${{ needs.create-draft-release.outputs.release-id }}
     needs:
       - create-draft-release
       - upload-vendored-source
-      - upload-linux-nightly
-      - upload-win-nightly
-      - upload-mac-nightly
-      - upload-mac-arm64-nightly
-      - upload-android-nightly
-      - upload-ohos-nightly
+      - upload-artifacts-nightly
+      - upload-artifacts-release
+
+  publish-crates-io:
+    name: 'Publish to crates.io'
+    if: github.repository == 'servo/servo' && (inputs.crates_io || false)
+    environment:
+      name: publish_crates_io
+      deployment: false
+    runs-on: ubuntu-22.04
+    permissions:
+      id-token: write
+    steps:
+      - uses: actions/checkout@v6
+      - uses: rust-lang/crates-io-auth-action@v1
+        id: auth
+      - name: Publish to crates.io
+        env:
+          CARGO_REGISTRY_TOKEN: ${{ steps.auth.outputs.token }}
+          SERVO_CRATES_IO_SLEEP_AFTER_PUBLISH_SECONDS: "30"
+          SERVO_CRATES_IO_VERIFY_PUBLISHED_TIMEOUT_SECONDS: "300"
+          SERVO_CRATES_IO_VERIFY_PUBLISHED_INTERVAL_SECONDS: "10"
+        # Verification requires building, which is incredibly slow and also increases our attack surface.
+        # If we decide for an extra verification, we should add a seperate job before this one, which
+        # does a `dry-run` publish without any elevated permissions.
+        run: |
+          python3 etc/ci/publish_crates_io.py --no-verify
 
   build-win:
     # This job is only useful when run on upstream servo.
@@ -113,6 +147,7 @@ jobs:
     if: github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch'
     name: Upload vendored source archive
     runs-on: ubuntu-latest
+    environment: *publish-environment
     permissions:
       contents: write
       id-token: write
@@ -141,45 +176,100 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ inputs.regular_release && github.token || secrets.NIGHTLY_REPO_TOKEN }}
 
-  upload-win-nightly:
+  upload-artifacts-nightly:
     # Only run scheduled nightly builds on upstream servo.
     if: |
       (github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch')
         && (inputs.regular_release || false) == false
+    runs-on: ubuntu-latest
     permissions:
       id-token: write
       attestations: write
-    needs:
+    environment: *publish-environment
+    needs: &upload-artifacts-needs
       - create-draft-release
       - build-win
-    secrets:
-      github_upload_token: ${{ secrets.NIGHTLY_REPO_TOKEN }}
-      s3_upload_token: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
-    uses: ./.github/workflows/upload_release.yml
-    with:
-      artifact_ids: ${{ needs.build-win.outputs.artifact_ids }}
-      artifact_platform: windows-msvc
-      github_release_id: ${{ needs.create-draft-release.outputs.release-id }}
-      target_repo:  ${{ github.repository_owner }}/${{ inputs.regular_release && 'servo' || 'servo-nightly-builds' }}
+      - build-mac
+      - build-mac-arm64
+      - build-linux
+      - build-android
+      - build-ohos
+    strategy: &upload-artifacts-strategy
+      fail-fast: false
+      matrix:
+        include:
+          - artifact_ids: ${{ needs.build-win.outputs.artifact_ids }}
+            artifact_platform: windows-msvc
+          - artifact_ids: ${{ needs.build-mac.outputs.artifact_ids }}
+            artifact_platform: mac
+          - artifact_ids: ${{ needs.build-mac-arm64.outputs.artifact_ids }}
+            artifact_platform: mac-arm64
+          - artifact_ids: ${{ needs.build-linux.outputs.artifact_ids }}
+            artifact_platform: linux
+          - artifact_ids: ${{ needs.build-android.outputs.artifact_ids }}
+            artifact_platform: android
+          - artifact_ids: ${{ needs.build-ohos.outputs.artifact_ids }}
+            artifact_platform: ohos
+    env:
+      ARTIFACT_IDS: ${{ matrix.artifact_ids }}
+      ARTIFACT_PLATFORM: ${{ matrix.artifact_platform }}
+      GITHUB_RELEASE_ID: ${{ needs.create-draft-release.outputs.release-id }}
+      RELEASE_REPO: ${{ github.repository_owner }}/servo-nightly-builds
+      RELEASE_REPO_TOKEN: ${{ secrets.NIGHTLY_REPO_TOKEN }}
+      S3_UPLOAD_CREDENTIALS: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
+    steps: &upload-artifacts-steps
+      - uses: actions/checkout@v6
+        with:
+          sparse-checkout: |
+            .github
+            etc/ci
+          fetch-depth: '1'
+      - name: Setup Python
+        uses: ./.github/actions/setup-python
+      - name: Validate artifact IDs
+        run: |
+          if [[ -z "${ARTIFACT_IDS}" ]]; then
+            echo "Error: No artifact IDs provided."
+            echo "Help: Check the build job's outputs.artifact_ids value."
+            echo "If you recently renamed the build job without updating the corresponding output reference,"
+            echo "that is likely the cause of this error."
+            exit 1
+          fi
+      - uses: actions/download-artifact@v8
+        with:
+          artifact-ids: ${{ env.ARTIFACT_IDS }}
+          merge-multiple: true
+          path: release-artifacts
+      - name: Generate artifact attestation
+        uses: actions/attest-build-provenance@v3
+        with:
+          subject-path: 'release-artifacts/*'
+      - name: Upload release artifacts
+        run: |
+          ./etc/ci/upload_nightly.py "${ARTIFACT_PLATFORM}" \
+            --secret-from-environment \
+            --github-release-id "${GITHUB_RELEASE_ID}" \
+            release-artifacts/*
 
-  upload-win-release:
+  upload-artifacts-release:
     if: github.event_name == 'workflow_dispatch' && inputs.regular_release
+    runs-on: ubuntu-latest
+    environment: *publish-environment
     permissions:
       id-token: write
       attestations: write
       # Necessary for the github token to upload artifacts to the release.
       contents: write
-    needs:
-      - create-draft-release
-      - build-win
-    secrets:
-      s3_upload_token: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
-    uses: ./.github/workflows/upload_release.yml
-    with:
-      artifact_ids: ${{ needs.build-win.outputs.artifact_ids }}
-      artifact_platform: windows-msvc
-      github_release_id: ${{ needs.create-draft-release.outputs.release-id }}
-      target_repo: ${{ github.repository_owner }}/${{ inputs.regular_release && 'servo' || 'servo-nightly-builds' }}
+    needs: *upload-artifacts-needs
+    strategy: *upload-artifacts-strategy
+    env:
+      ARTIFACT_IDS: ${{ matrix.artifact_ids }}
+      ARTIFACT_PLATFORM: ${{ matrix.artifact_platform }}
+      GITHUB_RELEASE_ID: ${{ needs.create-draft-release.outputs.release-id }}
+      RELEASE_REPO: ${{ github.repository_owner }}/servo
+      RELEASE_REPO_TOKEN: ${{ github.token }}
+      S3_UPLOAD_CREDENTIALS: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
+    steps: *upload-artifacts-steps
 
 
   build-mac:
@@ -191,46 +281,6 @@ jobs:
       profile: "production"
       force-github-hosted-runner: true  # <https://github.com/servo/servo/issues/33296>
 
-  upload-mac-nightly:
-    # Only run scheduled nightly builds on upstream servo.
-    if: |
-      (github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch')
-        && (inputs.regular_release || false) == false
-    permissions:
-      id-token: write
-      attestations: write
-    needs:
-      - create-draft-release
-      - build-mac
-    secrets:
-      github_upload_token: ${{ secrets.NIGHTLY_REPO_TOKEN }}
-      s3_upload_token: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
-    uses: ./.github/workflows/upload_release.yml
-    with:
-      artifact_ids: ${{ needs.build-mac.outputs.artifact_ids }}
-      artifact_platform: mac
-      github_release_id: ${{ needs.create-draft-release.outputs.release-id }}
-      target_repo:  ${{ github.repository_owner }}/${{ inputs.regular_release && 'servo' || 'servo-nightly-builds' }}
-
-  upload-mac-release:
-    if: github.event_name == 'workflow_dispatch' && inputs.regular_release
-    permissions:
-      id-token: write
-      attestations: write
-      # Necessary for the github token to upload artifacts to the release.
-      contents: write
-    needs:
-      - create-draft-release
-      - build-mac
-    secrets:
-      s3_upload_token: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
-    uses: ./.github/workflows/upload_release.yml
-    with:
-      artifact_ids: ${{ needs.build-mac.outputs.artifact_ids }}
-      artifact_platform: mac
-      github_release_id: ${{ needs.create-draft-release.outputs.release-id }}
-      target_repo:  ${{ github.repository_owner }}/${{ inputs.regular_release && 'servo' || 'servo-nightly-builds' }}
-
   build-mac-arm64:
     # This job is only useful when run on upstream servo.
     if: github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch'
@@ -240,46 +290,6 @@ jobs:
       profile: "production"
       force-github-hosted-runner: true  # <https://github.com/servo/servo/issues/33296>
 
-  upload-mac-arm64-nightly:
-    # Only run scheduled nightly builds on upstream servo.
-    if: |
-      (github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch')
-        && (inputs.regular_release || false) == false
-    permissions:
-      id-token: write
-      attestations: write
-    needs:
-      - create-draft-release
-      - build-mac-arm64
-    secrets:
-      github_upload_token: ${{ secrets.NIGHTLY_REPO_TOKEN }}
-      s3_upload_token: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
-    uses: ./.github/workflows/upload_release.yml
-    with:
-      artifact_ids: ${{ needs.build-mac-arm64.outputs.artifact_ids }}
-      artifact_platform: mac-arm64
-      github_release_id: ${{ needs.create-draft-release.outputs.release-id }}
-      target_repo: ${{ github.repository_owner }}/${{ inputs.regular_release && 'servo' || 'servo-nightly-builds' }}
-
-  upload-mac-arm64-release:
-    if: github.event_name == 'workflow_dispatch' && inputs.regular_release
-    permissions:
-      id-token: write
-      attestations: write
-      # Necessary for the github token to upload artifacts to the release.
-      contents: write
-    needs:
-      - create-draft-release
-      - build-mac-arm64
-    secrets:
-      s3_upload_token: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
-    uses: ./.github/workflows/upload_release.yml
-    with:
-      artifact_ids: ${{ needs.build-mac-arm64.outputs.artifact_ids }}
-      artifact_platform: mac-arm64
-      github_release_id: ${{ needs.create-draft-release.outputs.release-id }}
-      target_repo: ${{ github.repository_owner }}/${{ inputs.regular_release && 'servo' || 'servo-nightly-builds' }}
-
   build-linux:
     # This job is only useful when run on upstream servo.
     if: github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch'
@@ -289,96 +299,15 @@ jobs:
       profile: "production"
       force-github-hosted-runner: true  # <https://github.com/servo/servo/issues/33296>
 
-  upload-linux-nightly:
-    # Only run scheduled nightly builds on upstream servo.
-    if: |
-      (github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch')
-        && (inputs.regular_release || false) == false
-    permissions:
-      id-token: write
-      attestations: write
-    needs:
-      - create-draft-release
-      - build-linux
-    secrets:
-      github_upload_token: ${{ secrets.NIGHTLY_REPO_TOKEN }}
-      s3_upload_token: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
-    uses: ./.github/workflows/upload_release.yml
-    with:
-      artifact_ids: ${{ needs.build-linux.outputs.artifact_ids }}
-      artifact_platform: linux
-      github_release_id: ${{ needs.create-draft-release.outputs.release-id }}
-      target_repo: ${{ github.repository_owner }}/${{ inputs.regular_release && 'servo' || 'servo-nightly-builds' }}
-
-  upload-linux-release:
-    if: github.event_name == 'workflow_dispatch' && inputs.regular_release
-    permissions:
-      id-token: write
-      attestations: write
-      # Necessary for the github token to upload artifacts to the release.
-      contents: write
-    needs:
-      - create-draft-release
-      - build-linux
-    secrets:
-      s3_upload_token: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
-    uses: ./.github/workflows/upload_release.yml
-    with:
-      artifact_ids: ${{ needs.build-linux.outputs.artifact_ids }}
-      artifact_platform: linux
-      github_release_id: ${{ needs.create-draft-release.outputs.release-id }}
-      target_repo: ${{ github.repository_owner }}/${{ inputs.regular_release && 'servo' || 'servo-nightly-builds' }}
-
   build-android:
     # This job is only useful when run on upstream servo.
     if: github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch'
     name: Build release (Android)
     uses: ./.github/workflows/android.yml
     with:
-      profile: "release"
+      profile: "production"
     secrets: inherit
 
-  upload-android-nightly:
-    # Only run scheduled nightly builds on upstream servo.
-    if: |
-      (github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch')
-        && (inputs.regular_release || false) == false
-    permissions:
-      id-token: write
-      attestations: write
-    needs:
-      - create-draft-release
-      - build-android
-    secrets:
-      github_upload_token: ${{ secrets.NIGHTLY_REPO_TOKEN }}
-      s3_upload_token: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
-    uses: ./.github/workflows/upload_release.yml
-    with:
-      artifact_ids: ${{ needs.build-android.outputs.artifact_ids }}
-      artifact_platform: android
-      github_release_id: ${{ needs.create-draft-release.outputs.release-id }}
-      target_repo: ${{ github.repository_owner }}/${{ inputs.regular_release && 'servo' || 'servo-nightly-builds' }}
-
-  upload-android-release:
-    if: github.event_name == 'workflow_dispatch' && inputs.regular_release
-    permissions:
-      id-token: write
-      attestations: write
-      # Necessary for the github token to upload artifacts to the release.
-      contents: write
-    needs:
-      - create-draft-release
-      - build-android
-    secrets:
-      s3_upload_token: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
-    uses: ./.github/workflows/upload_release.yml
-    with:
-      artifact_ids: ${{ needs.build-android.outputs.artifact_ids }}
-      artifact_platform: android
-      github_release_id: ${{ needs.create-draft-release.outputs.release-id }}
-      target_repo: ${{ github.repository_owner }}/${{ inputs.regular_release && 'servo' || 'servo-nightly-builds' }}
-
-
   build-ohos:
     # This job is only useful when run on upstream servo.
     if: github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch'
@@ -388,43 +317,3 @@ jobs:
       profile: "production"
       upload_library: true
     secrets: inherit
-
-  upload-ohos-nightly:
-    # Only run scheduled nightly builds on upstream servo.
-    if: |
-      (github.repository == 'servo/servo' || github.event_name == 'workflow_dispatch')
-        && (inputs.regular_release || false) == false
-    permissions:
-      id-token: write
-      attestations: write
-    needs:
-      - create-draft-release
-      - build-ohos
-    secrets:
-      github_upload_token: ${{ secrets.NIGHTLY_REPO_TOKEN }}
-      s3_upload_token: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
-    uses: ./.github/workflows/upload_release.yml
-    with:
-      artifact_ids: ${{ needs.build-ohos.outputs.artifact_ids }}
-      artifact_platform: ohos
-      github_release_id: ${{ needs.create-draft-release.outputs.release-id }}
-      target_repo: ${{ github.repository_owner }}/${{ inputs.regular_release && 'servo' || 'servo-nightly-builds' }}
-
-  upload-ohos-release:
-    if: github.event_name == 'workflow_dispatch' && inputs.regular_release
-    permissions:
-      id-token: write
-      attestations: write
-      # Necessary for the github token to upload artifacts to the release.
-      contents: write
-    needs:
-      - create-draft-release
-      - build-ohos
-    secrets:
-      s3_upload_token: ${{ secrets.S3_UPLOAD_CREDENTIALS }}
-    uses: ./.github/workflows/upload_release.yml
-    with:
-      artifact_ids: ${{ needs.build-ohos.outputs.artifact_ids }}
-      artifact_platform: ohos
-      github_release_id: ${{ needs.create-draft-release.outputs.release-id }}
-      target_repo: ${{ github.repository_owner }}/${{ inputs.regular_release && 'servo' || 'servo-nightly-builds' }}

.github/workflows/scheduled-wpt-import.yml

@@ -29,7 +29,7 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v5
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         with:
           name: wpt-full-logs-linux
       - name: Setup Python

.github/workflows/try-label.yml

@@ -15,7 +15,7 @@ jobs:
       try_string: ${{ steps.try_string.outputs.result }}
     steps:
       - name: Collect Labels
-        uses: actions/github-script@v7
+        uses: actions/github-script@v8
         id: try_string
         with:
           result-encoding: string
@@ -87,7 +87,7 @@ jobs:
            } >> $GITHUB_OUTPUT
       - name: Comment Run Start
         if: ${{ steps.try_string.outputs.result }}
-        uses: actions/github-script@v7
+        uses: actions/github-script@v8
         with:
           result-encoding: string
           script: |

.github/workflows/try.yml

@@ -56,7 +56,7 @@ jobs:
            } >> $GITHUB_OUTPUT
       - name: Configuration
         id: configuration
-        uses: actions/github-script@v7
+        uses: actions/github-script@v8
         with:
           script: |
             // When triggered via a push try the `try` branch, search the last commit for a configuration object.
@@ -128,7 +128,7 @@ jobs:
     steps:
       - name: Merge build timings
         continue-on-error: true
-        uses: actions/upload-artifact/merge@v4
+        uses: actions/upload-artifact/merge@v7
         with:
           name: cargo-timings
           pattern: cargo-timings-*

.github/workflows/upload_release.yml

@@ -1,60 +0,0 @@
-name: Upload and Attest Release Assets
-on:
-  workflow_call:
-    inputs:
-      artifact_platform:
-        type: string
-        required: true
-        description: "The platform of the release artifacts to upload."
-      target_repo:
-        type: string
-        required: true
-        description: "The target repository owner and name (e.g. `servo/servo`) where the release will be created."
-      github_release_id:
-        type: string
-        required: true
-        description: "The ID of the GitHub release to which assets will be added."
-      artifact_ids:
-        required: true
-        type: string
-        description: "A comma-separated list of artifact IDs to upload."
-    secrets:
-      github_upload_token:
-        required: false
-        description: "A GitHub token with permission to upload release assets. If omitted github.token will be used instead."
-      s3_upload_token:
-        required: true
-        description: "A token with permission to upload release artifacts to our S3 bucket."
-
-
-jobs:
-  upload-artifact:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v6
-        with:
-          sparse-checkout: |
-            .github
-            etc/ci
-          fetch-depth: '1'
-      - name: Setup Python
-        uses: ./.github/actions/setup-python
-      - uses: actions/download-artifact@v7
-        with:
-          artifact-ids: ${{ inputs.artifact_ids }}
-          merge-multiple: true
-          path: release-artifacts
-      - name: Generate artifact attestation
-        uses: actions/attest-build-provenance@v3
-        with:
-          subject-path: 'release-artifacts/*'
-      - name: Upload release artifacts
-        run: |
-          ./etc/ci/upload_nightly.py ${{ inputs.artifact_platform}} \
-            --secret-from-environment \
-            --github-release-id ${{ inputs.github_release_id }} \
-            release-artifacts/*
-        env:
-          S3_UPLOAD_CREDENTIALS: ${{ secrets.s3_upload_token }}
-          RELEASE_REPO_TOKEN: ${{ secrets.github_upload_token || github.token }}
-          RELEASE_REPO: ${{ inputs.target_repo }}

.github/workflows/windows.yml

@@ -83,7 +83,7 @@ jobs:
     steps:
       - name: Runner select
         id: select
-        uses: servo/ci-runners/actions/runner-select@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
+        uses: servo/ci-runners/actions/runner-select@f0b81b95522256c64ee207b4236ec71fc23b99a1
         with:
           GITHUB_TOKEN: ${{ github.token }}
           github-hosted-runner-label: windows-2022
@@ -103,7 +103,7 @@ jobs:
     outputs:
       release_artifact_ids: ${{ steps.artifact_ids.outputs.release_artifact_ids }}
     steps:
-      - uses: servo/ci-runners/actions/checkout@6d88b19dda997f1ce2a11e4c1c34717c2bbcafba
+      - uses: servo/ci-runners/actions/checkout@f0b81b95522256c64ee207b4236ec71fc23b99a1
 
       - name: ccache
         # FIXME: “Error: Restoring cache failed: Error: Unable to locate executable file: sh.”
@@ -149,7 +149,7 @@ jobs:
       - name: Build (${{ inputs.profile }})
         run: |
           .\mach build --use-crown --locked --profile ${{ inputs.profile }} ${{ inputs.build-args }}
-          cp C:\a\servo\servo\target\cargo-timings C:\a\servo\servo\target\cargo-timings-windows -Recurse
+          mv C:\a\servo\servo\target\cargo-timings C:\a\servo\servo\target\cargo-timings-windows
       - name: Copy resources
         # GitHub-hosted runners sometimes check out the repo on D: drive.
         if: ${{ runner.environment != 'self-hosted' && startsWith(github.workspace, 'D:\') }}
@@ -157,13 +157,13 @@ jobs:
       - name: Smoketest
         run: .\mach smoketest --profile ${{ inputs.profile }}
       - name: Install cargo nextest
-        if: ${{ runner.environment != 'self-hosted' }}
+        if: ${{ runner.environment != 'self-hosted' && inputs.unit-tests }}
         uses: taiki-e/install-action@v2
         with:
           tool: nextest
       # On self-hosted windows runners the install-action fails
       - name: Install cargo nextest (self-hosted)
-        if: ${{ runner.environment == 'self-hosted' }}
+        if: ${{ runner.environment == 'self-hosted' && inputs.unit-tests }}
         run: cargo install cargo-nextest --locked
       - name: Unit tests
         if: ${{ inputs.unit-tests }}
@@ -188,30 +188,33 @@ jobs:
         if: ${{ false && inputs.unit-tests }}  # FIXME #39273
         run: .\mach test-devtools --profile ${{ inputs.profile }}
       - name: Archive build timing
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: cargo-timings-windows-${{ inputs.profile }}
           # Using a wildcard here ensures that the archive includes the path.
           path: C:\\a\\servo\\servo\\target\\cargo-timings-*
+          if-no-files-found: error
       - name: Build mach package
         run: .\mach package --profile ${{ inputs.profile }}
       # These files are available
       # MSI Installer: C:\a\servo\servo\target\${{ inputs.profile }}\msi\Installer.msi
-      # Bundle: C:\a\servo\servo\target\${{ inputs.profile }}\msi\Servo.exe
-      # Zip: C:\a\servo\servo\target\${{ inputs.profile }}\msi\Servo.zip
+      # Bundle: C:\a\servo\servo\target\${{ inputs.profile }}\msi\ServoShell.exe
+      # Zip: C:\a\servo\servo\target\${{ inputs.profile }}\msi\ServoShell.zip
       - name: Upload artifact for mach package
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         id: upload-exe
         with:
           name: ${{ inputs.profile }}-binary-windows
-          path: C:\\a\\servo\\servo\\target\\${{ inputs.profile }}\\msi\\Servo.exe
+          path: C:\\a\\servo\\servo\\target\\${{ inputs.profile }}\\msi\\ServoShell.exe
+          if-no-files-found: error
       - name: Upload artifact for mach package (zip)
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         id: upload-zip
         if: ${{ inputs.upload_zip }}
         with:
           name: ${{ inputs.profile }}-binary-windows-zip
-          path: C:\\a\\servo\\servo\\target\\${{ inputs.profile }}\\msi\\Servo.zip
+          path: C:\\a\\servo\\servo\\target\\${{ inputs.profile }}\\msi\\ServoShell.zip
+          if-no-files-found: error
       - name: Collect artifact IDs needed by the release workflow
         id: artifact_ids
         shell: bash
@@ -230,7 +233,7 @@ jobs:
       target: 'windows'
       profile: ${{ inputs.profile }}
       compressed-file-path: ''
-      binary-path: ${{ inputs.profile }}-binary-windows/Servo.exe
+      binary-path: ${{ inputs.profile }}-binary-windows/ServoShell.exe
       file-size: true
       speedometer: false
       dromaeo: false
@@ -263,4 +266,4 @@ jobs:
           toolchain: ${{ steps.msrv.outputs.rust_version }}
       - name: Compile libservo with MSRV
         run: |
-          cargo +${{ steps.msrv.outputs.rust_version }} build -p libservo --locked --all-targets
+          cargo +${{ steps.msrv.outputs.rust_version }} build -p servo --locked

.gitignore

@@ -29,6 +29,7 @@ servo.pftrace
 /glfw
 webrender-captures/
 /screenshots
+/etc/notarization/
 
 # Python setuptools
 /servo.egg-info

Cargo.toml

@@ -10,8 +10,11 @@ default-members = ["ports/servoshell"]
 exclude = [".cargo", "support/crown"]
 
 [workspace.package]
-version = "0.0.1"
+version = "0.1.0"
 authors = ["The Servo Project Developers"]
+repository = "https://github.com/servo/servo"
+# A generic description for packages that don't have a meaningful description yet.
+description = "A component of the servo web-engine."
 license = "MPL-2.0"
 edition = "2024"
 publish = false
@@ -33,46 +36,40 @@ app_units = "0.7"
 arboard = "3"
 argon2 = { version = "0.5", features = ["alloc"] }
 arrayvec = "0.7"
-async-tungstenite = { version = "0.33", features = ["tokio-rustls-webpki-roots"] }
-atomic_refcell = "0.1.13"
+async-tungstenite = { version = "0.34", features = ["tokio-rustls-webpki-roots"] }
+atomic_refcell = "0.1.14"
 aws-lc-rs = { version = "1.16", default-features = false, features = ["aws-lc-sys"] }
-background_hang_monitor_api = { package = "servo-background-hang-monitor-api", path = "components/shared/background_hang_monitor" }
 backtrace = "0.3"
-base = { package = "servo-base", path = "components/shared/base" }
 base64 = "0.22.1"
 base64ct = { version = "1.8", features = ["alloc"] }
 bitflags = "2.11"
-bluetooth_traits = { package = "servo-bluetooth-traits", path = "components/shared/bluetooth" }
 brotli = "8.0.2"
 bytemuck = "1"
 byteorder = "1.5"
-canvas_traits = { package = "servo-canvas-traits", path = "components/shared/canvas" }
+bytes = "1.0"
+byte-slice-cast = "1.2.3"
 cbc = "0.1.2"
 cfg-if = "1.0.4"
 chacha20poly1305 = "0.10"
 chardetng = "0.1"
 chrono = { version = "0.4", features = ["serde"] }
 cipher = { version = "0.4.4", features = ["alloc"] }
-constellation_traits = { package = "servo-constellation-traits", path = "components/shared/constellation" }
-content-security-policy = { version = "0.6.0", features = ["serde"] }
+content-security-policy = { version = "0.8.0", features = ["serde"] }
 cookie = { package = "cookie", version = "0.18" }
 crossbeam-channel = "0.5"
 cssparser = { version = "0.36", features = ["serde"] }
 ctr = "0.9.2"
 data-url = "0.3"
 der = { version = "0.7", features = ["alloc", "derive"] }
-devtools_traits = { package = "servo-devtools-traits", path = "components/shared/devtools" }
 digest = "0.10"
 dpi = "0.1"
 dwrote = "0.11.5"
 ecdsa = "0.16"
 elliptic-curve = "0.13"
-embedder_traits = { package = "servo-embedder-traits", path = "components/shared/embedder" }
 encoding_rs = { version = "0.8", features = ["serde"] }
 env_logger = "0.11"
 euclid = "0.22"
 flate2 = "1.1"
-fonts_traits = { package = "servo-fonts-traits", path = "components/shared/fonts" }
 freetype-sys = "0.20"
 futures = { version = "0.3", default-features = false }
 futures-core = { version = "0.3", default-features = false }
@@ -80,7 +77,7 @@ futures-util = { version = "0.3", default-features = false }
 gleam = "0.15"
 glib = "0.22"
 glib-sys = "0.22"
-glow = "0.16.0"
+glow = "0.17.0"
 gstreamer = { version = "0.25", features = ["v1_18"] }
 gstreamer-app = "0.25"
 gstreamer-audio = "0.25"
@@ -99,42 +96,42 @@ harfbuzz-sys = "0.6.1"
 headers = "0.4"
 hitrace = { version = "0.1.6", features = ["api-19", "tracing-rs"] }
 hkdf = "0.12"
-html5ever = "0.38"
+html5ever = "0.39"
 http = "1.4"
 http-body-util = "0.1"
-hyper = "1.8"
+hyper = "1.9"
 hyper-rustls = { version = "0.27", default-features = false, features = ["http1", "http2", "logging", "tls12", "webpki-tokio"] }
 hyper-util = { version = "0.1", features = ["client-legacy", "http2", "tokio", "client-proxy"] }
-hyper_serde = { package = "servo-hyper-serde", path = "components/hyper_serde" }
 icu_locid = "1.5.0"
+icu_properties = "1.5.0"
 icu_segmenter = "1.5.0"
 image = { version = "0.25", default-features = false, features = ["avif", "rayon", "bmp", "gif", "ico", "jpeg", "png", "webp"] }
 imsz = "0.4"
-indexmap = { version = "2.11.4", features = ["std"] }
+indexmap = { version = "2.14.0", features = ["std"] }
+inventory = { version = "0.3.24" }
 ipc-channel = "0.21"
 itertools = "0.14"
-js = { package = "mozjs", version = "=0.15.1", default-features = false, features = ["libz-sys", "intl"] }
+js = { package = "mozjs", version = "=0.15.9", default-features = false, features = ["libz-sys", "intl"] }
 keyboard-types = { version = "0.8.3", features = ["serde", "webdriver"] }
 kurbo = { version = "0.12", features = ["euclid"] }
-layout_api = { package = "servo-layout-api", path = "components/shared/layout" }
 libc = "0.2"
+lru = "0.17"
 log = "0.4.29"
 mach2 = "0.6"
-malloc_size_of = { package = "servo-malloc-size-of", path = "components/malloc_size_of" }
 malloc_size_of_derive = "0.1"
-markup5ever = "0.38"
+markup5ever = "0.39"
 memmap2 = "0.9.10"
 mime = "0.3.13"
 mime-multipart-hyper1 = "0.10.0"
 mime_guess = "2.0.5"
 ml-dsa = "0.0.4"
 ml-kem = { version = "0.2", features = ["deterministic"] }
-mozangle = "0.5.3"
-net_traits = { package = "servo-net-traits", path = "components/shared/net" }
+mozangle = "0.5.5"
 nix = "0.30"
 nom = "8.0.0"
 nom-rfc8288 = "0.4.0"
 num-bigint-dig = "0.8"
+num-complex = "0.4.6"
 num-derive = "0.4.2"
 num-traits = "0.2"
 num_cpus = "1.17.0"
@@ -144,7 +141,6 @@ objc2-core-graphics = "0.3.2"
 objc2-core-text = "0.3.2"
 ocb3 = "0.1.0"
 openxr = "0.20"
-paint_api = { package = "servo-paint-api", path = "components/shared/paint" }
 p256 = { version = "0.13", features = ["ecdh"] }
 p384 = { version = "0.13", features = ["ecdh"] }
 p521 = { version = "0.13", features = ["ecdh"] }
@@ -154,51 +150,46 @@ percent-encoding = "2.3"
 pkcs8 = { version = "0.10", features = ["rand_core"] }
 postcard = { version = "1.1.3", default-features = false, features = ["use-std"] }
 proc-macro2 = "1"
-profile_traits = { package = "servo-profile-traits", path = "components/shared/profile" }
 quote = "1"
 rand = "0.9"
+rangemap = "1.7.1"
 raw-window-handle = "0.6"
 rayon = "1"
 read-fonts = "0.35.0"
 regex = "1.12"
 resvg = "0.45.0"
 rsa = { version = "0.9.10", features = ["sha1", "sha2"] }
-rustc-hash = "2.1.1"
+rustc-hash = "2.1.2"
 rustls = { version = "0.23", default-features = false, features = ["logging", "std", "tls12"] }
 rustls-pki-types = "1.14"
-rustls-platform-verifier = "0.6.2"
-script_traits = { package = "servo-script-traits", path = "components/shared/script" }
-sea-query = { version = "1.0.0-rc.31", default-features = false, features = ["backend-sqlite", "derive"] }
-sea-query-rusqlite = { version = "0.8.0-rc.15" }
+rustls-platform-verifier = "0.7.0"
+sea-query = { version = "=1.0.0-rc.31", default-features = false, features = ["backend-sqlite", "derive"] }
+sea-query-rusqlite = { version = "=0.8.0-rc.15" }
 sec1 = "0.7"
-selectors = { git = "https://github.com/servo/stylo", rev = "2f131eb1909c6193a7cfae22e49f288fe9df4fbb" }
+selectors = { git = "https://github.com/servo/stylo", rev = "a556f4cbd15fc289039261661b049a5dc845cd80" }
 serde = "1.0.228"
 serde_bytes = "0.11"
 serde_core = "1.0.226"
 serde_json = "1.0"
-servo-media = { path = "components/media/servo-media" }
-servo-media-dummy = { path = "components/media/backends/dummy" }
-servo-media-gstreamer = { path = "components/media/backends/gstreamer" }
-servo-tracing = { path = "components/servo_tracing" }
-servo_arc = { git = "https://github.com/servo/stylo", rev = "2f131eb1909c6193a7cfae22e49f288fe9df4fbb" }
+servo_arc = { git = "https://github.com/servo/stylo", rev = "a556f4cbd15fc289039261661b049a5dc845cd80" }
 sha1 = "0.10"
 sha2 = "0.10"
 sha3 = "0.10"
+speexdsp-resampler = "0.1.0"
 skrifa = "0.37.0"
 smallvec = { version = "1.15", features = ["serde", "union"] }
-storage_traits = { package = "servo-storage-traits", path = "components/shared/storage" }
 string_cache = "0.9"
-strum = { version = "0.27", features = ["derive"] }
-stylo = { git = "https://github.com/servo/stylo", rev = "2f131eb1909c6193a7cfae22e49f288fe9df4fbb" }
-stylo_atoms = { git = "https://github.com/servo/stylo", rev = "2f131eb1909c6193a7cfae22e49f288fe9df4fbb" }
-stylo_dom = { git = "https://github.com/servo/stylo", rev = "2f131eb1909c6193a7cfae22e49f288fe9df4fbb" }
-stylo_malloc_size_of = { git = "https://github.com/servo/stylo", rev = "2f131eb1909c6193a7cfae22e49f288fe9df4fbb" }
-stylo_static_prefs = { git = "https://github.com/servo/stylo", rev = "2f131eb1909c6193a7cfae22e49f288fe9df4fbb" }
-stylo_traits = { git = "https://github.com/servo/stylo", rev = "2f131eb1909c6193a7cfae22e49f288fe9df4fbb" }
-surfman = { version = "0.11.0", features = ["chains"] }
+strum = { version = "0.28", features = ["derive"] }
+stylo = { git = "https://github.com/servo/stylo", rev = "a556f4cbd15fc289039261661b049a5dc845cd80" }
+stylo_atoms = { git = "https://github.com/servo/stylo", rev = "a556f4cbd15fc289039261661b049a5dc845cd80" }
+stylo_dom = { git = "https://github.com/servo/stylo", rev = "a556f4cbd15fc289039261661b049a5dc845cd80" }
+stylo_malloc_size_of = { git = "https://github.com/servo/stylo", rev = "a556f4cbd15fc289039261661b049a5dc845cd80" }
+stylo_static_prefs = { git = "https://github.com/servo/stylo", rev = "a556f4cbd15fc289039261661b049a5dc845cd80" }
+stylo_traits = { git = "https://github.com/servo/stylo", rev = "a556f4cbd15fc289039261661b049a5dc845cd80" }
+surfman = { version = "0.12.0", features = ["chains"] }
 syn = { version = "2", default-features = false, features = ["clone-impls", "derive", "parsing"] }
 synstructure = "0.13"
-taffy = { version = "0.9.2", default-features = false, features = ["calc", "detailed_layout_info", "grid", "std"] }
+taffy = { version = "0.10.1", default-features = false, features = ["calc", "detailed_layout_info", "grid", "std"] }
 tendril = { version = "0.5", features = ["encoding_rs"] }
 tikv-jemalloc-sys = "0.6.1"
 tikv-jemallocator = "0.6.1"
@@ -210,35 +201,109 @@ tokio-util = { version = "0.7.18", default-features = false }
 tower = { version = "0.5", default-features = false, features = ["util"] }
 tracing = "0.1.44"
 tracing-perfetto = "0.1.5"
-tracing-subscriber = "0.3.22"
-tungstenite = "0.28"
+tracing-subscriber = "0.3.23"
+tungstenite = "0.29"
 unicode-bidi = "0.3.18"
+unicode_categories = "0.1.1"
 unicode-properties = { version = "0.1.4", features = ["emoji"] }
 unicode-script = "0.5"
-unicode-segmentation = "1.12.0"
+unicode-segmentation = "1.13.2"
 url = "2.5"
 urlpattern = "0.3"
 utf-8 = "0.7"
-uuid = { version = "1.21.0", features = ["v4", "v5"] }
+uuid = { version = "1.23.1", features = ["v4", "v5"] }
 vello = "0.6"
 vello_cpu = "0.0.4"
-webdriver = "0.53.0"
-webgpu_traits = { package = "servo-webgpu-traits", path = "components/shared/webgpu" }
+webdriver = { version = "0.53.0", default-features = false }
 webpki-roots = "1.0"
 webrender = { version = "0.68", features = ["capture"] }
 webrender_api = "0.68"
-webxr-api = { package = "servo-webxr-api", path = "components/shared/webxr" }
+web_atoms = "0.2"
 wgpu-core = "26"
 wgpu-types = "26"
 winapi = "0.3"
 windows-sys = "0.61"
-winit = "0.30.12"
+winit = "0.30.13"
 wio = "0.2"
 wr_malloc_size_of = "0.2.2"
 x25519-dalek = { version = "2.0.1", features = ["static_secrets"] }
-xi-unicode = "0.3.0"
-xml5ever = "0.38"
-xpath = { package = "servo-xpath", path = "components/xpath" }
+xml5ever = "0.39"
+yuv = { version = "0.8.13", features = ["rayon"] }
+
+############################################################################################
+## Workspace-local dependencies
+############################################################################################
+# All local path dependencies in the servo workspace, that use the workspace version, should
+# be listed here, between the `Begin` and `End` comments, so that we can easily find and
+# update the version requirements when bumping the workspace version.
+# Begin workspace-version dependencies - Don't change this comment, we grep for it in scripts!
+deny_public_fields = { package = "servo-deny-public-fields", version = "0.1.0", path = "components/deny_public_fields" }
+devtools = { package = "servo-devtools", version = "0.1.0", path = "components/devtools" }
+devtools_traits = { package = "servo-devtools-traits", version = "0.1.0", path = "components/shared/devtools" }
+dom_struct = { package = "servo-dom-struct", version = "0.1.0", path = "components/dom_struct" }
+embedder_traits = { package = "servo-embedder-traits", version = "0.1.0", path = "components/shared/embedder" }
+fonts = { package = "servo-fonts", version = "0.1.0", path = "components/fonts" }
+fonts_traits = { package = "servo-fonts-traits", version = "0.1.0", path = "components/shared/fonts" }
+hyper_serde = { package = "servo-hyper-serde", version = "0.1.0", path = "components/hyper_serde" }
+jstraceable_derive = { package = "servo-jstraceable-derive", version = "0.1.0", path = "components/jstraceable_derive" }
+layout = { package = "servo-layout", version = "0.1.0", path = "components/layout" }
+layout_api = { package = "servo-layout-api", version = "0.1.0", path = "components/shared/layout" }
+malloc_size_of = { package = "servo-malloc-size-of", version = "0.1.0", path = "components/malloc_size_of" }
+media = { package = "servo-media-thread", version = "0.1.0", path = "components/media/media-thread" }
+metrics = { package = "servo-metrics", version = "0.1.0", path = "components/metrics" }
+net = { package = "servo-net", version = "0.1.0", path = "components/net" }
+net_traits = { package = "servo-net-traits", version = "0.1.0", path = "components/shared/net" }
+paint = { package = "servo-paint", version = "0.1.0", path = "components/paint" }
+paint_api = { package = "servo-paint-api", version = "0.1.0", path = "components/shared/paint" }
+pixels = { package = "servo-pixels", version = "0.1.0", path = "components/pixels" }
+profile = { package = "servo-profile", version = "0.1.0", path = "components/profile" }
+profile_traits = { package = "servo-profile-traits", version = "0.1.0", path = "components/shared/profile" }
+script = { package = "servo-script", version = "0.1.0", path = "components/script" }
+script_bindings = { package = "servo-script-bindings", version = "0.1.0", path = "components/script_bindings" }
+script_traits = { package = "servo-script-traits", version = "0.1.0", path = "components/shared/script" }
+servo = { version = "0.1.0", path = "components/servo", default-features = false }
+servo-allocator = { version = "0.1.0", path = "components/allocator" }
+servo-background-hang-monitor = { version = "0.1.0", path = "components/background_hang_monitor" }
+servo-background-hang-monitor-api = { version = "0.1.0", path = "components/shared/background_hang_monitor" }
+servo-base = { version = "0.1.0", path = "components/shared/base" }
+servo-bluetooth = { version = "0.1.0", path = "components/bluetooth" }
+servo-bluetooth-traits = { version = "0.1.0", path = "components/shared/bluetooth" }
+servo-canvas = { version = "0.1.0", path = "components/canvas" }
+servo-canvas-traits = { version = "0.1.0", path = "components/shared/canvas" }
+servo-config = { version = "0.1.0", path = "components/config" }
+servo-config-macro = { version = "0.1.0", path = "components/config/macro" }
+servo-constellation = { version = "0.1.0", path = "components/constellation" }
+servo-constellation-traits = { version = "0.1.0", path = "components/shared/constellation" }
+servo-default-resources = { version = "0.1.0", path = "components/default-resources" }
+servo-geometry = { version = "0.1.0", path = "components/geometry" }
+servo-media = { version = "0.1.0", path = "components/media/servo-media" }
+servo-media-audio = { version = "0.1.0", path = "components/media/audio" }
+servo-media-auto = { version = "0.1.0", path = "components/media/backends/auto" }
+servo-media-derive = { version = "0.1.0", path = "components/media/servo-media-derive" }
+servo-media-dummy = { version = "0.1.0", path = "components/media/backends/dummy" }
+servo-media-gstreamer = { version = "0.1.0", path = "components/media/backends/gstreamer" }
+servo-media-gstreamer-render = { version = "0.1.0", path = "components/media/backends/gstreamer/render" }
+servo-media-gstreamer-render-android = { version = "0.1.0", path = "components/media/backends/gstreamer/render-android" }
+servo-media-gstreamer-render-unix = { version = "0.1.0", path = "components/media/backends/gstreamer/render-unix" }
+servo-media-ohos = { version = "0.1.0", path = "components/media/backends/ohos" }
+servo-media-player = { version = "0.1.0", path = "components/media/player" }
+servo-media-streams = { version = "0.1.0", path = "components/media/streams" }
+servo-media-traits = { version = "0.1.0", path = "components/media/traits" }
+servo-media-webrtc = { version = "0.1.0", path = "components/media/webrtc" }
+servo-tracing = { version = "0.1.0", path = "components/servo_tracing" }
+servo-url = { version = "0.1.0", path = "components/url" }
+servo-wakelock = { version = "0.1.0", path = "components/wakelock" }
+storage = { package = "servo-storage", version = "0.1.0", path = "components/storage" }
+storage_traits = { package = "servo-storage-traits", version = "0.1.0", path = "components/shared/storage" }
+timers = { package = "servo-timers", version = "0.1.0", path = "components/timers" }
+webdriver_server = { package = "servo-webdriver-server", version = "0.1.0", path = "components/webdriver_server" }
+webgl = { package = "servo-webgl", version = "0.1.0", path = "components/webgl", default-features = false }
+webgpu = { package = "servo-webgpu", version = "0.1.0", path = "components/webgpu" }
+webgpu_traits = { package = "servo-webgpu-traits", version = "0.1.0", path = "components/shared/webgpu" }
+webxr = { package = "servo-webxr", version = "0.1.0", path = "components/webxr" }
+webxr-api = { package = "servo-webxr-api", version = "0.1.0", path = "components/shared/webxr" }
+xpath = { package = "servo-xpath", version = "0.1.0", path = "components/xpath" }
+# End workspace-version dependencies - Don't change this comment, we grep for it in scripts!
 
 # RSA key generation could be very slow without compilation
 # optimizations, in development mode. Without optimizations, WPT might
@@ -306,16 +371,19 @@ codegen-units = 1
 # xml5ever = { path = "../html5ever/xml5ever" }
 # tendril = { path = "../html5ever/tendril" }
 #
+# For WebRender:
+#
+# webrender = { path = "../webrender/webrender" }
+# webrender_api = { path = "../webrender/webrender_api" }
+# wr_malloc_size_of = { path = "../webrender/wr_malloc_size_of" }
+#
 # Or for mozjs:
 #
 # mozjs = { path = "../mozjs/mozjs" }
 # mozjs_sys = { path = "../mozjs/mozjs-sys" }
 #
-# Pending egui bumping their accesskit version: https://github.com/emilk/egui/pull/7850
-# This is only used in servoshell.
-# TODO: When these are no longer needed remove the exception in deny.toml as well.
-egui = { git = "https://github.com/emilk/egui.git", rev = "5d8f393335e051785b4fd3af9ef92eda5b61177f" }
-egui-winit = { git = "https://github.com/emilk/egui.git", rev = "5d8f393335e051785b4fd3af9ef92eda5b61177f" }
+# Or for CSP crate:
+# content-security-policy = { path = "../rust-content-security-policy" }
 #
 # Or for Stylo:
 #
@@ -329,17 +397,8 @@ egui-winit = { git = "https://github.com/emilk/egui.git", rev = "5d8f393335e0517
 # stylo_static_prefs = { path = "../stylo/stylo_static_prefs" }
 # stylo_traits = { path = "../stylo/style_traits" }
 #
-# Or for WebRender:
-#
-# [patch."https://github.com/servo/webrender"]
-# webrender = { path = "../webrender/webrender" }
-# webrender_api = { path = "../webrender/webrender_api" }
-# wr_malloc_size_of = { path = "../webrender/wr_malloc_size_of" }
-#
 # Or for another Git dependency:
 #
 # [patch."https://github.com/servo/<repository>"]
 # <crate> = { path = "/path/to/local/checkout" }
 #
-# [patch."https://github.com/servo/rust-content-security-policy"]
-# content-security-policy = { path = "../rust-content-security-policy" }

Info.plist

@@ -1,32 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-<dict>
-	<key>CFBundleExecutable</key>
-	<string>servo</string>
-	<key>CFBundleGetInfoString</key>
-	<string>Servo</string>
-	<key>CFBundleIconFile</key>
-	<string>servo.icns</string>
-	<key>CFBundleIdentifier</key>
-	<string>org.servo.Servo</string>
-	<key>CFBundleInfoDictionaryVersion</key>
-	<string>6.0</string>
-	<key>CFBundleName</key>
-	<string>Servo</string>
-	<key>CFBundlePackageType</key>
-	<string>APPL</string>
-	<key>CFBundleShortVersionString</key>
-	<string>0.0.6</string>
-	<key>NSHighResolutionCapable</key>
-	<true/>
-	<key>NSPrincipalClass</key>
-	<string>NSApplication</string>
-	<key>NSQuitAlwaysKeepsWindows</key>
-	<false/>
-	<key>CFBundleSupportedPlatforms</key>
-    <array>
-        <string>MacOSX</string>
-    </array>
-</dict>
-</plist>

PULL_REQUEST_TEMPLATE.md

@@ -1,4 +1,5 @@
-*Describe the changes that this pull request makes here. This will be the commit message.*
+*Describe the changes that this pull request makes here. This will be the commit message
+and it should go at the top of the pull request.*
 
-Testing: *Describe how this pull request is tested or why it doesn't require tests*
-Fixes: *Link to an issue this pull requests fixes or remove this line if there is no issue*
+Testing: *Describe the new automated tests that cover this change or explain why it doesn't require tests.*
+Fixes: *Link to an issue this pull request fixes or remove this line if there is no issue.*

SECURITY.md

@@ -1,4 +1,3 @@
 # Security Policy
 
-Given that Servo does not yet have customers or products, we are comfortable accepting the security related issues as [GitHub security reports](https://github.com/servo/servo/security/advisories/new) for now.
-
+Please submit security related issues as [GitHub security reports](https://github.com/servo/servo/security/advisories/new).

components/allocator/Cargo.toml

@@ -6,6 +6,8 @@ license.workspace = true
 edition.workspace = true
 publish.workspace = true
 rust-version.workspace = true
+repository.workspace = true
+description.workspace = true
 
 [lib]
 path = "lib.rs"

components/background_hang_monitor/Cargo.toml

@@ -6,23 +6,25 @@ license.workspace = true
 edition.workspace = true
 publish.workspace = true
 rust-version.workspace = true
+repository.workspace = true
+description.workspace = true
 
 [lib]
-name = "background_hang_monitor"
+name = "servo_background_hang_monitor"
 path = "lib.rs"
 test = false
 doctest = false
 
 [dependencies]
-background_hang_monitor_api = { workspace = true }
 backtrace = { workspace = true }
-base = { workspace = true }
 crossbeam-channel = { workspace = true }
 libc = { workspace = true }
 log = { workspace = true }
 rustc-demangle = { version = "0.1", optional = true }
 rustc-hash = { workspace = true }
 serde_json = { workspace = true }
+servo-background-hang-monitor-api = { workspace = true }
+servo-base = { workspace = true }
 
 [target.'cfg(target_os = "macos")'.dependencies]
 mach2 = { workspace = true, optional = true }

components/background_hang_monitor/background_hang_monitor.rs

@@ -11,10 +11,10 @@ use background_hang_monitor_api::{
     BackgroundHangMonitorExitSignal, BackgroundHangMonitorRegister, HangAlert, HangAnnotation,
     HangMonitorAlert, MonitoredComponentId,
 };
-use base::generic_channel::{GenericReceiver, GenericSender, RoutedReceiver};
 use crossbeam_channel::{Receiver, Sender, after, never, select, unbounded};
 use log::{error, warn};
 use rustc_hash::FxHashMap;
+use servo_base::generic_channel::{GenericReceiver, GenericSender, RoutedReceiver};
 
 use crate::SamplerImpl;
 use crate::sampler::{NativeStack, Sampler};

components/background_hang_monitor/lib.rs

@@ -37,6 +37,7 @@ pub use self::background_hang_monitor::*;
         )
     ),
     all(target_os = "windows", target_arch = "aarch64"),
+    target_os = "freebsd"
 ))]
 pub(crate) use crate::sampler::DummySampler as SamplerImpl;
 #[cfg(all(

components/background_hang_monitor/tests/hang_monitor_tests.rs

@@ -9,13 +9,13 @@ use std::sync::{Arc, Mutex};
 use std::thread;
 use std::time::Duration;
 
-use background_hang_monitor::HangMonitorRegister;
 use background_hang_monitor_api::{
     BackgroundHangMonitorControlMsg, BackgroundHangMonitorExitSignal, HangAlert, HangAnnotation,
     HangMonitorAlert, MonitoredComponentId, MonitoredComponentType, ScriptHangAnnotation,
 };
-use base::generic_channel;
-use base::id::TEST_SCRIPT_EVENT_LOOP_ID;
+use servo_background_hang_monitor::HangMonitorRegister;
+use servo_base::generic_channel;
+use servo_base::id::TEST_SCRIPT_EVENT_LOOP_ID;
 
 static SERIAL: Mutex<()> = Mutex::new(());
 

components/bluetooth/Cargo.toml

@@ -6,32 +6,28 @@ license.workspace = true
 edition.workspace = true
 publish.workspace = true
 rust-version.workspace = true
+repository.workspace = true
+description.workspace = true
 
 [lib]
-name = "bluetooth"
+name = "servo_bluetooth"
 path = "lib.rs"
 
 [dependencies]
-base = { workspace = true }
 bitflags = { workspace = true }
-bluetooth_traits = { workspace = true }
 blurmock = { version = "0.1.2", optional = true }
+btleplug = { version = "0.12", optional = true }
 embedder_traits = { workspace = true }
+futures = { workspace = true, features = ["executor"] }
 log = { workspace = true }
 rand = { workspace = true }
-servo_config = { package = "servo-config", path = "../config" }
+servo-base = { workspace = true }
+servo-bluetooth-traits = { workspace = true }
+servo-config = { workspace = true }
+tokio = { workspace = true, features = ["rt", "time", "sync"], optional = true }
 uuid = { workspace = true }
 
-[target.'cfg(target_os = "linux")'.dependencies]
-blurz = { version = "0.3", optional = true }
-
-[target.'cfg(target_os = "android")'.dependencies]
-blurdroid = { version = "0.1.2", optional = true }
-
-[target.'cfg(target_os = "macos")'.dependencies]
-blurmac = { path = "../../third_party/blurmac", optional = true }
-
 [features]
 default = ["bluetooth-test"]
 bluetooth-test = ["blurmock"]
-native-bluetooth = ["bluetooth-test", "blurdroid", "blurmac", "blurz"]
+native-bluetooth = ["bluetooth-test", "btleplug", "tokio"]

components/bluetooth/adapter.rs

@@ -5,99 +5,81 @@
 use std::error::Error;
 use std::sync::Arc;
 
-#[cfg(all(target_os = "android", feature = "native-bluetooth"))]
-use blurdroid::bluetooth_adapter::Adapter as BluetoothAdapterAndroid;
-#[cfg(all(target_os = "android", feature = "native-bluetooth"))]
-use blurdroid::bluetooth_device::Device as BluetoothDeviceAndroid;
-#[cfg(all(target_os = "android", feature = "native-bluetooth"))]
-use blurdroid::bluetooth_discovery_session::DiscoverySession as BluetoothDiscoverySessionAndroid;
-#[cfg(all(target_os = "macos", feature = "native-bluetooth"))]
-use blurmac::BluetoothAdapter as BluetoothAdapterMac;
-#[cfg(all(target_os = "macos", feature = "native-bluetooth"))]
-use blurmac::BluetoothDevice as BluetoothDeviceMac;
-#[cfg(all(target_os = "macos", feature = "native-bluetooth"))]
-use blurmac::BluetoothDiscoverySession as BluetoothDiscoverySessionMac;
 #[cfg(feature = "bluetooth-test")]
 use blurmock::fake_adapter::FakeBluetoothAdapter;
 #[cfg(feature = "bluetooth-test")]
 use blurmock::fake_device::FakeBluetoothDevice;
 #[cfg(feature = "bluetooth-test")]
 use blurmock::fake_discovery_session::FakeBluetoothDiscoverySession;
-#[cfg(all(target_os = "linux", feature = "native-bluetooth"))]
-use blurz::bluetooth_adapter::BluetoothAdapter as BluetoothAdapterBluez;
-#[cfg(all(target_os = "linux", feature = "native-bluetooth"))]
-use blurz::bluetooth_device::BluetoothDevice as BluetoothDeviceBluez;
-#[cfg(all(target_os = "linux", feature = "native-bluetooth"))]
-use blurz::bluetooth_discovery_session::BluetoothDiscoverySession as BluetoothDiscoverySessionBluez;
+#[cfg(feature = "native-bluetooth")]
+use btleplug::api::{Central, CentralState, Manager};
+#[cfg(feature = "native-bluetooth")]
+use btleplug::platform::{Adapter, Manager as PlatformManager};
 
 use super::bluetooth::{BluetoothDevice, BluetoothDiscoverySession};
-#[cfg(not(any(
-    all(target_os = "linux", feature = "native-bluetooth"),
-    all(target_os = "android", feature = "native-bluetooth"),
-    all(target_os = "macos", feature = "native-bluetooth")
-)))]
-use super::empty::BluetoothDevice as BluetoothDeviceEmpty;
-#[cfg(not(any(
-    all(target_os = "linux", feature = "native-bluetooth"),
-    all(target_os = "android", feature = "native-bluetooth"),
-    all(target_os = "macos", feature = "native-bluetooth")
-)))]
-use super::empty::BluetoothDiscoverySession as BluetoothDiscoverySessionEmpty;
-#[cfg(not(any(
-    all(target_os = "linux", feature = "native-bluetooth"),
-    all(target_os = "android", feature = "native-bluetooth"),
-    all(target_os = "macos", feature = "native-bluetooth")
-)))]
-use super::empty::EmptyAdapter as BluetoothAdapterEmpty;
-use super::macros::get_inner_and_call;
-#[cfg(feature = "bluetooth-test")]
-use super::macros::get_inner_and_call_test_func;
+use crate::macros::get_inner_and_call_test_func;
+
+#[cfg(feature = "native-bluetooth")]
+#[derive(Clone, Debug)]
+pub struct BtleplugAdapter {
+    adapter: Adapter,
+}
+
+#[cfg(feature = "native-bluetooth")]
+impl BtleplugAdapter {
+    pub async fn new() -> Result<Self, Box<dyn Error>> {
+        let manager = PlatformManager::new().await?;
+        let adapters = manager.adapters().await?;
+        let adapter = adapters
+            .into_iter()
+            .next()
+            .ok_or_else(|| btleplug::Error::NoAdapterAvailable)?;
+        Ok(BtleplugAdapter { adapter })
+    }
+
+    pub async fn get_address(&self) -> Result<String, Box<dyn Error>> {
+        Ok(self.adapter.adapter_info().await?)
+    }
+
+    pub async fn is_powered(&self) -> Result<bool, Box<dyn Error>> {
+        let state = self.adapter.adapter_state().await?;
+        Ok(state == CentralState::PoweredOn)
+    }
+
+    pub async fn get_devices(&self) -> Result<Vec<BluetoothDevice>, Box<dyn Error>> {
+        let peripherals = self.adapter.peripherals().await?;
+        Ok(peripherals
+            .into_iter()
+            .map(|p| BluetoothDevice::Btleplug(super::bluetooth::BtleplugDevice { peripheral: p }))
+            .collect())
+    }
+
+    pub fn create_discovery_session(&self) -> Result<BluetoothDiscoverySession, Box<dyn Error>> {
+        Ok(BluetoothDiscoverySession::Btleplug(
+            super::bluetooth::BtleplugDiscoverySession {
+                adapter: self.adapter.clone(),
+            },
+        ))
+    }
+}
 
 #[derive(Clone, Debug)]
 pub enum BluetoothAdapter {
-    #[cfg(all(target_os = "linux", feature = "native-bluetooth"))]
-    Bluez(Arc<BluetoothAdapterBluez>),
-    #[cfg(all(target_os = "android", feature = "native-bluetooth"))]
-    Android(Arc<BluetoothAdapterAndroid>),
-    #[cfg(all(target_os = "macos", feature = "native-bluetooth"))]
-    Mac(Arc<BluetoothAdapterMac>),
-    #[cfg(not(any(
-        all(target_os = "linux", feature = "native-bluetooth"),
-        all(target_os = "android", feature = "native-bluetooth"),
-        all(target_os = "macos", feature = "native-bluetooth")
-    )))]
-    Empty(Arc<BluetoothAdapterEmpty>),
+    #[cfg(feature = "native-bluetooth")]
+    Btleplug(BtleplugAdapter),
     #[cfg(feature = "bluetooth-test")]
     Mock(Arc<FakeBluetoothAdapter>),
 }
 
 impl BluetoothAdapter {
-    #[cfg(all(target_os = "linux", feature = "native-bluetooth"))]
-    pub fn new() -> Result<BluetoothAdapter, Box<dyn Error>> {
-        let bluez_adapter = BluetoothAdapterBluez::init()?;
-        Ok(Self::Bluez(Arc::new(bluez_adapter)))
+    #[cfg(feature = "native-bluetooth")]
+    pub async fn new() -> Result<BluetoothAdapter, Box<dyn Error>> {
+        Ok(Self::Btleplug(BtleplugAdapter::new().await?))
     }
 
-    #[cfg(all(target_os = "android", feature = "native-bluetooth"))]
+    #[cfg(not(feature = "native-bluetooth"))]
     pub fn new() -> Result<BluetoothAdapter, Box<dyn Error>> {
-        let blurdroid_adapter = BluetoothAdapterAndroid::get_adapter()?;
-        Ok(Self::Android(Arc::new(blurdroid_adapter)))
-    }
-
-    #[cfg(all(target_os = "macos", feature = "native-bluetooth"))]
-    pub fn new() -> Result<BluetoothAdapter, Box<dyn Error>> {
-        let mac_adapter = BluetoothAdapterMac::init()?;
-        Ok(Self::Mac(Arc::new(mac_adapter)))
-    }
-
-    #[cfg(not(any(
-        all(target_os = "linux", feature = "native-bluetooth"),
-        all(target_os = "android", feature = "native-bluetooth"),
-        all(target_os = "macos", feature = "native-bluetooth")
-    )))]
-    pub fn new() -> Result<BluetoothAdapter, Box<dyn Error>> {
-        let adapter = BluetoothAdapterEmpty::init()?;
-        Ok(Self::Empty(Arc::new(adapter)))
+        Err(Box::from("Bluetooth not supported on this platform"))
     }
 
     #[cfg(feature = "bluetooth-test")]
@@ -105,62 +87,30 @@ impl BluetoothAdapter {
         Ok(Self::Mock(FakeBluetoothAdapter::new_empty()))
     }
 
-    pub fn get_id(&self) -> String {
-        get_inner_and_call!(self, BluetoothAdapter, get_id)
+    pub async fn get_address(&self) -> Result<String, Box<dyn Error>> {
+        match self {
+            #[cfg(feature = "native-bluetooth")]
+            Self::Btleplug(inner) => inner.get_address().await,
+            #[cfg(feature = "bluetooth-test")]
+            Self::Mock(inner) => inner.get_address(),
+        }
     }
 
-    pub fn get_devices(&self) -> Result<Vec<BluetoothDevice>, Box<dyn Error>> {
+    pub async fn is_powered(&self) -> Result<bool, Box<dyn Error>> {
         match self {
-            #[cfg(all(target_os = "linux", feature = "native-bluetooth"))]
-            BluetoothAdapter::Bluez(inner) => {
-                let device_list = inner.get_device_list()?;
-                Ok(device_list
-                    .into_iter()
-                    .map(|device| BluetoothDevice::Bluez(BluetoothDeviceBluez::new(device).into()))
-                    .collect())
-            },
-            #[cfg(all(target_os = "android", feature = "native-bluetooth"))]
-            BluetoothAdapter::Android(inner) => {
-                let device_list = inner.get_device_list()?;
-                Ok(device_list
-                    .into_iter()
-                    .map(|device| {
-                        BluetoothDevice::Android(BluetoothDeviceAndroid::new_empty(
-                            self.0.clone(),
-                            device,
-                        ))
-                    })
-                    .collect())
-            },
-            #[cfg(all(target_os = "macos", feature = "native-bluetooth"))]
-            BluetoothAdapter::Mac(inner) => {
-                let device_list = inner.get_device_list()?;
-                Ok(device_list
-                    .into_iter()
-                    .map(|device| {
-                        BluetoothDevice::Mac(Arc::new(BluetoothDeviceMac::new(
-                            inner.clone(),
-                            device,
-                        )))
-                    })
-                    .collect())
-            },
-            #[cfg(not(any(
-                all(target_os = "linux", feature = "native-bluetooth"),
-                all(target_os = "android", feature = "native-bluetooth"),
-                all(target_os = "macos", feature = "native-bluetooth")
-            )))]
-            BluetoothAdapter::Empty(inner) => {
-                let device_list = inner.get_device_list()?;
-                Ok(device_list
-                    .into_iter()
-                    .map(|device| {
-                        BluetoothDevice::Empty(Arc::new(BluetoothDeviceEmpty::new(device)))
-                    })
-                    .collect())
-            },
+            #[cfg(feature = "native-bluetooth")]
+            Self::Btleplug(inner) => inner.is_powered().await,
             #[cfg(feature = "bluetooth-test")]
-            BluetoothAdapter::Mock(inner) => {
+            Self::Mock(inner) => inner.is_powered(),
+        }
+    }
+
+    pub async fn get_devices(&self) -> Result<Vec<BluetoothDevice>, Box<dyn Error>> {
+        match self {
+            #[cfg(feature = "native-bluetooth")]
+            Self::Btleplug(inner) => inner.get_devices().await,
+            #[cfg(feature = "bluetooth-test")]
+            Self::Mock(inner) => {
                 let device_list = inner.get_device_list()?;
                 Ok(device_list
                     .into_iter()
@@ -172,157 +122,34 @@ impl BluetoothAdapter {
         }
     }
 
-    pub fn get_device(&self, address: String) -> Result<Option<BluetoothDevice>, Box<dyn Error>> {
-        let devices = self.get_devices()?;
-        for device in devices {
-            if device.get_address()? == address {
-                return Ok(Some(device));
-            }
+    pub fn create_discovery_session(&self) -> Result<BluetoothDiscoverySession, Box<dyn Error>> {
+        match self {
+            #[cfg(feature = "native-bluetooth")]
+            Self::Btleplug(inner) => inner.create_discovery_session(),
+            #[cfg(feature = "bluetooth-test")]
+            Self::Mock(inner) => Ok(BluetoothDiscoverySession::Mock(Arc::new(
+                FakeBluetoothDiscoverySession::create_session(inner.clone())?,
+            ))),
         }
-        Ok(None)
     }
 
     pub fn create_mock_device(&self, _device: String) -> Result<BluetoothDevice, Box<dyn Error>> {
         match self {
             #[cfg(feature = "bluetooth-test")]
-            BluetoothAdapter::Mock(inner) => Ok(BluetoothDevice::Mock(
-                FakeBluetoothDevice::new_empty(inner.clone(), _device),
-            )),
-            _ => Err(Box::from(
-                "Error! Test functions are not supported on real devices!",
-            )),
+            Self::Mock(inner) => Ok(BluetoothDevice::Mock(FakeBluetoothDevice::new_empty(
+                inner.clone(),
+                _device,
+            ))),
+            #[cfg(feature = "native-bluetooth")]
+            _ => Err(Box::from("Test functions not supported on real devices")),
         }
     }
 
-    pub fn create_discovery_session(&self) -> Result<BluetoothDiscoverySession, Box<dyn Error>> {
-        let discovery_session = match self {
-            #[cfg(all(target_os = "linux", feature = "native-bluetooth"))]
-            #[allow(clippy::arc_with_non_send_sync)] // Problem with underlying library
-            BluetoothAdapter::Bluez(inner) => BluetoothDiscoverySession::Bluez(Arc::new(
-                BluetoothDiscoverySessionBluez::create_session(inner.get_id())?,
-            )),
-            #[cfg(all(target_os = "android", feature = "native-bluetooth"))]
-            BluetoothAdapter::Android(inner) => BluetoothDiscoverySession::Android(Arc::new(
-                BluetoothDiscoverySessionAndroid::create_session(inner.clone())?,
-            )),
-            #[cfg(all(target_os = "macos", feature = "native-bluetooth"))]
-            BluetoothAdapter::Mac(_) => {
-                BluetoothDiscoverySession::Mac(Arc::new(BluetoothDiscoverySessionMac {}))
-            },
-            #[cfg(not(any(
-                all(target_os = "linux", feature = "native-bluetooth"),
-                all(target_os = "android", feature = "native-bluetooth"),
-                all(target_os = "macos", feature = "native-bluetooth")
-            )))]
-            BluetoothAdapter::Empty(_) => {
-                BluetoothDiscoverySession::Empty(Arc::new(BluetoothDiscoverySessionEmpty {}))
-            },
-            #[cfg(feature = "bluetooth-test")]
-            BluetoothAdapter::Mock(inner) => BluetoothDiscoverySession::Mock(Arc::new(
-                FakeBluetoothDiscoverySession::create_session(inner.clone())?,
-            )),
-        };
-        Ok(discovery_session)
-    }
-
-    pub fn get_address(&self) -> Result<String, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, get_address)
-    }
-
-    pub fn get_name(&self) -> Result<String, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, get_name)
-    }
-
-    pub fn get_alias(&self) -> Result<String, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, get_alias)
-    }
-
-    pub fn get_class(&self) -> Result<u32, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, get_class)
-    }
-
-    pub fn is_powered(&self) -> Result<bool, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, is_powered)
-    }
-
-    pub fn is_discoverable(&self) -> Result<bool, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, is_discoverable)
-    }
-
-    pub fn is_pairable(&self) -> Result<bool, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, is_pairable)
-    }
-
-    pub fn get_pairable_timeout(&self) -> Result<u32, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, get_pairable_timeout)
-    }
-
-    pub fn get_discoverable_timeout(&self) -> Result<u32, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, get_discoverable_timeout)
-    }
-
-    pub fn is_discovering(&self) -> Result<bool, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, is_discovering)
-    }
-
-    pub fn get_uuids(&self) -> Result<Vec<String>, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, get_uuids)
-    }
-
-    pub fn get_vendor_id_source(&self) -> Result<String, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, get_vendor_id_source)
-    }
-
-    pub fn get_vendor_id(&self) -> Result<u32, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, get_vendor_id)
-    }
-
-    pub fn get_product_id(&self) -> Result<u32, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, get_product_id)
-    }
-
-    pub fn get_device_id(&self) -> Result<u32, Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, get_device_id)
-    }
-
-    pub fn get_modalias(&self) -> Result<(String, u32, u32, u32), Box<dyn Error>> {
-        get_inner_and_call!(self, BluetoothAdapter, get_modalias)
-    }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_id(&self, id: String) -> Result<(), Box<dyn Error>> {
-        match self {
-            #[cfg(feature = "bluetooth-test")]
-            BluetoothAdapter::Mock(inner) => {
-                inner.set_id(id);
-                Ok(())
-            },
-            _ => Err(Box::from(
-                "Error! Test functions are not supported on real devices!",
-            )),
-        }
-    }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_address(&self, address: String) -> Result<(), Box<dyn Error>> {
-        get_inner_and_call_test_func!(self, BluetoothAdapter, set_address, address)
-    }
-
     #[cfg(feature = "bluetooth-test")]
     pub fn set_name(&self, name: String) -> Result<(), Box<dyn Error>> {
         get_inner_and_call_test_func!(self, BluetoothAdapter, set_name, name)
     }
 
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_alias(&self, alias: String) -> Result<(), Box<dyn Error>> {
-        get_inner_and_call_test_func!(self, BluetoothAdapter, set_alias, alias)
-    }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_class(&self, class: u32) -> Result<(), Box<dyn Error>> {
-        get_inner_and_call_test_func!(self, BluetoothAdapter, set_class, class)
-    }
-
     #[cfg(feature = "bluetooth-test")]
     pub fn set_powered(&self, powered: bool) -> Result<(), Box<dyn Error>> {
         get_inner_and_call_test_func!(self, BluetoothAdapter, set_powered, powered)
@@ -342,64 +169,4 @@ impl BluetoothAdapter {
     pub fn set_discoverable(&self, discoverable: bool) -> Result<(), Box<dyn Error>> {
         get_inner_and_call_test_func!(self, BluetoothAdapter, set_discoverable, discoverable)
     }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_pairable(&self, pairable: bool) -> Result<(), Box<dyn Error>> {
-        get_inner_and_call_test_func!(self, BluetoothAdapter, set_pairable, pairable)
-    }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_pairable_timeout(&self, timeout: u32) -> Result<(), Box<dyn Error>> {
-        get_inner_and_call_test_func!(self, BluetoothAdapter, set_pairable_timeout, timeout)
-    }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_can_start_discovery(&self, can_start_discovery: bool) -> Result<(), Box<dyn Error>> {
-        get_inner_and_call_test_func!(
-            self,
-            BluetoothAdapter,
-            set_can_start_discovery,
-            can_start_discovery
-        )
-    }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_discoverable_timeout(&self, timeout: u32) -> Result<(), Box<dyn Error>> {
-        get_inner_and_call_test_func!(self, BluetoothAdapter, set_discoverable_timeout, timeout)
-    }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_discovering(&self, discovering: bool) -> Result<(), Box<dyn Error>> {
-        get_inner_and_call_test_func!(self, BluetoothAdapter, set_discovering, discovering)
-    }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_can_stop_discovery(&self, can_stop_discovery: bool) -> Result<(), Box<dyn Error>> {
-        get_inner_and_call_test_func!(
-            self,
-            BluetoothAdapter,
-            set_can_stop_discovery,
-            can_stop_discovery
-        )
-    }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_uuids(&self, uuids: Vec<String>) -> Result<(), Box<dyn Error>> {
-        get_inner_and_call_test_func!(self, BluetoothAdapter, set_uuids, uuids)
-    }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_modalias(&self, modalias: String) -> Result<(), Box<dyn Error>> {
-        get_inner_and_call_test_func!(self, BluetoothAdapter, set_modalias, modalias)
-    }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn get_ad_datas(&self) -> Result<Vec<String>, Box<dyn Error>> {
-        get_inner_and_call_test_func!(self, BluetoothAdapter, get_ad_datas)
-    }
-
-    #[cfg(feature = "bluetooth-test")]
-    pub fn set_ad_datas(&self, ad_datas: Vec<String>) -> Result<(), Box<dyn Error>> {
-        get_inner_and_call_test_func!(self, BluetoothAdapter, set_ad_datas, ad_datas)
-    }
 }

components/bluetooth/empty.rs

@@ -1,377 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-use std::collections::HashMap;
-use std::error::Error;
-use std::sync::Arc;
-
-const NOT_SUPPORTED_ERROR: &str = "Error! Not supported platform!";
-
-#[derive(Clone, Debug)]
-pub struct EmptyAdapter {}
-
-impl EmptyAdapter {
-    pub fn init() -> Result<EmptyAdapter, Box<dyn Error>> {
-        Ok(EmptyAdapter::new())
-    }
-
-    fn new() -> EmptyAdapter {
-        EmptyAdapter {}
-    }
-
-    pub fn get_id(&self) -> String {
-        String::new()
-    }
-
-    pub fn get_device_list(&self) -> Result<Vec<String>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_address(&self) -> Result<String, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_name(&self) -> Result<String, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_alias(&self) -> Result<String, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn set_alias(&self, _value: String) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_class(&self) -> Result<u32, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn is_powered(&self) -> Result<bool, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn set_powered(&self, _value: bool) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn is_discoverable(&self) -> Result<bool, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn set_discoverable(&self, _value: bool) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn is_pairable(&self) -> Result<bool, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn set_pairable(&self, _value: bool) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_pairable_timeout(&self) -> Result<u32, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn set_pairable_timeout(&self, _value: u32) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_discoverable_timeout(&self) -> Result<u32, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn set_discoverable_timeout(&self, _value: u32) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn is_discovering(&self) -> Result<bool, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_uuids(&self) -> Result<Vec<String>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_vendor_id_source(&self) -> Result<String, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_vendor_id(&self) -> Result<u32, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_product_id(&self) -> Result<u32, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_device_id(&self) -> Result<u32, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_modalias(&self) -> Result<(String, u32, u32, u32), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-}
-
-#[derive(Clone, Debug)]
-pub struct BluetoothDiscoverySession {}
-
-impl BluetoothDiscoverySession {
-    pub fn create_session(
-        _adapter: Arc<EmptyAdapter>,
-    ) -> Result<BluetoothDiscoverySession, Box<dyn Error>> {
-        Ok(BluetoothDiscoverySession {})
-    }
-
-    pub fn start_discovery(&self) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn stop_discovery(&self) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-}
-
-#[derive(Clone, Debug)]
-pub struct BluetoothDevice {}
-
-impl BluetoothDevice {
-    pub fn new(_device: String) -> BluetoothDevice {
-        BluetoothDevice {}
-    }
-
-    pub fn get_id(&self) -> String {
-        String::new()
-    }
-
-    pub fn get_address(&self) -> Result<String, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_name(&self) -> Result<String, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_icon(&self) -> Result<String, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_class(&self) -> Result<u32, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_appearance(&self) -> Result<u16, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_uuids(&self) -> Result<Vec<String>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn is_paired(&self) -> Result<bool, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn is_connected(&self) -> Result<bool, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn is_trusted(&self) -> Result<bool, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn is_blocked(&self) -> Result<bool, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_alias(&self) -> Result<String, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn set_alias(&self, _value: String) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn is_legacy_pairing(&self) -> Result<bool, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_vendor_id_source(&self) -> Result<String, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_vendor_id(&self) -> Result<u32, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_product_id(&self) -> Result<u32, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_device_id(&self) -> Result<u32, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_modalias(&self) -> Result<(String, u32, u32, u32), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_rssi(&self) -> Result<i16, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_tx_power(&self) -> Result<i16, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_manufacturer_data(&self) -> Result<HashMap<u16, Vec<u8>>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_service_data(&self) -> Result<HashMap<String, Vec<u8>>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_gatt_services(&self) -> Result<Vec<String>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn connect(&self) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn disconnect(&self) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn connect_profile(&self, _uuid: String) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn disconnect_profile(&self, _uuid: String) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn pair(&self) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn cancel_pairing(&self) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-}
-
-#[derive(Clone, Debug)]
-pub struct BluetoothGATTService {}
-
-impl BluetoothGATTService {
-    pub fn new(_service: String) -> BluetoothGATTService {
-        BluetoothGATTService {}
-    }
-
-    pub fn get_id(&self) -> String {
-        String::new()
-    }
-
-    pub fn get_uuid(&self) -> Result<String, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn is_primary(&self) -> Result<bool, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_includes(&self) -> Result<Vec<String>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_gatt_characteristics(&self) -> Result<Vec<String>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-}
-
-#[derive(Clone, Debug)]
-pub struct BluetoothGATTCharacteristic {}
-
-impl BluetoothGATTCharacteristic {
-    pub fn new(_characteristic: String) -> BluetoothGATTCharacteristic {
-        BluetoothGATTCharacteristic {}
-    }
-
-    pub fn get_id(&self) -> String {
-        String::new()
-    }
-
-    pub fn get_uuid(&self) -> Result<String, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_value(&self) -> Result<Vec<u8>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn is_notifying(&self) -> Result<bool, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_flags(&self) -> Result<Vec<String>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_gatt_descriptors(&self) -> Result<Vec<String>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn read_value(&self) -> Result<Vec<u8>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn write_value(&self, _values: Vec<u8>) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn start_notify(&self) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn stop_notify(&self) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-}
-
-#[derive(Clone, Debug)]
-pub struct BluetoothGATTDescriptor {}
-
-impl BluetoothGATTDescriptor {
-    pub fn new(_descriptor: String) -> BluetoothGATTDescriptor {
-        BluetoothGATTDescriptor {}
-    }
-
-    pub fn get_id(&self) -> String {
-        String::new()
-    }
-
-    pub fn get_uuid(&self) -> Result<String, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_value(&self) -> Result<Vec<u8>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn get_flags(&self) -> Result<Vec<String>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn read_value(&self) -> Result<Vec<u8>, Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-
-    pub fn write_value(&self, _values: Vec<u8>) -> Result<(), Box<dyn Error>> {
-        Err(Box::from(NOT_SUPPORTED_ERROR))
-    }
-}

components/bluetooth/lib.rs

@@ -4,12 +4,6 @@
 
 pub mod adapter;
 pub mod bluetooth;
-#[cfg(not(any(
-    all(target_os = "linux", feature = "native-bluetooth"),
-    all(target_os = "android", feature = "native-bluetooth"),
-    all(target_os = "macos", feature = "native-bluetooth")
-)))]
-mod empty;
 mod macros;
 pub mod test;
 
@@ -19,21 +13,23 @@ use std::string::String;
 use std::thread;
 use std::time::Duration;
 
-use base::generic_channel::{self, GenericReceiver, GenericSender};
-use base::id::WebViewId;
 use bitflags::bitflags;
-use bluetooth_traits::blocklist::{Blocklist, uuid_is_blocklisted};
-use bluetooth_traits::scanfilter::{
+use embedder_traits::{BluetoothDeviceDescription, EmbedderMsg, EmbedderProxy};
+use log::warn;
+use rand::{self, Rng};
+#[cfg(not(feature = "native-bluetooth"))]
+use servo_base::generic_channel::GenericReceiver;
+use servo_base::generic_channel::{self, GenericSender};
+use servo_base::id::WebViewId;
+use servo_bluetooth_traits::blocklist::{Blocklist, uuid_is_blocklisted};
+use servo_bluetooth_traits::scanfilter::{
     BluetoothScanfilter, BluetoothScanfilterSequence, RequestDeviceoptions,
 };
-use bluetooth_traits::{
+use servo_bluetooth_traits::{
     BluetoothCharacteristicMsg, BluetoothDescriptorMsg, BluetoothDeviceMsg, BluetoothError,
     BluetoothRequest, BluetoothResponse, BluetoothResponseResult, BluetoothResult,
     BluetoothServiceMsg, GATTType,
 };
-use embedder_traits::{EmbedderMsg, EmbedderProxy};
-use log::warn;
-use rand::{self, Rng};
 use servo_config::pref;
 
 use crate::bluetooth::{
@@ -75,6 +71,47 @@ pub trait BluetoothThreadFactory {
 }
 
 impl BluetoothThreadFactory for GenericSender<BluetoothRequest> {
+    #[cfg(feature = "native-bluetooth")]
+    fn new(embedder_proxy: EmbedderProxy) -> GenericSender<BluetoothRequest> {
+        let (sender, receiver) = generic_channel::channel().unwrap();
+
+        thread::Builder::new()
+            .name("Bluetooth".to_owned())
+            .spawn(move || {
+                let runtime = tokio::runtime::Builder::new_current_thread()
+                    .enable_all()
+                    .build()
+                    .expect("Failed to create bluetooth tokio runtime");
+
+                let adapter = runtime.block_on(async {
+                    if pref!(dom_bluetooth_enabled) {
+                        BluetoothAdapter::new().await.ok()
+                    } else {
+                        BluetoothAdapter::new_mock().ok()
+                    }
+                });
+
+                // Bridge: GenericReceiver -> tokio mpsc channel
+                let (async_sender, async_receiver) = tokio::sync::mpsc::unbounded_channel();
+                thread::Builder::new()
+                    .name("BluetoothTokioBridge".to_owned())
+                    .spawn(move || {
+                        while let Ok(message) = receiver.recv() {
+                            if async_sender.send(message).is_err() {
+                                break;
+                            }
+                        }
+                    })
+                    .expect("BT Tokio Bridge thread spawning failed");
+
+                let mut manager = BluetoothManager::new(adapter, embedder_proxy);
+                runtime.block_on(manager.start(async_receiver));
+            })
+            .expect("Thread spawning failed");
+        sender
+    }
+
+    #[cfg(not(feature = "native-bluetooth"))]
     fn new(embedder_proxy: EmbedderProxy) -> GenericSender<BluetoothRequest> {
         let (sender, receiver) = generic_channel::channel().unwrap();
         let adapter = if pref!(dom_bluetooth_enabled) {
@@ -86,7 +123,7 @@ impl BluetoothThreadFactory for GenericSender<BluetoothRequest> {
         thread::Builder::new()
             .name("Bluetooth".to_owned())
             .spawn(move || {
-                BluetoothManager::new(receiver, adapter, embedder_proxy).start();
+                BluetoothManager::new(adapter, embedder_proxy).start_sync(receiver);
             })
             .expect("Thread spawning failed");
         sender
@@ -94,21 +131,21 @@ impl BluetoothThreadFactory for GenericSender<BluetoothRequest> {
 }
 
 /// <https://webbluetoothcg.github.io/web-bluetooth/#matches-a-filter>
-fn matches_filter(device: &BluetoothDevice, filter: &BluetoothScanfilter) -> bool {
+async fn matches_filter(device: &BluetoothDevice, filter: &BluetoothScanfilter) -> bool {
     if filter.is_empty_or_invalid() {
         return false;
     }
 
     // Step 1.
     if let Some(name) = filter.get_name() {
-        if device.get_name().ok() != Some(name.to_string()) {
+        if device.get_name().await.ok() != Some(name.to_string()) {
             return false;
         }
     }
 
     // Step 2.
     if !filter.get_name_prefix().is_empty() {
-        if let Ok(device_name) = device.get_name() {
+        if let Ok(device_name) = device.get_name().await {
             if !device_name.starts_with(filter.get_name_prefix()) {
                 return false;
             }
@@ -119,7 +156,7 @@ fn matches_filter(device: &BluetoothDevice, filter: &BluetoothScanfilter) -> boo
 
     // Step 3.
     if !filter.get_services().is_empty() {
-        if let Ok(device_uuids) = device.get_uuids() {
+        if let Ok(device_uuids) = device.get_uuids().await {
             for service in filter.get_services() {
                 if !device_uuids.iter().any(|x| x == service) {
                     return false;
@@ -130,7 +167,7 @@ fn matches_filter(device: &BluetoothDevice, filter: &BluetoothScanfilter) -> boo
 
     // Step 4.
     if let Some(manufacturer_data) = filter.get_manufacturer_data() {
-        let advertised_manufacturer_data = match device.get_manufacturer_data() {
+        let advertised_manufacturer_data = match device.get_manufacturer_data().await {
             Ok(data) => data,
             Err(_) => return false,
         };
@@ -147,7 +184,7 @@ fn matches_filter(device: &BluetoothDevice, filter: &BluetoothScanfilter) -> boo
 
     // Step 5.
     if let Some(service_data) = filter.get_service_data() {
-        let advertised_service_data = match device.get_service_data() {
+        let advertised_service_data = match device.get_service_data().await {
             Ok(data) => data,
             Err(_) => return false,
         };
@@ -185,12 +222,28 @@ fn data_filter_matches(data: &[u8], prefix: &[u8], mask: &[u8]) -> bool {
     true
 }
 
-fn matches_filters(device: &BluetoothDevice, filters: &BluetoothScanfilterSequence) -> bool {
+async fn matches_filters(device: &BluetoothDevice, filters: &BluetoothScanfilterSequence) -> bool {
     if filters.has_empty_or_invalid_filter() {
         return false;
     }
+    for f in filters.iter() {
+        if matches_filter(device, f).await {
+            return true;
+        }
+    }
+    false
+}
 
-    filters.iter().any(|f| matches_filter(device, f))
+/// Async sleep that works in both tokio and non-tokio (mock) contexts.
+async fn async_sleep(duration: Duration) {
+    #[cfg(feature = "native-bluetooth")]
+    {
+        tokio::time::sleep(duration).await;
+    }
+    #[cfg(not(feature = "native-bluetooth"))]
+    {
+        thread::sleep(duration);
+    }
 }
 
 fn is_mock_adapter(adapter: &BluetoothAdapter) -> bool {
@@ -198,7 +251,6 @@ fn is_mock_adapter(adapter: &BluetoothAdapter) -> bool {
 }
 
 pub struct BluetoothManager {
-    receiver: GenericReceiver<BluetoothRequest>,
     adapter: Option<BluetoothAdapter>,
     address_to_id: HashMap<String, String>,
     service_to_device: HashMap<String, String>,
@@ -214,12 +266,10 @@ pub struct BluetoothManager {
 
 impl BluetoothManager {
     pub fn new(
-        receiver: GenericReceiver<BluetoothRequest>,
         adapter: Option<BluetoothAdapter>,
         embedder_proxy: EmbedderProxy,
     ) -> BluetoothManager {
         BluetoothManager {
-            receiver,
             adapter,
             address_to_id: HashMap::new(),
             service_to_device: HashMap::new(),
@@ -234,58 +284,82 @@ impl BluetoothManager {
         }
     }
 
-    fn start(&mut self) {
-        while let Ok(msg) = self.receiver.recv() {
-            match msg {
-                BluetoothRequest::RequestDevice(options, sender) => {
-                    let _ = sender.send(self.request_device(options));
-                },
-                BluetoothRequest::GATTServerConnect(device_id, sender) => {
-                    let _ = sender.send(self.gatt_server_connect(device_id));
-                },
-                BluetoothRequest::GATTServerDisconnect(device_id, sender) => {
-                    let _ = sender.send(self.gatt_server_disconnect(device_id));
-                },
-                BluetoothRequest::GetGATTChildren(id, uuid, single, child_type, sender) => {
-                    let _ = sender.send(self.get_gatt_children(id, uuid, single, child_type));
-                },
-                BluetoothRequest::ReadValue(id, sender) => {
-                    let _ = sender.send(self.read_value(id));
-                },
-                BluetoothRequest::WriteValue(id, value, sender) => {
-                    let _ = sender.send(self.write_value(id, value));
-                },
-                BluetoothRequest::EnableNotification(id, enable, sender) => {
-                    let _ = sender.send(self.enable_notification(id, enable));
-                },
-                BluetoothRequest::WatchAdvertisements(id, sender) => {
-                    let _ = sender.send(self.watch_advertisements(id));
-                },
-                BluetoothRequest::Test(data_set_name, sender) => {
-                    let _ = sender.send(self.test(data_set_name));
-                },
-                BluetoothRequest::SetRepresentedToNull(
-                    service_ids,
-                    characteristic_ids,
-                    descriptor_ids,
-                ) => self.remove_ids_from_caches(service_ids, characteristic_ids, descriptor_ids),
-                BluetoothRequest::IsRepresentedDeviceNull(id, sender) => {
-                    let _ = sender.send(!self.device_is_cached(&id));
-                },
-                BluetoothRequest::GetAvailability(sender) => {
-                    let _ = sender.send(self.get_availability());
-                },
-                BluetoothRequest::MatchesFilter(id, filters, sender) => {
-                    let _ = sender.send(self.device_matches_filter(&id, &filters));
-                },
-                BluetoothRequest::Exit => break,
+    /// Async message loop.
+    /// The tokio runtime is always active, so btleplug's background tasks run continuously.
+    #[cfg(feature = "native-bluetooth")]
+    async fn start(&mut self, mut rx: tokio::sync::mpsc::UnboundedReceiver<BluetoothRequest>) {
+        while let Some(msg) = rx.recv().await {
+            if self.handle_message(msg).await {
+                break;
             }
         }
     }
 
+    /// Synchronous message loop.
+    #[cfg(not(feature = "native-bluetooth"))]
+    fn start_sync(&mut self, receiver: GenericReceiver<BluetoothRequest>) {
+        // For mock-only builds, we don't have a tokio runtime.
+        // Create a minimal one just to call async methods (which are fast for mock).
+        while let Ok(msg) = receiver.recv() {
+            let should_exit = futures::executor::block_on(self.handle_message(msg));
+            if should_exit {
+                break;
+            }
+        }
+    }
+
+    /// Handle a single message. Returns true if the event loop should exit.
+    async fn handle_message(&mut self, msg: BluetoothRequest) -> bool {
+        match msg {
+            BluetoothRequest::RequestDevice(options, sender) => {
+                let _ = sender.send(self.request_device(options).await);
+            },
+            BluetoothRequest::GATTServerConnect(device_id, sender) => {
+                let _ = sender.send(self.gatt_server_connect(device_id).await);
+            },
+            BluetoothRequest::GATTServerDisconnect(device_id, sender) => {
+                let _ = sender.send(self.gatt_server_disconnect(device_id).await);
+            },
+            BluetoothRequest::GetGATTChildren(id, uuid, single, child_type, sender) => {
+                let _ = sender.send(self.get_gatt_children(id, uuid, single, child_type).await);
+            },
+            BluetoothRequest::ReadValue(id, sender) => {
+                let _ = sender.send(self.read_value(id).await);
+            },
+            BluetoothRequest::WriteValue(id, value, sender) => {
+                let _ = sender.send(self.write_value(id, value).await);
+            },
+            BluetoothRequest::EnableNotification(id, enable, sender) => {
+                let _ = sender.send(self.enable_notification(id, enable).await);
+            },
+            BluetoothRequest::WatchAdvertisements(id, sender) => {
+                let _ = sender.send(self.watch_advertisements(id));
+            },
+            BluetoothRequest::Test(data_set_name, sender) => {
+                let _ = sender.send(self.test(data_set_name).await);
+            },
+            BluetoothRequest::SetRepresentedToNull(
+                service_ids,
+                characteristic_ids,
+                descriptor_ids,
+            ) => self.remove_ids_from_caches(service_ids, characteristic_ids, descriptor_ids),
+            BluetoothRequest::IsRepresentedDeviceNull(id, sender) => {
+                let _ = sender.send(!self.device_is_cached(&id));
+            },
+            BluetoothRequest::GetAvailability(sender) => {
+                let _ = sender.send(self.get_availability().await);
+            },
+            BluetoothRequest::MatchesFilter(id, filters, sender) => {
+                let _ = sender.send(self.device_matches_filter(&id, &filters).await);
+            },
+            BluetoothRequest::Exit => return true,
+        }
+        false
+    }
+
     // Test
 
-    fn test(&mut self, data_set_name: String) -> BluetoothResult<()> {
+    async fn test(&mut self, data_set_name: String) -> BluetoothResult<()> {
         self.address_to_id.clear();
         self.service_to_device.clear();
         self.characteristic_to_service.clear();
@@ -296,7 +370,7 @@ impl BluetoothManager {
         self.cached_descriptors.clear();
         self.allowed_services.clear();
         self.adapter = BluetoothAdapter::new_mock().ok();
-        match test::test(self, data_set_name) {
+        match test::test(self, data_set_name).await {
             Ok(_) => Ok(()),
             Err(error) => Err(BluetoothError::Type(error.to_string())),
         }
@@ -326,13 +400,20 @@ impl BluetoothManager {
 
     // Adapter
 
-    pub fn get_or_create_adapter(&mut self) -> Option<BluetoothAdapter> {
-        let adapter_valid = self
-            .adapter
-            .as_ref()
-            .is_some_and(|a| a.get_address().is_ok());
+    pub async fn get_or_create_adapter(&mut self) -> Option<BluetoothAdapter> {
+        let adapter_valid = match self.adapter.as_ref() {
+            Some(a) => a.get_address().await.is_ok(),
+            None => false,
+        };
         if !adapter_valid {
-            self.adapter = BluetoothAdapter::new().ok();
+            #[cfg(feature = "native-bluetooth")]
+            {
+                self.adapter = BluetoothAdapter::new().await.ok();
+            }
+            #[cfg(not(feature = "native-bluetooth"))]
+            {
+                self.adapter = BluetoothAdapter::new().ok();
+            }
         }
 
         let adapter = self.adapter.as_ref()?;
@@ -344,10 +425,10 @@ impl BluetoothManager {
         self.adapter.clone()
     }
 
-    fn get_adapter(&mut self) -> BluetoothResult<BluetoothAdapter> {
-        match self.get_or_create_adapter() {
+    async fn get_adapter(&mut self) -> BluetoothResult<BluetoothAdapter> {
+        match self.get_or_create_adapter().await {
             Some(adapter) => {
-                if !adapter.is_powered().unwrap_or(false) {
+                if !adapter.is_powered().await.unwrap_or(false) {
                     return Err(BluetoothError::NotFound);
                 }
                 Ok(adapter)
@@ -358,8 +439,11 @@ impl BluetoothManager {
 
     // Device
 
-    fn get_and_cache_devices(&mut self, adapter: &mut BluetoothAdapter) -> Vec<BluetoothDevice> {
-        let devices = adapter.get_devices().unwrap_or_default();
+    async fn get_and_cache_devices(
+        &mut self,
+        adapter: &mut BluetoothAdapter,
+    ) -> Vec<BluetoothDevice> {
+        let devices = adapter.get_devices().await.unwrap_or_default();
         for device in &devices {
             if let Ok(address) = device.get_address() {
                 #[allow(clippy::map_entry)] // False positive, the fix creates a borrowing error
@@ -375,18 +459,18 @@ impl BluetoothManager {
         self.cached_devices.values().cloned().collect()
     }
 
-    fn get_device(
+    async fn get_device(
         &mut self,
         adapter: &mut BluetoothAdapter,
         device_id: &str,
     ) -> Option<&BluetoothDevice> {
         return_if_cached!(self.cached_devices, device_id);
-        self.get_and_cache_devices(adapter);
+        self.get_and_cache_devices(adapter).await;
         return_if_cached!(self.cached_devices, device_id);
         None
     }
 
-    fn select_device(
+    async fn select_device(
         &mut self,
         webview_id: WebViewId,
         devices: Vec<BluetoothDevice>,
@@ -401,12 +485,18 @@ impl BluetoothManager {
             return None;
         }
 
-        let mut dialog_rows: Vec<String> = vec![];
+        let mut device_descriptions = Vec::with_capacity(devices.len());
         for device in devices {
-            dialog_rows.extend_from_slice(&[
-                device.get_address().unwrap_or("".to_string()),
-                device.get_name().unwrap_or("".to_string()),
-            ]);
+            let address = device.get_address().unwrap_or_default();
+            let name = device.get_name().await.unwrap_or_else(|_| {
+                let short = if address.len() > 8 {
+                    &address[..8]
+                } else {
+                    &address
+                };
+                format!("Unknown ({}...)", short)
+            });
+            device_descriptions.push(BluetoothDeviceDescription { address, name });
         }
 
         let (ipc_sender, ipc_receiver) =
@@ -414,7 +504,7 @@ impl BluetoothManager {
         self.embedder_proxy
             .send(EmbedderMsg::GetSelectedBluetoothDevice(
                 webview_id,
-                dialog_rows,
+                device_descriptions,
                 ipc_sender,
             ));
 
@@ -449,27 +539,27 @@ impl BluetoothManager {
             self.address_to_id.values().any(|v| v == device_id)
     }
 
-    fn device_matches_filter(
+    async fn device_matches_filter(
         &mut self,
         device_id: &str,
         filters: &BluetoothScanfilterSequence,
     ) -> BluetoothResult<bool> {
-        let mut adapter = self.get_adapter()?;
-        match self.get_device(&mut adapter, device_id) {
-            Some(device) => Ok(matches_filters(device, filters)),
+        let mut adapter = self.get_adapter().await?;
+        match self.get_device(&mut adapter, device_id).await {
+            Some(device) => Ok(matches_filters(device, filters).await),
             None => Ok(false),
         }
     }
 
     // Service
 
-    fn get_and_cache_gatt_services(
+    async fn get_and_cache_gatt_services(
         &mut self,
         adapter: &mut BluetoothAdapter,
         device_id: &str,
     ) -> Vec<BluetoothGATTService> {
-        let mut services = match self.get_device(adapter, device_id) {
-            Some(d) => d.get_gatt_services().unwrap_or_default(),
+        let mut services = match self.get_device(adapter, device_id).await {
+            Some(d) => d.get_gatt_services().await.unwrap_or_default(),
             None => vec![],
         };
 
@@ -488,14 +578,14 @@ impl BluetoothManager {
         services
     }
 
-    fn get_gatt_service(
+    async fn get_gatt_service(
         &mut self,
         adapter: &mut BluetoothAdapter,
         service_id: &str,
     ) -> Option<&BluetoothGATTService> {
         return_if_cached!(self.cached_services, service_id);
         let device_id = self.service_to_device.get(service_id)?.clone();
-        self.get_and_cache_gatt_services(adapter, &device_id);
+        self.get_and_cache_gatt_services(adapter, &device_id).await;
         return_if_cached!(self.cached_services, service_id);
         None
     }
@@ -507,12 +597,12 @@ impl BluetoothManager {
 
     // Characteristic
 
-    fn get_and_cache_gatt_characteristics(
+    async fn get_and_cache_gatt_characteristics(
         &mut self,
         adapter: &mut BluetoothAdapter,
         service_id: &str,
     ) -> Vec<BluetoothGATTCharacteristic> {
-        let mut characteristics = match self.get_gatt_service(adapter, service_id) {
+        let mut characteristics = match self.get_gatt_service(adapter, service_id).await {
             Some(s) => s.get_gatt_characteristics().unwrap_or_default(),
             None => vec![],
         };
@@ -528,7 +618,7 @@ impl BluetoothManager {
         characteristics
     }
 
-    fn get_gatt_characteristic(
+    async fn get_gatt_characteristic(
         &mut self,
         adapter: &mut BluetoothAdapter,
         characteristic_id: &str,
@@ -538,7 +628,8 @@ impl BluetoothManager {
             .characteristic_to_service
             .get(characteristic_id)?
             .clone();
-        self.get_and_cache_gatt_characteristics(adapter, &service_id);
+        self.get_and_cache_gatt_characteristics(adapter, &service_id)
+            .await;
         return_if_cached!(self.cached_characteristics, characteristic_id);
         None
     }
@@ -571,12 +662,15 @@ impl BluetoothManager {
 
     // Descriptor
 
-    fn get_and_cache_gatt_descriptors(
+    async fn get_and_cache_gatt_descriptors(
         &mut self,
         adapter: &mut BluetoothAdapter,
         characteristic_id: &str,
     ) -> Vec<BluetoothGATTDescriptor> {
-        let mut descriptors = match self.get_gatt_characteristic(adapter, characteristic_id) {
+        let mut descriptors = match self
+            .get_gatt_characteristic(adapter, characteristic_id)
+            .await
+        {
             Some(c) => c.get_gatt_descriptors().unwrap_or_default(),
             None => vec![],
         };
@@ -592,7 +686,7 @@ impl BluetoothManager {
         descriptors
     }
 
-    fn get_gatt_descriptor(
+    async fn get_gatt_descriptor(
         &mut self,
         adapter: &mut BluetoothAdapter,
         descriptor_id: &str,
@@ -602,7 +696,8 @@ impl BluetoothManager {
             .descriptor_to_characteristic
             .get(descriptor_id)?
             .clone();
-        self.get_and_cache_gatt_descriptors(adapter, &characteristic_id);
+        self.get_and_cache_gatt_descriptors(adapter, &characteristic_id)
+            .await;
         return_if_cached!(self.cached_descriptors, descriptor_id);
         None
     }
@@ -610,29 +705,37 @@ impl BluetoothManager {
     // Methods
 
     /// <https://webbluetoothcg.github.io/web-bluetooth/#request-bluetooth-devices>
-    fn request_device(&mut self, options: RequestDeviceoptions) -> BluetoothResponseResult {
+    async fn request_device(&mut self, options: RequestDeviceoptions) -> BluetoothResponseResult {
         // Step 6.
-        let mut adapter = self.get_adapter()?;
+        let mut adapter = self.get_adapter().await?;
 
         // Step 7.
         // Note: There are no requiredServiceUUIDS, we scan for all devices.
         if let Ok(ref session) = adapter.create_discovery_session() {
-            if session.start_discovery().is_ok() && !is_mock_adapter(&adapter) {
-                thread::sleep(Duration::from_millis(DISCOVERY_TIMEOUT_MS));
+            if session.start_discovery().await.is_ok() && !is_mock_adapter(&adapter) {
+                async_sleep(Duration::from_millis(DISCOVERY_TIMEOUT_MS)).await;
             }
-
-            let _ = session.stop_discovery();
+            let _ = session.stop_discovery().await;
         }
 
-        let mut matched_devices = self.get_and_cache_devices(&mut adapter);
+        let mut matched_devices = self.get_and_cache_devices(&mut adapter).await;
 
         // Step 8.
         if !options.is_accepting_all_devices() {
-            matched_devices.retain(|d| matches_filters(d, options.get_filters()));
+            let mut filtered = Vec::new();
+            for d in matched_devices {
+                if matches_filters(&d, options.get_filters()).await {
+                    filtered.push(d);
+                }
+            }
+            matched_devices = filtered;
         }
 
         // Step 9.
-        if let Some(address) = self.select_device(options.webview_id(), matched_devices, &adapter) {
+        if let Some(address) = self
+            .select_device(options.webview_id(), matched_devices, &adapter)
+            .await
+        {
             let device_id = match self.address_to_id.get(&address) {
                 Some(id) => id.clone(),
                 None => return Err(BluetoothError::NotFound),
@@ -642,10 +745,10 @@ impl BluetoothManager {
                 services = services_set | &services;
             }
             self.allowed_services.insert(device_id.clone(), services);
-            if let Some(device) = self.get_device(&mut adapter, &device_id) {
+            if let Some(device) = self.get_device(&mut adapter, &device_id).await {
                 let message = BluetoothDeviceMsg {
                     id: device_id,
-                    name: device.get_name().ok(),
+                    name: device.get_name().await.ok(),
                 };
                 return Ok(BluetoothResponse::RequestDevice(message));
             }
@@ -656,28 +759,28 @@ impl BluetoothManager {
     }
 
     /// <https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattserver-connect>
-    fn gatt_server_connect(&mut self, device_id: String) -> BluetoothResponseResult {
+    async fn gatt_server_connect(&mut self, device_id: String) -> BluetoothResponseResult {
         // Step 2.
         if !self.device_is_cached(&device_id) {
             return Err(BluetoothError::Network);
         }
-        let mut adapter = self.get_adapter()?;
+        let mut adapter = self.get_adapter().await?;
 
         // Step 5.1.1.
-        match self.get_device(&mut adapter, &device_id) {
+        match self.get_device(&mut adapter, &device_id).await {
             Some(d) => {
-                if d.is_connected().unwrap_or(false) {
+                if d.is_connected().await.unwrap_or(false) {
                     return Ok(BluetoothResponse::GATTServerConnect(true));
                 }
-                let _ = d.connect();
+                let _ = d.connect().await;
                 for _ in 0..MAXIMUM_TRANSACTION_TIME {
-                    if d.is_connected().unwrap_or(false) {
+                    if d.is_connected().await.unwrap_or(false) {
                         return Ok(BluetoothResponse::GATTServerConnect(true));
                     } else {
                         if is_mock_adapter(&adapter) {
                             break;
                         }
-                        thread::sleep(Duration::from_millis(CONNECTION_TIMEOUT_MS));
+                        async_sleep(Duration::from_millis(CONNECTION_TIMEOUT_MS)).await;
                     }
                     // TODO: Step 5.1.4: Use the exchange MTU procedure.
                 }
@@ -689,18 +792,18 @@ impl BluetoothManager {
     }
 
     /// <https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattserver-disconnect>
-    fn gatt_server_disconnect(&mut self, device_id: String) -> BluetoothResult<()> {
-        let mut adapter = self.get_adapter()?;
-        match self.get_device(&mut adapter, &device_id) {
+    async fn gatt_server_disconnect(&mut self, device_id: String) -> BluetoothResult<()> {
+        let mut adapter = self.get_adapter().await?;
+        match self.get_device(&mut adapter, &device_id).await {
             Some(d) => {
                 // Step 2.
-                if !d.is_connected().unwrap_or(true) {
+                if !d.is_connected().await.unwrap_or(true) {
                     return Ok(());
                 }
-                let _ = d.disconnect();
+                let _ = d.disconnect().await;
                 for _ in 0..MAXIMUM_TRANSACTION_TIME {
-                    if d.is_connected().unwrap_or(true) {
-                        thread::sleep(Duration::from_millis(CONNECTION_TIMEOUT_MS))
+                    if d.is_connected().await.unwrap_or(true) {
+                        async_sleep(Duration::from_millis(CONNECTION_TIMEOUT_MS)).await;
                     } else {
                         return Ok(());
                     }
@@ -712,14 +815,14 @@ impl BluetoothManager {
     }
 
     /// <https://webbluetoothcg.github.io/web-bluetooth/#getgattchildren>
-    fn get_gatt_children(
+    async fn get_gatt_children(
         &mut self,
         id: String,
         uuid: Option<String>,
         single: bool,
         child_type: GATTType,
     ) -> BluetoothResponseResult {
-        let mut adapter = self.get_adapter()?;
+        let mut adapter = self.get_adapter().await?;
         match child_type {
             GATTType::PrimaryService => {
                 // Step 5.
@@ -736,7 +839,7 @@ impl BluetoothManager {
                         return Err(BluetoothError::Security);
                     }
                 }
-                let mut services = self.get_and_cache_gatt_services(&mut adapter, &id);
+                let mut services = self.get_and_cache_gatt_services(&mut adapter, &id).await;
                 if let Some(uuid) = uuid {
                     services.retain(|e| e.get_uuid().unwrap_or_default() == uuid);
                 }
@@ -752,6 +855,7 @@ impl BluetoothManager {
                         }
                     }
                 }
+
                 // Step 7.
                 if services_vec.is_empty() {
                     return Err(BluetoothError::NotFound);
@@ -765,8 +869,9 @@ impl BluetoothManager {
                     return Err(BluetoothError::InvalidState);
                 }
                 // Step 6.
-                let mut characteristics =
-                    self.get_and_cache_gatt_characteristics(&mut adapter, &id);
+                let mut characteristics = self
+                    .get_and_cache_gatt_characteristics(&mut adapter, &id)
+                    .await;
                 if let Some(uuid) = uuid {
                     characteristics.retain(|e| e.get_uuid().unwrap_or_default() == uuid);
                 }
@@ -812,7 +917,7 @@ impl BluetoothManager {
                     Some(device) => device,
                     None => return Err(BluetoothError::NotFound),
                 };
-                let primary_service = match self.get_gatt_service(&mut adapter, &id) {
+                let primary_service = match self.get_gatt_service(&mut adapter, &id).await {
                     Some(s) => s,
                     None => return Err(BluetoothError::NotFound),
                 };
@@ -845,7 +950,7 @@ impl BluetoothManager {
                     return Err(BluetoothError::InvalidState);
                 }
                 // Step 6.
-                let mut descriptors = self.get_and_cache_gatt_descriptors(&mut adapter, &id);
+                let mut descriptors = self.get_and_cache_gatt_descriptors(&mut adapter, &id).await;
                 if let Some(uuid) = uuid {
                     descriptors.retain(|e| e.get_uuid().unwrap_or_default() == uuid);
                 }
@@ -870,23 +975,25 @@ impl BluetoothManager {
 
     /// <https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattcharacteristic-readvalue>
     /// <https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattdescriptor-readvalue>
-    fn read_value(&mut self, id: String) -> BluetoothResponseResult {
+    async fn read_value(&mut self, id: String) -> BluetoothResponseResult {
         // (Characteristic) Step 5.2: Missing because it is optional.
         // (Descriptor)     Step 5.1: Missing because it is optional.
-        let mut adapter = self.get_adapter()?;
+        let mut adapter = self.get_adapter().await?;
 
         // (Characteristic) Step 5.3.
-        let mut value = self
-            .get_gatt_characteristic(&mut adapter, &id)
-            .map(|c| c.read_value().unwrap_or_default());
+        let mut value = match self.get_gatt_characteristic(&mut adapter, &id).await {
+            Some(c) => Some(c.read_value().await.unwrap_or_default()),
+            None => None,
+        };
 
         // (Characteristic) TODO: Step 5.4: Handle all the errors returned from the read_value call.
 
         // (Descriptor) Step 5.2.
         if value.is_none() {
-            value = self
-                .get_gatt_descriptor(&mut adapter, &id)
-                .map(|d| d.read_value().unwrap_or_default());
+            value = match self.get_gatt_descriptor(&mut adapter, &id).await {
+                Some(d) => Some(d.read_value().await.unwrap_or_default()),
+                None => None,
+            };
         }
 
         // (Descriptor) TODO: Step 5.3: Handle all the errors returned from the read_value call.
@@ -904,36 +1011,36 @@ impl BluetoothManager {
 
     /// <https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattcharacteristic-writevalue>
     /// <https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattdescriptor-writevalue>
-    fn write_value(&mut self, id: String, value: Vec<u8>) -> BluetoothResponseResult {
+    async fn write_value(&mut self, id: String, value: Vec<u8>) -> BluetoothResponseResult {
         // (Characteristic) Step 7.2: Missing because it is optional.
         // (Descriptor)     Step 7.1: Missing because it is optional.
-        let mut adapter = self.get_adapter()?;
+        let mut adapter = self.get_adapter().await?;
 
         // (Characteristic) Step 7.3.
-        let mut result = self
-            .get_gatt_characteristic(&mut adapter, &id)
-            .map(|c| c.write_value(value.clone()));
+        let mut result = match self.get_gatt_characteristic(&mut adapter, &id).await {
+            Some(c) => Some(c.write_value(value.clone()).await),
+            None => None,
+        };
 
         // (Characteristic) TODO: Step 7.4: Handle all the errors returned from the write_value call.
 
         // (Descriptor) Step 7.2.
         if result.is_none() {
-            result = self
-                .get_gatt_descriptor(&mut adapter, &id)
-                .map(|d| d.write_value(value.clone()));
+            result = match self.get_gatt_descriptor(&mut adapter, &id).await {
+                Some(d) => Some(d.write_value(value.clone()).await),
+                None => None,
+            };
         }
 
         // (Descriptor) TODO: Step 7.3: Handle all the errors returned from the write_value call.
 
         match result {
-            Some(v) => match v {
-                // (Characteristic) Step 7.5.3.
-                // (Descriptor) Step 7.4.3.
-                Ok(_) => Ok(BluetoothResponse::WriteValue(value)),
+            // (Characteristic) Step 7.5.3.
+            // (Descriptor) Step 7.4.3.
+            Some(Ok(_)) => Ok(BluetoothResponse::WriteValue(value)),
 
-                // (Characteristic) Step 7.1.
-                Err(_) => Err(BluetoothError::NotSupported),
-            },
+            // (Characteristic) Step 7.1.
+            Some(Err(_)) => Err(BluetoothError::NotSupported),
 
             // (Characteristic) Step 6.
             // (Descriptor)     Step 6.
@@ -943,7 +1050,7 @@ impl BluetoothManager {
 
     /// <https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattcharacteristic-startnotifications>
     /// <https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattcharacteristic-stopnotifications>
-    fn enable_notification(&mut self, id: String, enable: bool) -> BluetoothResponseResult {
+    async fn enable_notification(&mut self, id: String, enable: bool) -> BluetoothResponseResult {
         // (StartNotifications) Step 3 - 4.
         // (StopNotifications) Step 1 - 2.
         if !self.characteristic_is_cached(&id) {
@@ -951,16 +1058,16 @@ impl BluetoothManager {
         }
 
         // (StartNotification) TODO: Step 7: Missing because it is optional.
-        let mut adapter = self.get_adapter()?;
-        match self.get_gatt_characteristic(&mut adapter, &id) {
+        let mut adapter = self.get_adapter().await?;
+        match self.get_gatt_characteristic(&mut adapter, &id).await {
             Some(c) => {
                 let result = if enable {
                     // (StartNotification) Step 8.
                     // TODO: Handle all the errors returned from the start_notify call.
-                    c.start_notify()
+                    c.start_notify().await
                 } else {
                     // (StopNotification) Step 4.
-                    c.stop_notify()
+                    c.stop_notify().await
                 };
                 match result {
                     // (StartNotification) Step 11.
@@ -984,9 +1091,9 @@ impl BluetoothManager {
     }
 
     /// <https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetooth-getavailability>
-    fn get_availability(&mut self) -> BluetoothResponseResult {
+    async fn get_availability(&mut self) -> BluetoothResponseResult {
         Ok(BluetoothResponse::GetAvailability(
-            self.get_adapter().is_ok(),
+            self.get_adapter().await.is_ok(),
         ))
     }
 }

components/bluetooth/macros.rs

@@ -2,81 +2,12 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-macro_rules! get_inner_and_call(
-    ($enum_value: expr, $enum_type: ident, $function_name: ident) => {
-        match $enum_value {
-            #[cfg(all(target_os = "linux", feature = "native-bluetooth"))]
-            &$enum_type::Bluez(ref bluez) => bluez.$function_name(),
-            #[cfg(all(target_os = "android", feature = "native-bluetooth"))]
-            &$enum_type::Android(ref android) => android.$function_name(),
-            #[cfg(all(target_os = "macos", feature = "native-bluetooth"))]
-            &$enum_type::Mac(ref mac) => mac.$function_name(),
-            #[cfg(not(any(all(target_os = "linux", feature = "native-bluetooth"),
-                          all(target_os = "android", feature = "native-bluetooth"),
-                          all(target_os = "macos", feature = "native-bluetooth"))))]
-            &$enum_type::Empty(ref empty) => empty.$function_name(),
-            #[cfg(feature = "bluetooth-test")]
-            &$enum_type::Mock(ref fake) => fake.$function_name(),
-        }
-    };
-
-    (@with_bluez_offset, $enum_value: expr, $enum_type: ident, $function_name: ident) => {
-        match $enum_value {
-            #[cfg(all(target_os = "linux", feature = "native-bluetooth"))]
-            &$enum_type::Bluez(ref bluez) => bluez.$function_name(None),
-            #[cfg(all(target_os = "android", feature = "native-bluetooth"))]
-            &$enum_type::Android(ref android) => android.$function_name(),
-            #[cfg(all(target_os = "macos", feature = "native-bluetooth"))]
-            &$enum_type::Mac(ref mac) => mac.$function_name(),
-            #[cfg(not(any(all(target_os = "linux", feature = "native-bluetooth"),
-                          all(target_os = "android", feature = "native-bluetooth"),
-                          all(target_os = "macos", feature = "native-bluetooth"))))]
-            &$enum_type::Empty(ref empty) => empty.$function_name(),
-            #[cfg(feature = "bluetooth-test")]
-            &$enum_type::Mock(ref fake) => fake.$function_name(),
-        }
-    };
-
-    ($enum_value: expr, $enum_type: ident, $function_name: ident, $value: expr) => {
-        match $enum_value {
-            #[cfg(all(target_os = "linux", feature = "native-bluetooth"))]
-            &$enum_type::Bluez(ref bluez) => bluez.$function_name($value),
-            #[cfg(all(target_os = "android", feature = "native-bluetooth"))]
-            &$enum_type::Android(ref android) => android.$function_name($value),
-            #[cfg(all(target_os = "macos", feature = "native-bluetooth"))]
-            &$enum_type::Mac(ref mac) => mac.$function_name($value),
-            #[cfg(not(any(all(target_os = "linux", feature = "native-bluetooth"),
-                          all(target_os = "android", feature = "native-bluetooth"),
-                          all(target_os = "macos", feature = "native-bluetooth"))))]
-            &$enum_type::Empty(ref empty) => empty.$function_name($value),
-            #[cfg(feature = "bluetooth-test")]
-            &$enum_type::Mock(ref fake) => fake.$function_name($value),
-        }
-    };
-
-    (@with_bluez_offset, $enum_value: expr, $enum_type: ident, $function_name: ident, $value: expr) => {
-        match $enum_value {
-            #[cfg(all(target_os = "linux", feature = "native-bluetooth"))]
-            &$enum_type::Bluez(ref bluez) => bluez.$function_name($value, None),
-            #[cfg(all(target_os = "android", feature = "native-bluetooth"))]
-            &$enum_type::Android(ref android) => android.$function_name($value),
-            #[cfg(all(target_os = "macos", feature = "native-bluetooth"))]
-            &$enum_type::Mac(ref mac) => mac.$function_name($value),
-            #[cfg(not(any(all(target_os = "linux", feature = "native-bluetooth"),
-                          all(target_os = "android", feature = "native-bluetooth"),
-                          all(target_os = "macos", feature = "native-bluetooth"))))]
-            &$enum_type::Empty(ref empty) => empty.$function_name($value),
-            #[cfg(feature = "bluetooth-test")]
-            &$enum_type::Mock(ref fake) => fake.$function_name($value),
-        }
-    };
-);
-
 #[cfg(feature = "bluetooth-test")]
 macro_rules! get_inner_and_call_test_func {
     ($enum_value: expr, $enum_type: ident, $function_name: ident, $value: expr) => {
         match $enum_value {
             &$enum_type::Mock(ref fake) => fake.$function_name($value),
+            #[cfg(feature = "native-bluetooth")]
             _ => Err(Box::from(
                 "Error! Test functions are not supported on real devices!",
             )),
@@ -86,6 +17,7 @@ macro_rules! get_inner_and_call_test_func {
     ($enum_value: expr, $enum_type: ident, $function_name: ident) => {
         match $enum_value {
             &$enum_type::Mock(ref fake) => fake.$function_name(),
+            #[cfg(feature = "native-bluetooth")]
             _ => Err(Box::from(
                 "Error! Test functions are not supported on real devices!",
             )),
@@ -93,6 +25,5 @@ macro_rules! get_inner_and_call_test_func {
     };
 }
 
-pub(crate) use get_inner_and_call;
 #[cfg(feature = "bluetooth-test")]
 pub(crate) use get_inner_and_call_test_func;

components/bluetooth/test.rs

@@ -512,8 +512,11 @@ fn create_glucose_heart_rate_devices(adapter: &BluetoothAdapter) -> Result<(), B
     Ok(())
 }
 
-pub fn test(manager: &mut BluetoothManager, data_set_name: String) -> Result<(), Box<dyn Error>> {
-    let may_existing_adapter = manager.get_or_create_adapter();
+pub async fn test(
+    manager: &mut BluetoothManager,
+    data_set_name: String,
+) -> Result<(), Box<dyn Error>> {
+    let may_existing_adapter = manager.get_or_create_adapter().await;
     let adapter = match may_existing_adapter.as_ref() {
         Some(adapter) => adapter,
         None => return Err(Box::from(ADAPTER_ERROR.to_string())),

components/canvas/Cargo.toml

@@ -6,9 +6,11 @@ license.workspace = true
 edition.workspace = true
 publish.workspace = true
 rust-version.workspace = true
+repository.workspace = true
+description.workspace = true
 
 [lib]
-name = "canvas"
+name = "servo_canvas"
 path = "lib.rs"
 
 [features]
@@ -16,23 +18,23 @@ tracing = ["dep:tracing"]
 vello = ["dep:vello", "dep:pollster", "dep:futures-intrusive"]
 
 [dependencies]
-base = { workspace = true }
 bytemuck = { workspace = true, features = ["extern_crate_alloc"] }
-canvas_traits = { workspace = true }
 crossbeam-channel = { workspace = true }
 euclid = { workspace = true }
-fonts = { package = "servo-fonts", path = "../fonts" }
+fonts = { workspace = true }
 futures-intrusive = { version = "0.5", optional = true }
 kurbo = { workspace = true }
 log = { workspace = true }
 paint_api = { workspace = true }
 peniko = { workspace = true }
-pixels = { package = "servo-pixels", path = "../pixels" }
-profile_traits = { workspace = true }
+pixels = { workspace = true }
 pollster = { version = "0.4", optional = true }
+profile_traits = { workspace = true }
 rustc-hash = { workspace = true }
+servo-base = { workspace = true }
+servo-canvas-traits = { workspace = true }
+servo-config = { workspace = true }
 servo-tracing = { workspace = true }
-servo_config = { package = "servo-config", path = "../config" }
 stylo = { workspace = true }
 tracing = { workspace = true, optional = true }
 vello = { workspace = true, optional = true }

components/canvas/backend.rs

@@ -2,12 +2,12 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
-use canvas_traits::canvas::{
-    CompositionOptions, FillOrStrokeStyle, FillRule, LineOptions, Path, ShadowOptions, TextRun,
-};
 use euclid::default::{Point2D, Rect, Size2D, Transform2D};
 use paint_api::SerializableImageData;
 use pixels::Snapshot;
+use servo_canvas_traits::canvas::{
+    CompositionOptions, FillOrStrokeStyle, FillRule, LineOptions, Path, ShadowOptions, TextRun,
+};
 use webrender_api::ImageDescriptor;
 
 use crate::canvas_data::Filter;

components/canvas/canvas_data.rs

@@ -2,11 +2,11 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
-use base::Epoch;
-use canvas_traits::canvas::*;
 use euclid::default::{Point2D, Rect, Size2D, Transform2D};
 use paint_api::CrossProcessPaintApi;
 use pixels::Snapshot;
+use servo_base::Epoch;
+use servo_canvas_traits::canvas::*;
 use webrender_api::ImageKey;
 
 use crate::backend::GenericDrawTarget;
@@ -318,7 +318,7 @@ impl<DrawTarget: GenericDrawTarget> CanvasData<DrawTarget> {
 
         let (descriptor, data) = {
             let _span =
-                profile_traits::trace_span!("image_descriptor_and_serializable_data",).entered();
+                profile_traits::trace_span!("image_descriptor_and_serializable_data").entered();
             self.draw_target.image_descriptor_and_serializable_data()
         };
 

components/canvas/canvas_paint_thread.rs

@@ -5,16 +5,16 @@
 use std::borrow::ToOwned;
 use std::{f32, thread};
 
-use base::generic_channel::GenericSender;
-use base::{Epoch, generic_channel};
-use canvas_traits::ConstellationCanvasMsg;
-use canvas_traits::canvas::*;
 use crossbeam_channel::{Sender, select, unbounded};
 use euclid::default::{Rect, Size2D, Transform2D};
 use log::warn;
 use paint_api::CrossProcessPaintApi;
 use pixels::Snapshot;
 use rustc_hash::FxHashMap;
+use servo_base::generic_channel::GenericSender;
+use servo_base::{Epoch, generic_channel};
+use servo_canvas_traits::ConstellationCanvasMsg;
+use servo_canvas_traits::canvas::*;
 use webrender_api::ImageKey;
 
 use crate::canvas_data::*;
@@ -30,7 +30,7 @@ impl CanvasPaintThread {
         CanvasPaintThread {
             canvases: FxHashMap::default(),
             next_canvas_id: CanvasId(0),
-            paint_api: paint_api.clone(),
+            paint_api,
         }
     }
 

components/canvas/peniko_conversions.rs

@@ -2,9 +2,9 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
-use canvas_traits::canvas::*;
 use peniko::ImageAlphaType;
 use pixels::{Alpha, SnapshotPixelFormat};
+use servo_canvas_traits::canvas::*;
 use style::color::AbsoluteColor;
 
 use crate::backend::Convert;
@@ -144,7 +144,7 @@ impl Convert<ImageAlphaType> for Alpha {
 
 impl Convert<peniko::Brush> for FillOrStrokeStyle {
     fn convert(self) -> peniko::Brush {
-        use canvas_traits::canvas::FillOrStrokeStyle::*;
+        use servo_canvas_traits::canvas::FillOrStrokeStyle::*;
         match self {
             Color(absolute_color) => peniko::Brush::Solid(absolute_color.convert()),
             LinearGradient(style) => {

components/canvas/vello_backend.rs

@@ -16,16 +16,16 @@ use std::collections::HashMap;
 use std::num::NonZeroUsize;
 use std::rc::Rc;
 
-use base::generic_channel::GenericSharedMemory;
-use canvas_traits::canvas::{
-    CompositionOptions, CompositionOrBlending, CompositionStyle, FillOrStrokeStyle, FillRule,
-    LineOptions, Path, ShadowOptions, TextRun,
-};
 use euclid::default::{Point2D, Rect, Size2D, Transform2D};
 use fonts::FontIdentifier;
 use kurbo::Shape as _;
 use paint_api::SerializableImageData;
 use pixels::{Snapshot, SnapshotAlphaMode, SnapshotPixelFormat};
+use servo_base::generic_channel::GenericSharedMemory;
+use servo_canvas_traits::canvas::{
+    CompositionOptions, CompositionOrBlending, CompositionStyle, FillOrStrokeStyle, FillRule,
+    LineOptions, Path, ShadowOptions, TextRun,
+};
 use vello::wgpu::{
     BackendOptions, Backends, Buffer, BufferDescriptor, BufferUsages, COPY_BYTES_PER_ROW_ALIGNMENT,
     CommandEncoderDescriptor, Device, Extent3d, Instance, InstanceDescriptor, InstanceFlags,

components/canvas/vello_cpu_backend.rs

@@ -6,16 +6,16 @@ use std::cell::RefCell;
 use std::collections::HashMap;
 use std::sync::Arc;
 
-use base::generic_channel::GenericSharedMemory;
-use canvas_traits::canvas::{
-    CompositionOptions, CompositionOrBlending, CompositionStyle, FillOrStrokeStyle, FillRule,
-    LineOptions, Path, ShadowOptions, TextRun,
-};
 use euclid::default::{Point2D, Rect, Size2D, Transform2D};
 use fonts::FontIdentifier;
 use kurbo::Shape;
 use paint_api::SerializableImageData;
 use pixels::{Snapshot, SnapshotAlphaMode, SnapshotPixelFormat};
+use servo_base::generic_channel::GenericSharedMemory;
+use servo_canvas_traits::canvas::{
+    CompositionOptions, CompositionOrBlending, CompositionStyle, FillOrStrokeStyle, FillRule,
+    LineOptions, Path, ShadowOptions, TextRun,
+};
 use vello_cpu::{kurbo, peniko};
 use webrender_api::{ImageDescriptor, ImageDescriptorFlags};
 
@@ -511,7 +511,7 @@ fn snapshot_as_pixmap(mut snapshot: Snapshot) -> Arc<vello_cpu::Pixmap> {
 
 impl Convert<vello_cpu::PaintType> for FillOrStrokeStyle {
     fn convert(self) -> vello_cpu::PaintType {
-        use canvas_traits::canvas::FillOrStrokeStyle::*;
+        use servo_canvas_traits::canvas::FillOrStrokeStyle::*;
         match self {
             Color(absolute_color) => vello_cpu::PaintType::Solid(absolute_color.convert()),
             LinearGradient(style) => {

components/config/Cargo.toml

@@ -6,6 +6,8 @@ license.workspace = true
 edition.workspace = true
 publish.workspace = true
 rust-version.workspace = true
+repository.workspace = true
+description.workspace = true
 
 [lib]
 name = "servo_config"
@@ -14,6 +16,5 @@ path = "lib.rs"
 [dependencies]
 serde = { workspace = true, features = ["derive"] }
 serde_json = { workspace = true }
-servo_config_macro = { package = "servo-config-macro", path = "macro" }
-servo_url = { package = "servo-url", path = "../url" }
+servo-config-macro = { workspace = true }
 stylo_static_prefs = { workspace = true }

components/config/lib.rs

@@ -2,6 +2,12 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
+//! This crate provides two mechanisms for configuring the behaviour of the Servo engine.
+//!  - The [`opts`] module exposes a set of global flags that are initialized once
+//!    and cannot be changed at runtime.
+//!  - The [`prefs`] module provides a mechanism to get and set global preference
+//!    values that can be changed at runtime.
+
 #![deny(unsafe_code)]
 
 pub mod opts;

components/config/macro/Cargo.toml

@@ -6,6 +6,8 @@ license.workspace = true
 edition.workspace = true
 publish.workspace = true
 rust-version.workspace = true
+repository.workspace = true
+description.workspace = true
 
 [lib]
 name = "servo_config_macro"

components/config/opts.rs

@@ -2,8 +2,8 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
-//! Configuration options for a single run of the servo application. Created
-//! from command line arguments.
+//! Options are global configuration options that are initialized once and cannot be changed at
+//! runtime.
 
 use std::default::Default;
 use std::path::PathBuf;
@@ -11,28 +11,21 @@ use std::process;
 use std::sync::OnceLock;
 
 use serde::{Deserialize, Serialize};
-use servo_url::ServoUrl;
 
-/// Global flags for Servo, currently set on the command line.
+/// The set of global options supported by Servo. The values for these can be configured during
+/// initialization of Servo and cannot be changed later at runtime.
 #[derive(Clone, Debug, Deserialize, Serialize)]
 pub struct Opts {
-    /// `None` to disable the time profiler or `Some` to enable it with:
+    /// `None` to disable the time profiler or `Some` to enable it with either:
     ///
     ///  - an interval in seconds to cause it to produce output on that interval.
-    ///    (`i.e. -p 5`).
     ///  - a file path to write profiling info to a TSV file upon Servo's termination.
-    ///    (`i.e. -p out.tsv`).
     pub time_profiling: Option<OutputOptions>,
 
     /// When the profiler is enabled, this is an optional path to dump a self-contained HTML file
     /// visualizing the traces as a timeline.
     pub time_profiler_trace_path: Option<String>,
 
-    /// True to turn off incremental layout.
-    pub nonincremental_layout: bool,
-
-    pub user_stylesheets: Vec<(Vec<u8>, ServoUrl)>,
-
     /// True to exit on thread failure instead of displaying about:failure.
     pub hard_fail: bool,
 
@@ -83,15 +76,12 @@ pub struct Opts {
 
     /// Unminify Css.
     pub unminify_css: bool,
-
-    /// Print Progressive Web Metrics to console.
-    pub print_pwm: bool,
 }
 
-/// Debug options for Servo, currently set on the command line with -Z
+/// Debug options for Servo.
 #[derive(Clone, Debug, Default, Deserialize, Serialize)]
 pub struct DiagnosticsLogging {
-    /// List all the debug options.
+    /// Print all the debug options supported by Servo to the standard output.
     pub help: bool,
 
     /// Print the DOM after each restyle.
@@ -127,6 +117,9 @@ pub struct DiagnosticsLogging {
 
     /// Log garbage collection passes and their durations.
     pub gc_profile: bool,
+
+    /// Log Progressive Web Metrics.
+    pub progressive_web_metrics: bool,
 }
 
 impl DiagnosticsLogging {
@@ -174,6 +167,7 @@ impl DiagnosticsLogging {
         print_option("relayout-event", "Log when relayout occurs");
         print_option("profile-script-events", "Log script event processing time");
         print_option("gc-profile", "Log garbage collection statistics");
+        print_option("progressive-web-metrics", "Log Progressive Web Metrics");
         println!();
 
         process::exit(0);
@@ -197,6 +191,7 @@ impl DiagnosticsLogging {
                 "gc-profile" => self.gc_profile = true,
                 "profile-script-events" => self.profile_script_events = true,
                 "relayout-event" => self.relayout_event = true,
+                "progressive-web-metrics" => self.progressive_web_metrics = true,
                 "" => {},
                 _ => return Err(format!("Unknown diagnostic option: {option}")),
             };
@@ -206,9 +201,9 @@ impl DiagnosticsLogging {
     }
 }
 
+/// The destination for the time profiler reports.
 #[derive(Clone, Debug, Deserialize, PartialEq, Serialize)]
 pub enum OutputOptions {
-    /// Database connection config (hostname, name, user, pass)
     FileName(String),
     Stdout(f64),
 }
@@ -218,8 +213,6 @@ impl Default for Opts {
         Self {
             time_profiling: None,
             time_profiler_trace_path: None,
-            nonincremental_layout: false,
-            user_stylesheets: Vec::new(),
             hard_fail: true,
             multiprocess: false,
             force_ipc: false,
@@ -235,7 +228,6 @@ impl Default for Opts {
             unminify_js: false,
             local_script_source: None,
             unminify_css: false,
-            print_pwm: false,
         }
     }
 }
@@ -248,16 +240,16 @@ static OPTIONS: OnceLock<Opts> = OnceLock::new();
 /// Initialize options.
 ///
 /// Should only be called once at process startup.
-/// Must be called before the first call to [get].
+/// Must be called before the first call to [`get`].
 pub fn initialize_options(opts: Opts) {
     OPTIONS.set(opts).expect("Already initialized");
 }
 
 /// Get the servo options
 ///
-/// If the servo options have not been initialized by calling [initialize_options], then the
-/// options will be initialized to default values. Outside of tests the options should
-/// be explicitly initialized.
+/// If the servo options have not been initialized by calling [`initialize_options`], then the
+/// options will be initialized to default values. Outside of tests the options should be
+/// explicitly initialized.
 #[inline]
 pub fn get() -> &'static Opts {
     // In unit-tests using default options reduces boilerplate.

components/config/pref_util.rs

@@ -5,6 +5,7 @@
 use serde::{Deserialize, Serialize};
 use serde_json::Value;
 
+/// The types of preference values in Servo.
 #[derive(Clone, Debug, Deserialize, PartialEq, Serialize)]
 pub enum PrefValue {
     Float(f64),
@@ -16,6 +17,8 @@ pub enum PrefValue {
 }
 
 impl PrefValue {
+    /// Parse the `input` string as a preference value. Defaults to a `PrefValue::Str` if the input
+    /// cannot be parsed as valid value of one of the other types.
     pub fn from_booleanish_str(input: &str) -> Self {
         match input {
             "false" => PrefValue::Bool(false),
@@ -95,11 +98,23 @@ impl_pref_from! {
 impl_from_pref! {
     PrefValue::Float => f64,
     PrefValue::Int => i64,
-    PrefValue::UInt => u64,
     PrefValue::Str => String,
     PrefValue::Bool => bool,
 }
 
+// The default generated from `impl_from_pref` would cause panic
+// when converting from PrefValue::Int.
+impl TryFrom<PrefValue> for u64 {
+    type Error = String;
+    fn try_from(other: PrefValue) -> Result<Self, Self::Error> {
+        match other {
+            PrefValue::UInt(value) => Ok(value),
+            PrefValue::Int(value) if value >= 0 => Ok(value as u64),
+            _ => Err(format!("Cannot convert {other:?} to u64")),
+        }
+    }
+}
+
 impl From<[f64; 4]> for PrefValue {
     fn from(other: [f64; 4]) -> PrefValue {
         PrefValue::Array(IntoIterator::into_iter(other).map(|v| v.into()).collect())

components/config/prefs.rs

@@ -2,8 +2,11 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
+//! Preferences are the global configuration options that can be changed at runtime.
+
 use std::env::consts::ARCH;
 use std::sync::{RwLock, RwLockReadGuard};
+use std::time::Duration;
 
 use serde::{Deserialize, Serialize};
 use servo_config_macro::ServoPreferences;
@@ -12,7 +15,12 @@ pub use crate::pref_util::PrefValue;
 
 static PREFERENCES: RwLock<Preferences> = RwLock::new(Preferences::const_default());
 
+/// A trait to be implemented by components that wish to be notified about runtime changes to the
+/// global preferences for the current process.
 pub trait PreferencesObserver: Send + Sync {
+    /// This method is called when the global preferences have been updated. The argument to the
+    /// method is an array of tuples where the first component is the name of the preference and
+    /// the second component is the new value of the preference.
     fn prefs_changed(&self, _changes: &[(&'static str, PrefValue)]) {}
 }
 
@@ -24,38 +32,36 @@ pub fn get() -> RwLockReadGuard<'static, Preferences> {
     PREFERENCES.read().unwrap()
 }
 
+/// Subscribe to notifications about changes to the global preferences for the current process.
 pub fn add_observer(observer: Box<dyn PreferencesObserver>) {
     OBSERVERS.write().unwrap().push(observer);
 }
 
+/// Update the values of the global preferences for the current process. This also notifies the
+/// observers previously added using [`add_observer`].
 pub fn set(preferences: Preferences) {
     // Map between Stylo preference names and Servo preference names as the This should be
     // kept in sync with components/script/dom/bindings/codegen/run.py which generates the
     // DOM CSS style accessors.
-    stylo_static_prefs::set_bool("layout.unimplemented", preferences.layout_unimplemented);
-    stylo_static_prefs::set_i32("layout.threads", preferences.layout_threads as i32);
-    stylo_static_prefs::set_bool("layout.flexbox.enabled", preferences.layout_flexbox_enabled);
-    stylo_static_prefs::set_bool("layout.columns.enabled", preferences.layout_columns_enabled);
-    stylo_static_prefs::set_bool("layout.grid.enabled", preferences.layout_grid_enabled);
-    stylo_static_prefs::set_bool(
+    stylo_static_prefs::set_pref!("layout.unimplemented", preferences.layout_unimplemented);
+    stylo_static_prefs::set_pref!("layout.threads", preferences.layout_threads as i32);
+    stylo_static_prefs::set_pref!("layout.columns.enabled", preferences.layout_columns_enabled);
+    stylo_static_prefs::set_pref!("layout.grid.enabled", preferences.layout_grid_enabled);
+    stylo_static_prefs::set_pref!(
         "layout.css.attr.enabled",
-        preferences.layout_css_attr_enabled,
+        preferences.layout_css_attr_enabled
     );
-    stylo_static_prefs::set_bool(
-        "layout.css.transition-behavior.enabled",
-        preferences.layout_css_transition_behavior_enabled,
-    );
-    stylo_static_prefs::set_bool(
+    stylo_static_prefs::set_pref!(
         "layout.writing-mode.enabled",
-        preferences.layout_writing_mode_enabled,
+        preferences.layout_writing_mode_enabled
     );
-    stylo_static_prefs::set_bool(
+    stylo_static_prefs::set_pref!(
         "layout.container-queries.enabled",
-        preferences.layout_container_queries_enabled,
+        preferences.layout_container_queries_enabled
     );
-    stylo_static_prefs::set_bool(
+    stylo_static_prefs::set_pref!(
         "layout.variable_fonts.enabled",
-        preferences.layout_variable_fonts_enabled,
+        preferences.layout_variable_fonts_enabled
     );
 
     let changed = preferences.diff(&PREFERENCES.read().unwrap());
@@ -76,6 +82,16 @@ macro_rules! pref {
     };
 }
 
+/// The set of global preferences supported by Servo.
+///
+/// Each preference has a default value that determines its initial state. These defaults
+/// fall into roughly three categories:
+/// - **Stable**: enabled by default.
+/// - **Experimental**: disabled by default, but intended to be enabled for experimental use.
+/// - **Unstable**: disabled by default.
+///
+/// For a full overview of which preferences are experimental, see the
+/// [experimental features documentation](https://book.servo.org/design-documentation/experimental-features.html).
 #[derive(Clone, Deserialize, Serialize, ServoPreferences)]
 pub struct Preferences {
     pub fonts_default: String,
@@ -84,6 +100,9 @@ pub struct Preferences {
     pub fonts_monospace: String,
     pub fonts_default_size: i64,
     pub fonts_default_monospace_size: i64,
+    /// The amount of time that a half cycle of a text caret blink takes in milliseconds.
+    /// If this value is less than or equal to zero, then caret blink is disabled.
+    pub editing_caret_blink_time: i64,
     pub css_animations_testing_enabled: bool,
     /// Start the devtools server at startup
     pub devtools_server_enabled: bool,
@@ -97,6 +116,7 @@ pub struct Preferences {
     pub dom_abort_controller_enabled: bool,
     // feature: Adopted Stylesheet | #38132 | Web/API/Document/adoptedStyleSheets
     pub dom_adoptedstylesheet_enabled: bool,
+    pub dom_allow_preloading_module_descendants: bool,
     // feature: Clipboard API | #36084 | Web/API/Clipboard_API
     pub dom_async_clipboard_enabled: bool,
     pub dom_bluetooth_enabled: bool,
@@ -113,7 +133,6 @@ pub struct Preferences {
     /// - vello_cpu
     pub dom_canvas_backend: String,
     pub dom_clipboardevent_enabled: bool,
-    pub dom_command_invokers_enabled: bool,
     pub dom_composition_event_enabled: bool,
     // feature: CookieStore | #37674 | Web/API/CookieStore
     pub dom_cookiestore_enabled: bool,
@@ -132,6 +151,8 @@ pub struct Preferences {
     pub dom_gamepad_enabled: bool,
     // feature: Geolocation API | #38903 | Web/API/Geolocation_API
     pub dom_geolocation_enabled: bool,
+    // feature: Screen Wake Lock API | #43615 | Web/API/Screen_Wake_Lock_API
+    pub dom_wakelock_enabled: bool,
     // feature: IndexedDB | #6963 | Web/API/IndexedDB_API
     pub dom_indexeddb_enabled: bool,
     // feature: IntersectionObserver | #35767 | Web/API/Intersection_Observer_API
@@ -152,10 +173,16 @@ pub struct Preferences {
     pub dom_permissions_testing_allowed_in_nonsecure_contexts: bool,
     // feature: ResizeObserver | #39790 | Web/API/ResizeObserver
     pub dom_resize_observer_enabled: bool,
+    // feature: Sanitizer API | #43948 | Web/API/HTML_Sanitizer_API
+    pub dom_sanitizer_enabled: bool,
     pub dom_script_asynch: bool,
+    // feature: Storage API | #43976 | Web/API/Storage_API
+    pub dom_storage_manager_api_enabled: bool,
     // feature: ServiceWorker | #36538 | Web/API/Service_Worker_API
     pub dom_serviceworker_enabled: bool,
     pub dom_serviceworker_timeout_seconds: i64,
+    // feature: SharedWorker | #7458 | Web/API/SharedWorker
+    pub dom_sharedworker_enabled: bool,
     pub dom_servo_helpers_enabled: bool,
     pub dom_servoparser_async_html_tokenizer_enabled: bool,
     pub dom_testbinding_enabled: bool,
@@ -258,9 +285,6 @@ pub struct Preferences {
     pub layout_grid_enabled: bool,
     pub layout_container_queries_enabled: bool,
     pub layout_css_attr_enabled: bool,
-    pub layout_css_transition_behavior_enabled: bool,
-    // feature: CSS Flexbox | #12453 | Web/CSS/Guides/Flexible_box_layout
-    pub layout_flexbox_enabled: bool,
     pub layout_style_sharing_cache_enabled: bool,
     pub layout_threads: i64,
     pub layout_unimplemented: bool,
@@ -332,10 +356,12 @@ impl Preferences {
     const fn const_default() -> Self {
         Self {
             css_animations_testing_enabled: false,
+            editing_caret_blink_time: 600,
             devtools_server_enabled: false,
             devtools_server_listen_address: String::new(),
             dom_abort_controller_enabled: true,
             dom_adoptedstylesheet_enabled: false,
+            dom_allow_preloading_module_descendants: false,
             dom_allow_scripts_to_close_windows: false,
             dom_async_clipboard_enabled: false,
             dom_bluetooth_enabled: false,
@@ -344,7 +370,6 @@ impl Preferences {
             dom_canvas_text_enabled: true,
             dom_canvas_backend: String::new(),
             dom_clipboardevent_enabled: true,
-            dom_command_invokers_enabled: false,
             dom_composition_event_enabled: false,
             dom_cookiestore_enabled: false,
             dom_credential_management_enabled: false,
@@ -356,6 +381,7 @@ impl Preferences {
             dom_fullscreen_test: false,
             dom_gamepad_enabled: true,
             dom_geolocation_enabled: false,
+            dom_wakelock_enabled: false,
             dom_indexeddb_enabled: false,
             dom_intersection_observer_enabled: false,
             dom_microdata_testing_enabled: false,
@@ -368,9 +394,12 @@ impl Preferences {
             dom_permissions_enabled: false,
             dom_permissions_testing_allowed_in_nonsecure_contexts: false,
             dom_resize_observer_enabled: true,
+            dom_sanitizer_enabled: false,
             dom_script_asynch: true,
+            dom_storage_manager_api_enabled: false,
             dom_serviceworker_enabled: false,
             dom_serviceworker_timeout_seconds: 60,
+            dom_sharedworker_enabled: false,
             dom_servo_helpers_enabled: false,
             dom_servoparser_async_html_tokenizer_enabled: false,
             dom_testbinding_enabled: false,
@@ -457,8 +486,6 @@ impl Preferences {
             layout_columns_enabled: false,
             layout_container_queries_enabled: false,
             layout_css_attr_enabled: false,
-            layout_css_transition_behavior_enabled: true,
-            layout_flexbox_enabled: true,
             layout_grid_enabled: false,
             layout_style_sharing_cache_enabled: true,
             // TODO(mrobinson): This should likely be based on the number of processors.
@@ -493,6 +520,16 @@ impl Preferences {
             log_filter: String::new(),
         }
     }
+
+    /// The amount of time that a half cycle of a text caret blink takes. If blinking is disabled
+    /// this returns `None`.
+    pub fn editing_caret_blink_time(&self) -> Option<Duration> {
+        if self.editing_caret_blink_time > 0 {
+            Some(Duration::from_millis(self.editing_caret_blink_time as u64))
+        } else {
+            None
+        }
+    }
 }
 
 impl Default for Preferences {

components/constellation/Cargo.toml

@@ -6,64 +6,66 @@ license.workspace = true
 edition.workspace = true
 publish.workspace = true
 rust-version.workspace = true
+repository.workspace = true
+description.workspace = true
 
 [lib]
-name = "constellation"
+name = "servo_constellation"
 path = "lib.rs"
 
 [features]
 default = []
-bluetooth = ["bluetooth_traits"]
+bluetooth = ["servo-bluetooth-traits"]
 gamepad = ["embedder_traits/gamepad"]
-tracing = ["dep:tracing", "canvas/tracing"]
-vello = ["canvas/vello"]
-webgpu = ["script_traits/webgpu"]
+tracing = ["dep:tracing", "servo-canvas/tracing"]
+vello = ["servo-canvas/vello"]
+webgpu = ["dep:webgpu", "dep:webgpu_traits", "script_traits/webgpu"]
 
 [lints.clippy]
 unwrap_used = "deny"
 panic = "deny"
 
 [dependencies]
-background_hang_monitor = { package = "servo-background-hang-monitor", path = "../background_hang_monitor" }
-background_hang_monitor_api = { workspace = true }
+accesskit = { workspace = true }
 backtrace = { workspace = true }
-base = { workspace = true }
-bluetooth_traits = { workspace = true, optional = true }
-canvas = { package = "servo-canvas", path = "../canvas" }
-canvas_traits = { workspace = true }
-constellation_traits = { workspace = true }
+base64 = { workspace = true }
 content-security-policy = { workspace = true }
 crossbeam-channel = { workspace = true }
 devtools_traits = { workspace = true }
 embedder_traits = { workspace = true }
 euclid = { workspace = true }
-fonts = { package = "servo-fonts", path = "../fonts" }
+fonts = { workspace = true }
 ipc-channel = { workspace = true }
 keyboard-types = { workspace = true }
 layout_api = { workspace = true }
 log = { workspace = true }
-media = { package = "servo-media-thread", path = "../media/media-thread" }
-net = { package = "servo-net", path = "../net" }
+media = { workspace = true }
+net = { workspace = true }
 net_traits = { workspace = true }
 paint_api = { workspace = true }
 parking_lot = { workspace = true }
-profile = { package = "servo-profile", path = "../profile" }
 profile_traits = { workspace = true }
 rand = { workspace = true }
 rustc-hash = { workspace = true }
 script_traits = { workspace = true }
 serde = { workspace = true }
+servo-background-hang-monitor = { workspace = true }
+servo-background-hang-monitor-api = { workspace = true }
+servo-base = { workspace = true }
+servo-bluetooth-traits = { workspace = true, optional = true }
+servo-canvas = { workspace = true }
+servo-canvas-traits = { workspace = true }
+servo-config = { workspace = true }
+servo-constellation-traits = { workspace = true }
 servo-tracing = { workspace = true }
-servo_config = { package = "servo-config", path = "../config" }
-servo_url = { package = "servo-url", path = "../url" }
+servo-url = { workspace = true }
+servo-wakelock = { workspace = true }
 storage_traits = { workspace = true }
 stylo = { workspace = true }
 stylo_traits = { workspace = true }
 tracing = { workspace = true, optional = true }
-webgpu = { package = "servo-webgpu", path = "../webgpu" }
-webgpu_traits = { workspace = true }
-webrender = { workspace = true }
-webrender_api = { workspace = true }
+webgpu = { workspace = true, optional = true }
+webgpu_traits = { workspace = true, optional = true }
 webxr-api = { workspace = true }
 
 [target.'cfg(any(target_os="macos", all(not(target_os = "windows"), not(target_os = "ios"), not(target_os="android"), not(target_env="ohos"), not(target_arch="arm"), not(target_arch="aarch64"))))'.dependencies]

components/constellation/broadcastchannel.rs

@@ -4,11 +4,11 @@
 
 use std::collections::HashMap;
 
-use base::id::BroadcastChannelRouterId;
-use constellation_traits::BroadcastChannelMsg;
 use ipc_channel::ipc::IpcSender;
 use log::warn;
 use rustc_hash::FxHashMap;
+use servo_base::id::BroadcastChannelRouterId;
+use servo_constellation_traits::BroadcastChannelMsg;
 use servo_url::ImmutableOrigin;
 
 #[derive(Default)]

components/constellation/browsingcontext.rs

@@ -2,10 +2,10 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
-use base::id::{BrowsingContextGroupId, BrowsingContextId, PipelineId, WebViewId};
 use embedder_traits::ViewportDetails;
 use log::warn;
 use rustc_hash::{FxHashMap, FxHashSet};
+use servo_base::id::{BrowsingContextGroupId, BrowsingContextId, PipelineId, WebViewId};
 
 use crate::pipeline::Pipeline;
 

components/constellation/constellation_webview.rs

@@ -2,13 +2,14 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
-use base::id::{BrowsingContextId, PipelineId, WebViewId};
 use embedder_traits::user_contents::UserContentManagerId;
 use embedder_traits::{InputEvent, MouseLeftViewportEvent, Theme};
 use euclid::Point2D;
 use log::warn;
 use rustc_hash::FxHashMap;
 use script_traits::{ConstellationInputEvent, ScriptThreadMessage};
+use servo_base::Epoch;
+use servo_base::id::{BrowsingContextId, PipelineId, WebViewId};
 use style_traits::CSSPixel;
 
 use crate::browsingcontext::BrowsingContext;
@@ -21,6 +22,11 @@ pub(crate) struct ConstellationWebView {
     /// The [`WebViewId`] of this [`ConstellationWebView`].
     webview_id: WebViewId,
 
+    /// The [`PipelineId`] of the currently active pipeline at the top level of this WebView.
+    pub active_top_level_pipeline_id: Option<PipelineId>,
+    /// A counter for changes to [`Self::active_top_level_pipeline_id`].
+    pub active_top_level_pipeline_epoch: Epoch,
+
     /// The currently focused browsing context in this webview for key events.
     /// The focused pipeline is the current entry of the focused browsing
     /// context.
@@ -45,6 +51,14 @@ pub(crate) struct ConstellationWebView {
     /// The [`Theme`] that this [`ConstellationWebView`] uses. This is communicated to all
     /// `ScriptThread`s so that they know how to render the contents of a particular `WebView.
     theme: Theme,
+
+    /// Whether accessibility is active for this webview.
+    ///
+    /// Set by [`crate::Constellation::set_accessibility_active()`], and forwarded to the
+    /// webview’s *active* pipelines (of those that represent documents) at any given moment
+    /// via [`ScriptThreadMessage::SetAccessibilityActive`] in `set_accessibility_active()`
+    /// and [`crate::Constellation::set_frame_tree_for_webview()`].
+    pub accessibility_active: bool,
 }
 
 impl ConstellationWebView {
@@ -56,11 +70,14 @@ impl ConstellationWebView {
         Self {
             webview_id,
             user_content_manager_id,
+            active_top_level_pipeline_id: None,
+            active_top_level_pipeline_epoch: Epoch::default(),
             focused_browsing_context_id,
             hovered_browsing_context_id: None,
             last_mouse_move_point: Default::default(),
             session_history: JointSessionHistory::new(),
             theme: Theme::Light,
+            accessibility_active: false,
         }
     }
 

components/constellation/embedder.rs

@@ -0,0 +1,50 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
+
+use embedder_traits::{
+    InputEventOutcome, JSValue, JavaScriptEvaluationError, JavaScriptEvaluationId,
+    MediaSessionEvent, NewWebViewDetails, TraversalId,
+};
+use servo_base::generic_channel::GenericSender;
+use servo_base::id::{PipelineId, WebViewId};
+use servo_url::ServoUrl;
+
+/// Messages sent from the `Constellation` to the embedder.
+pub enum ConstellationToEmbedderMsg {
+    /// Informs the embedder that the constellation has completed shutdown.
+    /// Required because the constellation can have pending calls to make
+    /// (e.g. SetFrameTree) at the time that we send it an ExitMsg.
+    ShutdownComplete,
+    /// Report a complete sampled profile
+    ReportProfile(Vec<u8>),
+    /// All webviews lost focus for keyboard events.
+    WebViewBlurred,
+    /// A history traversal operation completed.
+    HistoryTraversalComplete(WebViewId, TraversalId),
+    /// Notifies the embedder about media session events
+    /// (i.e. when there is metadata for the active media session, playback state changes...).
+    MediaSessionEvent(WebViewId, MediaSessionEvent),
+    /// A pipeline panicked. First string is the reason, second one is the backtrace.
+    Panic(WebViewId, String, Option<String>),
+    /// A webview potentially gained focus for keyboard events.
+    /// If the boolean value is false, the webiew could not be focused.
+    WebViewFocused(WebViewId, bool),
+    /// Inform the embedding layer that a particular `InputEvent` was handled by Servo
+    /// and the embedder can continue processing it, if necessary.
+    InputEventsHandled(WebViewId, Vec<InputEventOutcome>),
+    /// A webview was destroyed.
+    WebViewClosed(WebViewId),
+    /// Inform the embedding layer that a JavaScript evaluation has
+    /// finished with the given result.
+    FinishJavaScriptEvaluation(
+        JavaScriptEvaluationId,
+        Result<JSValue, JavaScriptEvaluationError>,
+    ),
+    /// Whether or not to allow script to open a new tab/browser
+    AllowOpeningWebView(WebViewId, GenericSender<Option<NewWebViewDetails>>),
+    /// Whether or not to allow a pipeline to load a url.
+    AllowNavigationRequest(WebViewId, PipelineId, ServoUrl),
+    /// The history state has changed.
+    HistoryChanged(WebViewId, Vec<ServoUrl>, usize),
+}

components/constellation/event_loop.rs

@@ -11,9 +11,6 @@ use std::marker::PhantomData;
 use std::rc::Rc;
 
 use background_hang_monitor_api::{BackgroundHangMonitorControlMsg, HangMonitorAlert};
-use base::generic_channel::{self, GenericReceiver, GenericSender, SendError};
-use base::id::ScriptEventLoopId;
-use constellation_traits::ServiceWorkerManagerFactory;
 use embedder_traits::ScriptToEmbedderChan;
 use ipc_channel::IpcError;
 use layout_api::ScriptThreadFactory;
@@ -21,8 +18,11 @@ use log::error;
 use media::WindowGLContext;
 use script_traits::{InitialScriptState, ScriptThreadMessage};
 use serde::{Deserialize, Serialize};
+use servo_base::generic_channel::{self, GenericReceiver, GenericSender, SendError};
+use servo_base::id::ScriptEventLoopId;
 use servo_config::opts::{self, Opts};
 use servo_config::prefs::{self, Preferences};
+use servo_constellation_traits::ServiceWorkerManagerFactory;
 
 use crate::sandboxing::spawn_multiprocess;
 use crate::{Constellation, UnprivilegedContent};
@@ -68,7 +68,7 @@ impl EventLoop {
         is_private: bool,
     ) -> Result<Rc<Self>, IpcError> {
         let (script_chan, script_port) =
-            base::generic_channel::channel().expect("Pipeline script chan");
+            servo_base::generic_channel::channel().expect("Pipeline script chan");
 
         let embedder_chan = constellation.embedder_proxy.sender.clone();
         let eventloop_waker = constellation.embedder_proxy.event_loop_waker.clone();
@@ -111,7 +111,6 @@ impl EventLoop {
             player_context: WindowGLContext::get(),
             privileged_urls: constellation.privileged_urls.clone(),
             user_contents_for_manager_id: constellation.user_contents_for_manager_id.clone(),
-            accessibility_active: constellation.accessibility_active,
         };
 
         let event_loop = if opts::get().multiprocess {

components/constellation/lib.rs

@@ -11,6 +11,7 @@ mod broadcastchannel;
 mod browsingcontext;
 mod constellation;
 mod constellation_webview;
+mod embedder;
 mod event_loop;
 mod logging;
 mod pipeline;
@@ -20,6 +21,7 @@ mod serviceworker;
 mod session_history;
 
 pub use crate::constellation::{Constellation, InitialConstellationState};
+pub use crate::embedder::ConstellationToEmbedderMsg;
 pub use crate::event_loop::{EventLoop, NewScriptEventLoopProcessInfo};
 pub use crate::logging::{FromEmbedderLogger, FromScriptLogger};
 pub use crate::sandboxing::{UnprivilegedContent, content_process_sandbox_profile};

components/constellation/logging.rs

@@ -11,14 +11,14 @@ use std::sync::Arc;
 use std::thread;
 
 use backtrace::Backtrace;
-use base::id::{ScriptEventLoopId, TEST_PIPELINE_ID, TEST_WEBVIEW_ID};
-use constellation_traits::{
-    EmbedderToConstellationMessage, LogEntry, ScriptToConstellationMessage,
-    ScriptToConstellationSender,
-};
 use crossbeam_channel::Sender;
 use log::{Level, LevelFilter, Log, Metadata, Record};
 use parking_lot::ReentrantMutex;
+use servo_base::id::{ScriptEventLoopId, TEST_PIPELINE_ID, TEST_WEBVIEW_ID};
+use servo_constellation_traits::{
+    EmbedderToConstellationMessage, LogEntry, ScriptToConstellationMessage,
+    ScriptToConstellationSender,
+};
 
 /// A logger directed at the constellation from content processes
 /// #[derive(Clone)]

components/constellation/pipeline.rs

@@ -5,9 +5,6 @@
 use std::collections::HashSet;
 use std::rc::Rc;
 
-use base::generic_channel::SendError;
-use base::id::{BrowsingContextId, HistoryStateId, PipelineId, WebViewId};
-use constellation_traits::{LoadData, ServiceWorkerManagerFactory};
 use embedder_traits::{AnimationState, FocusSequenceNumber};
 use layout_api::ScriptThreadFactory;
 use log::{debug, error, warn};
@@ -15,6 +12,9 @@ use paint_api::{CompositionPipeline, PaintMessage, PaintProxy};
 use script_traits::{
     DiscardBrowsingContext, DocumentActivity, NewPipelineInfo, ScriptThreadMessage,
 };
+use servo_base::generic_channel::SendError;
+use servo_base::id::{BrowsingContextId, HistoryStateId, PipelineId, WebViewId};
+use servo_constellation_traits::{LoadData, ServiceWorkerManagerFactory};
 use servo_url::ServoUrl;
 
 use crate::Constellation;

components/constellation/process_manager.rs

@@ -65,6 +65,7 @@ impl ProcessManager {
         receiver
     }
 
+    #[servo_tracing::instrument(skip_all)]
     pub fn remove(&mut self, index: usize) {
         let (mut process, _) = self.processes.swap_remove(index);
         debug!("Removing process pid={}", process.pid());

components/constellation/serviceworker.rs

@@ -2,13 +2,13 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
-use base::generic_channel::GenericSender;
-use constellation_traits::{SWManagerSenders, ServiceWorkerManagerFactory};
 use ipc_channel::IpcError;
 use serde::{Deserialize, Serialize};
+use servo_base::generic_channel::GenericSender;
 use servo_config::opts::{self, Opts};
 use servo_config::prefs;
 use servo_config::prefs::Preferences;
+use servo_constellation_traits::{SWManagerSenders, ServiceWorkerManagerFactory};
 use servo_url::ImmutableOrigin;
 
 use crate::process_manager::Process;

components/constellation/session_history.rs

@@ -5,10 +5,10 @@
 use std::cmp::PartialEq;
 use std::fmt;
 
-use base::id::{BrowsingContextId, HistoryStateId, PipelineId, WebViewId};
-use constellation_traits::LoadData;
 use embedder_traits::ViewportDetails;
 use log::debug;
+use servo_base::id::{BrowsingContextId, HistoryStateId, PipelineId, WebViewId};
+use servo_constellation_traits::LoadData;
 use servo_url::ServoUrl;
 
 use crate::browsingcontext::NewBrowsingContextInfo;

components/constellation/tracing.rs

@@ -46,7 +46,7 @@ mod from_embedder {
         };
     }
 
-    impl LogTarget for constellation_traits::EmbedderToConstellationMessage {
+    impl LogTarget for servo_constellation_traits::EmbedderToConstellationMessage {
         fn log_target(&self) -> &'static str {
             match self {
                 Self::Exit => target!("Exit"),
@@ -120,7 +120,7 @@ mod from_script {
         };
     }
 
-    impl LogTarget for constellation_traits::ScriptToConstellationMessage {
+    impl LogTarget for servo_constellation_traits::ScriptToConstellationMessage {
         fn log_target(&self) -> &'static str {
             match self {
                 Self::CompleteMessagePortTransfer(..) => target!("CompleteMessagePortTransfer"),
@@ -141,13 +141,18 @@ mod from_script {
                     target!("RemoveBroadcastChannelNameInRouter")
                 },
                 Self::ScheduleBroadcast(..) => target!("ScheduleBroadcast"),
+                Self::RegisterInterest(..) => target!("RegisterInterest"),
+                Self::UnregisterInterest(..) => target!("UnregisterInterest"),
                 Self::BroadcastStorageEvent(..) => target!("BroadcastStorageEvent"),
                 Self::ChangeRunningAnimationsState(..) => target!("ChangeRunningAnimationsState"),
                 Self::CreateCanvasPaintThread(..) => target!("CreateCanvasPaintThread"),
-                Self::Focus(..) => target!("Focus"),
-                Self::FocusRemoteDocument(..) => target!("FocusRemoteDocument"),
+                Self::FocusAncestorBrowsingContextsForFocusingSteps(..) => {
+                    target!("FocusAncestorBrowsingContextsForFocusingSteps")
+                },
+                Self::FocusRemoteBrowsingContext(..) => target!("FocusRemoteBrowsingContext"),
                 Self::GetTopForBrowsingContext(..) => target!("GetTopForBrowsingContext"),
                 Self::GetBrowsingContextInfo(..) => target!("GetBrowsingContextInfo"),
+                Self::GetDocumentOrigin(..) => target!("GetDocumentOrigin"),
                 Self::GetChildBrowsingContextId(..) => target!("GetChildBrowsingContextId"),
                 Self::LoadComplete => target!("LoadComplete"),
                 Self::LoadUrl(..) => target!("LoadUrl"),
@@ -186,6 +191,8 @@ mod from_script {
                     target!("RespondToScreenshotReadinessRequest")
                 },
                 Self::TriggerGarbageCollection => target!("TriggerGarbageCollection"),
+                Self::AcquireWakeLock(..) => target!("AcquireWakeLock"),
+                Self::ReleaseWakeLock(..) => target!("ReleaseWakeLock"),
             }
         }
     }

components/default-resources/Cargo.toml

@@ -0,0 +1,16 @@
+[package]
+name = "servo-default-resources"
+version.workspace = true
+authors.workspace = true
+repository.workspace = true
+description.workspace = true
+license.workspace = true
+edition.workspace = true
+publish.workspace = true
+rust-version.workspace = true
+
+[lib]
+path = "lib.rs"
+
+[dependencies]
+embedder_traits = { workspace = true }

components/default-resources/lib.rs

@@ -0,0 +1,39 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
+
+use std::path::PathBuf;
+
+use embedder_traits::resources::{Resource, ResourceReaderMethods};
+
+/// A default resource reader that provides baked in resources.
+pub struct DefaultResourceReader;
+
+impl ResourceReaderMethods for DefaultResourceReader {
+    fn sandbox_access_files(&self) -> Vec<PathBuf> {
+        vec![]
+    }
+    fn sandbox_access_files_dirs(&self) -> Vec<PathBuf> {
+        vec![]
+    }
+    fn read(&self, file: Resource) -> Vec<u8> {
+        match file {
+            Resource::BluetoothBlocklist => &include_bytes!("resources/gatt_blocklist.txt")[..],
+            Resource::DomainList => &include_bytes!("resources/public_domains.txt")[..],
+            Resource::HstsPreloadList => &include_bytes!("resources/hsts_preload.fstmap")[..],
+            Resource::BadCertHTML => &include_bytes!("resources/badcert.html")[..],
+            Resource::NetErrorHTML => &include_bytes!("resources/neterror.html")[..],
+            Resource::BrokenImageIcon => &include_bytes!("resources/rippy.png")[..],
+            Resource::CrashHTML => &include_bytes!("resources/crash.html")[..],
+            Resource::DirectoryListingHTML => {
+                &include_bytes!("resources/directory-listing.html")[..]
+            },
+            Resource::AboutMemoryHTML => &include_bytes!("resources/about-memory.html")[..],
+            Resource::DebuggerJS => &include_bytes!("resources/debugger.js")[..],
+            Resource::JsonViewerHTML => &include_bytes!("resources/json-viewer.html")[..],
+        }
+        .to_owned()
+    }
+}
+
+embedder_traits::submit_resource_reader!(&DefaultResourceReader);

components/default-resources/resources/debugger.js

@@ -0,0 +1,611 @@
+if ("dbg" in this) {
+    throw new Error("Debugger script must not run more than once!");
+}
+
+const dbg = new Debugger;
+const debuggeesToPipelineIds = new Map;
+const debuggeesToWorkerIds = new Map;
+const sourceIdsToScripts = new Map;
+const frameActorsToFrames = new Map;
+const environmentActorsToEnvironments = new Map;
+
+// <https://searchfox.org/firefox-main/source/devtools/server/actors/thread.js#155>
+// Possible values for the `why.type` attribute in "paused" event
+const PAUSE_REASONS = {
+  INTERRUPTED: "interrupted", // Associated with why.onNext attribute
+  RESUME_LIMIT: "resumeLimit",
+};
+
+// Find script by scriptId within a script tree
+function findScriptById(script, scriptId) {
+    if (script.sourceStart === scriptId) {
+        return script;
+    }
+    for (const child of script.getChildScripts()) {
+        const found = findScriptById(child, scriptId);
+        if (found) return found;
+    }
+    return null;
+}
+
+// Walk script tree and call callback for each script
+function walkScriptTree(script, callback) {
+    callback(script);
+    for (const child of script.getChildScripts()) {
+        walkScriptTree(child, callback);
+    }
+}
+
+// Find a key by a value in a map
+function findKeyByValue(map, search) {
+    for (const [key, value] of map) {
+        if (value === search) return key;
+    }
+    return undefined;
+}
+
+dbg.uncaughtExceptionHook = function(error) {
+    console.error(`[debugger] Uncaught exception at ${error.fileName}:${error.lineNumber}:${error.columnNumber}: ${error.name}: ${error.message}`);
+};
+
+dbg.onNewScript = function(script) {
+    // TODO: handle wasm (`script.source.introductionType == wasm`)
+    sourceIdsToScripts.set(script.source.id, script);
+    notifyNewSource({
+        pipelineId: debuggeesToPipelineIds.get(script.global),
+        workerId: debuggeesToWorkerIds.get(script.global),
+        spidermonkeyId: script.source.id,
+        url: script.source.url,
+        urlOverride: script.source.displayURL,
+        text: script.source.text,
+        introductionType: script.source.introductionType ?? null,
+    });
+};
+
+// Track a new debuggee global
+addEventListener("addDebuggee", event => {
+    const {global, pipelineId, workerId} = event;
+    const debuggerObject = dbg.addDebuggee(global);
+    debuggeesToPipelineIds.set(debuggerObject, pipelineId);
+    if (workerId !== undefined) {
+        debuggeesToWorkerIds.set(debuggerObject, workerId);
+    }
+});
+
+
+// <https://searchfox.org/mozilla-central/source/devtools/server/actors/object/previewers.js#80>
+const previewers = {
+    Function: [],
+    Array: [],
+    Object: [],
+    // TODO: Add Map, FormData etc
+};
+
+// Convert debuggee value to property descriptor value
+// <https://searchfox.org/firefox-main/source/devtools/server/actors/object/utils.js#116>
+function createValueGrip(value, depth = 0) {
+    switch (typeof value) {
+        case "undefined":
+            return { valueType: "undefined" };
+        case "boolean":
+            return { valueType: "boolean", booleanValue: value };
+        case "number":
+            if (value === Infinity) {
+                return { valueType: "Infinity" };
+            } else if (value === -Infinity) {
+                return { valueType: "-Infinity" };
+            } else if (Number.isNaN(value)) {
+                return { valueType: "NaN" };
+            } else if (Object.is(value, -0)) {
+                return { valueType: "-0" };
+            }
+            return { valueType: "number", numberValue: value };
+        case "string":
+            return { valueType: "string", stringValue: value };
+        case "object":
+            if (value === null) {
+                return { valueType: "null" };
+            }
+            // Debugger.Object - get preview using registered previewers
+            // <https://firefox-source-docs.mozilla.org/devtools-user/debugger-api/debugger.object/index.html>
+            return {
+                valueType: "object",
+                objectClass: value.class,
+                preview: getPreview(value, depth),
+            };
+        default:
+            return { valueType: "string", stringValue: String(value) };
+    }
+}
+
+// Extract own properties from a debuggee object
+// <https://firefox-source-docs.mozilla.org/devtools-user/debugger-api/debugger.object/index.html#function-properties-of-the-debugger-object-prototype>
+function extractOwnProperties(obj, depth) {
+    const ownProperties = [];
+    let totalLength = 0;
+
+    let names;
+    try {
+        names = obj.getOwnPropertyNames();
+        totalLength = names.length;
+    } catch (e) {
+        return { ownProperties, ownPropertiesLength: 0 };
+    }
+
+    for (const name of names) {
+        try {
+            const desc = obj.getOwnPropertyDescriptor(name);
+            if (desc) {
+                const prop = {
+                    name: name,
+                    configurable: desc.configurable ?? false,
+                    enumerable: desc.enumerable ?? false,
+                    writable: desc.writable ?? false,
+                    isAccessor: desc.get !== undefined || desc.set !== undefined,
+                    value: createValueGrip(undefined, depth + 1),
+                };
+
+                if (desc.value !== undefined) {
+                    prop.value = createValueGrip(desc.value, depth + 1);
+                } else if (desc.get) {
+                    try {
+                        const result = desc.get.call(obj);
+                        if (result && "return" in result) {
+                            prop.value = createValueGrip(result.return, depth + 1);
+                        }
+                    } catch (e) { }
+                }
+
+                ownProperties.push(prop);
+            }
+        } catch (e) {
+            // For now skip properties that throw on access
+        }
+    }
+
+    return { ownProperties, ownPropertiesLength: totalLength };
+}
+
+// <https://searchfox.org/mozilla-central/source/devtools/server/actors/object/previewers.js#125>
+previewers.Function.push(function FunctionPreviewer(obj, depth) {
+    const { ownProperties, ownPropertiesLength } = extractOwnProperties(obj, depth);
+    let function_details = {
+        name: obj.name,
+        displayName: obj.displayName,
+        parameterNames: obj.parameterNames ? obj.parameterNames: [],
+        isAsync: obj.isAsyncFunction,
+        isGenerator: obj.isGeneratorFunction,
+    }
+
+    if (depth > 1) {
+        return { kind: "Object", function: function_details, ownPropertiesLength };
+    }
+
+    return {
+        kind: "Object",
+        ownProperties,
+        ownPropertiesLength,
+        function: function_details
+    };
+});
+
+// <https://searchfox.org/mozilla-central/source/devtools/server/actors/object/previewers.js#172>
+previewers.Array.push(function ArrayPreviewer(obj, depth) {
+    const lengthDescriptor = obj.getOwnPropertyDescriptor("length");
+    const length = lengthDescriptor ? lengthDescriptor.value : 0;
+
+    if (depth > 1) {
+        return {
+            kind: "ArrayLike",
+            arrayLength: length,
+        };
+    }
+
+    const items = [];
+    for (let i = 0; i < length; i++) {
+        try {
+            const desc = obj.getOwnPropertyDescriptor(i);
+            if (desc && desc.value !== undefined) {
+                const grip = createValueGrip(desc.value, depth);
+                delete grip.preview;
+                items.push(grip);
+            }
+        } catch (e) {
+            // For now skip properties that throw on access
+        }
+    }
+
+    return {
+        kind: "ArrayLike",
+        arrayLength: length,
+        items: items,
+    };
+});
+
+// Generic fallback for object previewer
+// <https://searchfox.org/mozilla-central/source/devtools/server/actors/object/previewers.js#856>
+previewers.Object.push(function ObjectPreviewer(obj, depth) {
+    const { ownProperties, ownPropertiesLength } = extractOwnProperties(obj, depth);
+
+    if (depth > 1) {
+       return { kind: "Object", ownPropertiesLength };
+    }
+
+    return {
+        kind: "Object",
+        ownProperties,
+        ownPropertiesLength,
+    };
+});
+
+function getPreview(obj, depth) {
+    const className = obj.class;
+
+    // <https://searchfox.org/mozilla-central/source/devtools/server/actors/object.js#295>
+    const typePreviewers = previewers[className] || previewers.Object;
+    for (const previewer of typePreviewers) {
+        const result = previewer(obj, depth);
+        if (result) return result;
+    }
+
+    return { ownProperties: [], ownPropertiesLength: 0 };
+}
+
+// Evaluate some javascript code in the global context of the debuggee
+// See executeInGlobal() at <https://firefox-source-docs.mozilla.org/devtools-user/debugger-api/debugger.object/index.html#function-properties-of-the-debugger-object-prototype>
+addEventListener("eval", event => {
+    const {code, pipelineId, workerId, frameActorId} = event;
+
+    let completionValue;
+    if (frameActorId) {
+        const frame = frameActorsToFrames.get(frameActorId);
+        // <https://searchfox.org/firefox-main/source/js/src/doc/Debugger/Debugger.Frame.md#223>
+        if (frame?.onStack) {
+            completionValue = frame.eval(code);
+        } else {
+            completionValue = { throw: "Frame not available" };
+        }
+    } else {
+        const object = workerId !== undefined ?
+            findKeyByValue(debuggeesToWorkerIds, workerId) :
+            findKeyByValue(debuggeesToPipelineIds, pipelineId);
+        completionValue = object.executeInGlobal(code);
+    }
+
+    // Completion values: <https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#completion-values>
+    let resultValue;
+    if (completionValue === null) {
+        resultValue = { completionType: "terminated", value: createValueGrip(undefined), hasException: false };
+    } else if ("throw" in completionValue) {
+        // See adoptDebuggeeValue() in <https://firefox-source-docs.mozilla.org/devtools-user/debugger-api/debugger/index.html>
+        // <https://searchfox.org/firefox-main/source/devtools/server/actors/webconsole/eval-with-debugger.js#312>
+        // we probably don't need adoptDebuggeeValue, as we only have one debugger instance for now
+        // let value = dbg.adoptDebuggeeValue(completionValue.throw);
+        resultValue = { completionType: "throw", value: createValueGrip(completionValue.throw), hasException: true };
+    } else if ("return" in completionValue) {
+        resultValue = { completionType: "return", value: createValueGrip(completionValue.return), hasException: false };
+    }
+
+    // To avoid recursion errors in the WebIDL, preview needs to live outside of the property descriptor
+    if (resultValue.value.preview) {
+        resultValue.preview = resultValue.value.preview;
+        delete resultValue.value.preview;
+    }
+
+    evalResult(event, resultValue);
+});
+
+addEventListener("getPossibleBreakpoints", event => {
+    const {spidermonkeyId} = event;
+    const script = sourceIdsToScripts.get(spidermonkeyId);
+    const result = [];
+    walkScriptTree(script, (currentScript) => {
+        for (const location of currentScript.getPossibleBreakpoints()) {
+            location["scriptId"] = currentScript.sourceStart;
+            result.push(location);
+        }
+    });
+    getPossibleBreakpointsResult(event, result);
+});
+
+function createFrameActor(frame, pipelineId) {
+    let frameActorId = findKeyByValue(frameActorsToFrames, frame);
+    if (!frameActorId) {
+        // TODO: Check if we already have an actor for this frame
+        frameActorId = registerFrameActor(pipelineId, {
+            // TODO: Some properties throw if terminated is true
+            // TODO: arguments: frame.arguments,
+            displayName: frame.script.displayName,
+            onStack: frame.onStack,
+            oldest: frame.older == null,
+            terminated: frame.terminated,
+            type_: frame.type,
+            url: frame.script.url,
+        });
+
+        if (!frameActorId) {
+            console.error("[debugger] Couldn't create frame");
+            return undefined;
+        }
+        frameActorsToFrames.set(frameActorId, frame);
+    }
+
+    return frameActorId;
+}
+
+function handlePauseAndRespond(frame, pauseReason) {
+    dbg.onEnterFrame = undefined;
+    clearSteppingHooks(frame);
+
+    // Get the pipeline ID for this debuggee
+    const pipelineId = debuggeesToPipelineIds.get(frame.script.global);
+    if (!pipelineId) {
+        console.error("[debugger] No pipeline ID for frame's global");
+        return undefined;
+    }
+
+    let frameActorId = createFrameActor(frame, pipelineId);
+
+    // <https://github.com/mozilla-firefox/firefox/blob/63719d122f9214f37fd1d285a91897b8345b88b0/js/src/doc/Debugger/Debugger.Script.md?plain=1#L293-L303>
+    const offset = frame.offset;
+    const offsetMetadata = frame.script.getOffsetMetadata(offset);
+    const frameOffset = {
+        frameActorId,
+        column: offsetMetadata.columnNumber - 1,
+        line: offsetMetadata.lineNumber
+    };
+
+    // Notify devtools and enter pause loop. This blocks until Resume.
+    pauseAndRespond(
+        pipelineId,
+        frameOffset,
+        pauseReason
+    );
+
+    // <https://web.archive.org/web/20251212212538/https://firefox-source-docs.mozilla.org/js/Debugger/Conventions.html#resumption-values>
+    // Return undefined to continue execution normally after resume.
+    return undefined;
+}
+
+addEventListener("frames", event => {
+    const {pipelineId, start, count} = event;
+    let frameList = handleListFrames(pipelineId, start, count);
+
+    listFramesResult(frameList);
+})
+
+// <https://searchfox.org/firefox-main/source/devtools/server/actors/thread.js#1425>
+function handleListFrames(pipelineId, start, count) {
+    let frame = dbg.getNewestFrame()
+
+    const walkToParentFrame = () => {
+        if (!frame) {
+            return;
+        }
+
+        const currentFrame = frame;
+        frame = null;
+
+        if (currentFrame.older) {
+            frame = currentFrame.older;
+        }
+    }
+
+    let i = 0;
+    while (frame && i < start) {
+      walkToParentFrame();
+      i++;
+    }
+
+    // Return count frames, or all remaining frames if count is not defined.
+    const frames = [];
+    for (; frame && (!count || i < start + count); i++, walkToParentFrame()) {
+      const frameActorId = createFrameActor(frame, pipelineId);
+      frames.push(frameActorId);
+    }
+
+    return frames;
+}
+
+addEventListener("setBreakpoint", event => {
+    const {spidermonkeyId, scriptId, offset} = event;
+    const script = sourceIdsToScripts.get(spidermonkeyId);
+    const target = findScriptById(script, scriptId);
+    if (target) {
+        target.setBreakpoint(offset, {
+            // setBreakpoint(offset, handler) in <https://firefox-source-docs.mozilla.org/devtools-user/debugger-api/debugger.script/index.html#function-properties-of-the-debugger-script-prototype-object>
+            // The hit handler receives a Debugger.Frame instance representing the currently executing stack frame.
+            hit: (frame) => handlePauseAndRespond(frame, {type_: "breakpoint"})
+        });
+    }
+});
+
+// <https://firefox-source-docs.mozilla.org/devtools-user/debugger-api/debugger.frame/index.html>
+addEventListener("interrupt", event => {
+    dbg.onEnterFrame = (frame) => handlePauseAndRespond(
+        frame,
+        { type_: PAUSE_REASONS.INTERRUPTED, onNext: true }
+    );
+});
+
+function makeSteppingHooks(steppingType, startFrame) {
+    return {
+        onEnterFrame: (frame) => {
+            const { onStep, onPop } = makeSteppingHooks("next", frame);
+            frame.onStep = onStep;
+            frame.onPop = onPop;
+        },
+        onStep: () => {
+            const meta = startFrame.script.getOffsetMetadata(startFrame.offset);
+            if (meta.isBreakpoint && meta.isStepStart) {
+                return handlePauseAndRespond(startFrame, { type_: PAUSE_REASONS.RESUME_LIMIT });
+            }
+        },
+        onPop: (completion) => {
+            this.reportedPop = true;
+            suspendedFrame = startFrame;
+            if (steppingType !== "finish") {
+                // TODO: completion contains the return value, we have to send it back
+                // <https://searchfox.org/firefox-main/source/devtools/server/actors/thread.js#1026>
+                return handlePauseAndRespond(startFrame, { type_: steppingType });
+            }
+            attachSteppingHooks("next", startFrame);
+        },
+    }
+}
+
+function getNextStepFrame(frame) {
+    const endOfFrame = frame.reportedPop;
+    const stepFrame = endOfFrame ? frame.older : frame;
+    if (!stepFrame || !stepFrame.script) {
+      return null;
+    }
+    return stepFrame;
+}
+
+// <https://searchfox.org/firefox-main/source/devtools/server/actors/thread.js#1235>
+function attachSteppingHooks(steppingType, frame) {
+    if (steppingType === "finish" && frame.reportedPop) {
+        steppingType = "next";
+    }
+
+    const stepFrame = getNextStepFrame(frame);
+    if (!stepFrame) {
+        steppingType = "step";
+    }
+
+    const { onEnterFrame, onStep, onPop } = makeSteppingHooks(
+        steppingType,
+        frame,
+    );
+
+    if (steppingType === "step") {
+        dbg.onEnterFrame = onEnterFrame;
+    }
+
+    if (stepFrame) {
+        switch (steppingType) {
+            case "step":
+            case "next":
+                if (stepFrame.script) {
+                    stepFrame.onStep = onStep;
+                }
+            case "finish":
+                stepFrame.onPop = onPop;
+                break;
+        }
+    }
+}
+
+function clearSteppingHooks(suspendedFrame) {
+    if (suspendedFrame) {
+        suspendedFrame.onStep = undefined;
+        suspendedFrame.onPop = undefined;
+    }
+    let frame = this.youngestFrame;
+    if (frame?.onStack) {
+        while (frame) {
+            frame.onStep = undefined;
+            frame.onPop = undefined;
+            frame = frame.older;
+        }
+    }
+}
+
+// <https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#resuming-a-thread>
+addEventListener("resume", event => {
+    const {resumeLimitType: steppingType, frameActorID} = event;
+    let frame = dbg.getNewestFrame();
+    if (frameActorID) {
+        frame = frameActorsToFrames.get(frameActorID);
+        if (!frame) {
+            console.error("[debugger] Couldn't find frame");
+        }
+    }
+    if (steppingType) {
+        attachSteppingHooks(steppingType, frame);
+    } else {
+        clearSteppingHooks(frame);
+    }
+});
+
+// <https://firefox-source-docs.mozilla.org/devtools-user/debugger-api/debugger.script/index.html#function-properties-of-the-debugger-script-prototype-object>
+// There may be more than one breakpoint at the same offset with different handlers, but we don’t handle that case for now.
+addEventListener("clearBreakpoint", event => {
+    const {spidermonkeyId, scriptId, offset} = event;
+    const script = sourceIdsToScripts.get(spidermonkeyId);
+    const target = findScriptById(script, scriptId);
+    if (target) {
+        // If the instance refers to a JSScript, remove all breakpoints set in this script at that offset.
+        target.clearAllBreakpoints(offset);
+    }
+});
+
+// TODO: Get variables (scopes don't show if they don't have a variable)
+function createEnvironmentActor(environment) {
+    let actor = findKeyByValue(environmentActorsToEnvironments, environment);
+
+    if (!actor) {
+        let info = {};
+        if (environment.type == "declarative") {
+            info.type_ = environment.calleeScript ? "function" : "block";
+        } else {
+            info.type_ = environment.type;
+        }
+
+        info.scopeKind = environment.scopeKind;
+
+        if (environment.calleeScript) {
+            info.functionDisplayName = environment.calleeScript.displayName;
+        }
+
+        let parent = null;
+        if (environment.parent) {
+            parent = createEnvironmentActor(environment.parent);
+        }
+
+        if (environment.type == "declarative") {
+            info.bindingVariables = buildBindings(environment)
+        }
+
+        actor = registerEnvironmentActor(info, parent);
+        environmentActorsToEnvironments.set(actor, environment);
+    }
+
+    return actor;
+}
+
+function buildBindings(environment) {
+    let bindingVars = [];
+    for (const name of environment.names()) {
+        const value = environment.getVariable(name);
+        const property = {
+            name: name,
+            configurable: false,
+            enumerable: true,
+            writable: !value?.optimizedOut,
+            isAccessor: false,
+            value: createValueGrip(value),
+        };
+
+        // To avoid recursion errors in the WebIDL, preview needs to live outside of the property descriptor
+        let preview = undefined;
+        if (property.value.preview) {
+            preview = property.value.preview;
+            delete property.value.preview;
+        }
+
+        bindingVars.push({ property, preview });
+    }
+    return bindingVars;
+}
+
+// Get a `Debugger.Environment` instance within which evaluation is taking place.
+// <https://searchfox.org/firefox-main/source/devtools/server/actors/frame.js#109>
+addEventListener("getEnvironment", event => {
+    const {frameActorId} = event;
+    frame = frameActorsToFrames.get(frameActorId);
+
+    const actor = createEnvironmentActor(frame.environment);
+    getEnvironmentResult(actor);
+});

components/default-resources/resources/json-viewer.html

@@ -0,0 +1,269 @@
+<html>
+  <head>
+    <style>
+      body {
+        font-family: monospace;
+        margin: 0;
+        padding: 0;
+        background: #fff;
+        color: #333;
+      }
+
+      #json-raw {
+        display: none;
+      }
+
+      #viewer {
+        display: none;
+        padding: 0.5em 1em;
+        line-height: 1.5;
+
+        &.active {
+          display: block;
+        }
+      }
+
+      #toolbar {
+        display: flex;
+        gap: 1em;
+        padding: 0.5em;
+        align-items: center;
+        background: #f5f5f5;
+        border-bottom: 1px solid #ddd;
+
+        & button {
+          min-width: 5em;
+
+          &.active {
+            background: #ddd;
+            font-weight: bold;
+          }
+        }
+      }
+
+      #raw-view {
+        display: none;
+        padding: 0.5em 1em;
+        white-space: pre-wrap;
+        word-break: break-all;
+
+        &.active {
+          display: block;
+        }
+      }
+
+      .json-error {
+        padding: 0.5em 1em;
+        color: #c00;
+        font-weight: bold;
+      }
+
+      /* Syntax highlighting for Json data types */
+      .json-key {
+        color: #881391;
+      }
+
+      .json-string {
+        color: #1a1aa6;
+      }
+
+      .json-number {
+        color: #1c00cf;
+      }
+
+      .json-boolean {
+        color: #0d22aa;
+      }
+
+      .json-null {
+        color: #808080;
+      }
+
+      /* Collapsible tree */
+      .toggle {
+        cursor: pointer;
+        user-select: none;
+
+        &::before {
+          content: "\25BC";
+          display: inline-block;
+          width: 1em;
+          transition: transform 0.1s;
+        }
+
+        &.collapsed::before {
+          transform: rotate(-90deg);
+        }
+      }
+
+      .collapsible {
+        margin-left: 1.5em;
+
+        &.hidden {
+          display: none;
+        }
+      }
+
+      .bracket {
+        color: #333;
+      }
+
+      .comma {
+        color: #333;
+      }
+
+      .line {
+        padding-left: 0;
+      }
+    </style>
+    <script>
+      // Shortcut to create an element with an optional class and text content.
+      function createElement(name, classes = null, textContent = null) {
+        let node = document.createElement(name);
+        if (classes) {
+          node.className = classes;
+        }
+        if (textContent) {
+          node.textContent = textContent;
+        }
+        return node;
+      }
+
+      function renderNode(value, container) {
+        if (value === null) {
+          let s = createElement("span", "json-null", "null");
+          container.append(s);
+        } else if (typeof value === "boolean") {
+          let s = createElement("span", "json-boolean", String(value));
+          container.append(s);
+        } else if (typeof value === "number") {
+          let s = createElement("span", "json-number", String(value));
+          container.append(s);
+        } else if (typeof value === "string") {
+          let s = createElement("span", "json-string", JSON.stringify(value));
+          container.append(s);
+        } else if (Array.isArray(value)) {
+          renderArray(value, container);
+        } else if (typeof value === "object") {
+          renderObject(value, container);
+        }
+      }
+
+      function renderObject(obj, container) {
+        let keys = Object.keys(obj);
+        if (keys.length === 0) {
+          container.append(createElement("span", "bracket", "{}"));
+          return;
+        }
+
+        let toggle = createElement("span", "toggle");
+        container.append(toggle);
+
+        container.append(createElement("span", "bracket", "{"));
+
+        let inner = createElement("div", "collapsible");
+        container.append(inner);
+
+        keys.forEach((key, i) => {
+          let line = createElement("div", "line");
+          line.append(createElement("span", "json-key", JSON.stringify(key)));
+          line.append(document.createTextNode(": "));
+          renderNode(obj[key], line);
+          if (i < keys.length - 1) {
+            line.append(createElement("span", "comma", ","));
+          }
+          inner.append(line);
+        });
+
+        container.append(createElement("span", "bracket", "}"));
+
+        toggle.onclick = function () {
+          toggle.classList.toggle("collapsed");
+          inner.classList.toggle("hidden");
+        };
+      }
+
+      function renderArray(arr, container) {
+        if (arr.length === 0) {
+          container.append(createElement("span", "bracket", "[]"));
+          return;
+        }
+
+        let toggle = createElement("span", "toggle");
+        container.append(toggle);
+
+        container.append(createElement("span", "bracket", "["));
+
+        let inner = createElement("div", "collapsible");
+        container.append(inner);
+
+        arr.forEach((item, i) => {
+          let line = createElement("div", "line");
+          renderNode(item, line);
+          if (i < arr.length - 1) {
+            line.append(createElement("span", "comma", ","));
+          }
+          inner.append(line);
+        });
+
+        container.append(createElement("span", "bracket", "]"));
+
+        toggle.onclick = function () {
+          toggle.classList.toggle("collapsed");
+          inner.classList.toggle("hidden");
+        };
+      }
+
+      document.addEventListener("DOMContentLoaded", function () {
+        const viewer = document.getElementById("viewer");
+        const prettyButton = document.getElementById("pretty-toggle");
+        const rawButton = document.getElementById("raw-toggle");
+        const rawView = document.getElementById("raw-view");
+        const rawText = rawView.innerText;
+
+        let data;
+        let parseError = null;
+        try {
+          data = JSON.parse(rawText);
+        } catch (e) {
+          parseError = e;
+        }
+
+        if (parseError) {
+          let errDiv = createElement(
+            "div",
+            "json-error",
+            "Invalid JSON: " + parseError.message,
+          );
+          viewer.append(errDiv);
+          viewer.append(createElement("pre", null, rawText));
+        } else {
+          renderNode(data, viewer);
+          rawView.textContent = JSON.stringify(data, null, 2);
+        }
+
+        // Toggle buttons
+        prettyButton.onclick = function () {
+          viewer.classList.add("active");
+          rawView.classList.remove("active");
+
+          prettyButton.classList.add("active");
+          rawButton.classList.remove("active");
+        };
+        rawButton.onclick = function () {
+          rawView.classList.add("active");
+          viewer.classList.remove("active");
+
+          rawButton.classList.add("active");
+          prettyButton.classList.remove("active");
+        };
+      });
+    </script>
+  </head>
+  <body>
+    <div id="toolbar">
+      <button id="pretty-toggle" class="active">Pretty</button>
+      <button id="raw-toggle">Raw</button>
+    </div>
+    <div id="viewer" class="active"></div>
+    <pre id="raw-view">

components/deny_public_fields/Cargo.toml

@@ -6,6 +6,8 @@ license.workspace = true
 edition.workspace = true
 publish.workspace = true
 rust-version.workspace = true
+repository.workspace = true
+description.workspace = true
 
 [lib]
 path = "lib.rs"

components/devtools/Cargo.toml

@@ -6,6 +6,8 @@ license.workspace = true
 edition.workspace = true
 publish.workspace = true
 rust-version.workspace = true
+repository.workspace = true
+description.workspace = true
 
 [lib]
 name = "devtools"
@@ -13,7 +15,6 @@ path = "lib.rs"
 
 [dependencies]
 atomic_refcell = { workspace = true }
-base = { workspace = true }
 base64 = { workspace = true }
 chrono = { workspace = true }
 crossbeam-channel = { workspace = true }
@@ -24,15 +25,16 @@ http = { workspace = true }
 log = { workspace = true }
 malloc_size_of = { workspace = true }
 malloc_size_of_derive = { workspace = true }
-net = { package = "servo-net", path = "../net" }
+net = { workspace = true }
 net_traits = { workspace = true }
 profile_traits = { workspace = true }
 rand = { workspace = true }
 rustc-hash = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
-servo_config = { package = "servo-config", path = "../config" }
-servo_url = { package = "servo-url", path = "../url" }
+servo-base = { workspace = true }
+servo-config = { workspace = true }
+servo-url = { workspace = true }
 uuid = { workspace = true }
 
 [build-dependencies]

components/devtools/actor.rs

@@ -5,20 +5,19 @@
 use std::any::{Any, type_name};
 use std::collections::HashMap;
 use std::marker::PhantomData;
-use std::net::TcpStream;
 use std::sync::Arc;
 use std::sync::atomic::{AtomicU32, Ordering};
 
 use atomic_refcell::AtomicRefCell;
-use base::id::PipelineId;
 use log::{debug, warn};
 use malloc_size_of::MallocSizeOf;
 use malloc_size_of_derive::MallocSizeOf;
 use serde::Serialize;
 use serde_json::{Map, Value, json};
+use servo_base::id::PipelineId;
 
 use crate::StreamId;
-use crate::protocol::{ClientRequest, JsonPacketStream};
+use crate::protocol::{ClientRequest, DevtoolsConnection, JsonPacketStream};
 
 /// Error replies.
 ///
@@ -50,7 +49,6 @@ impl ActorError {
 
 /// A common trait for all devtools actors that encompasses an immutable name
 /// and the ability to process messages that are directed to particular actors.
-/// TODO: ensure the name is immutable
 pub(crate) trait Actor: Any + ActorAsAny + Send + Sync + MallocSizeOf {
     fn handle_message(
         &self,
@@ -158,11 +156,19 @@ impl ActorRegistry {
     }
 
     /// Create a unique name based on a monotonically increasing suffix
-    /// TODO: Merge this with `register/register_later` and don't allow to
+    /// TODO: Merge this with `register` and don't allow to
     /// create new names without registering an actor.
     pub fn new_name<T: Actor>(&self) -> String {
         let suffix = self.next.fetch_add(1, Ordering::Relaxed);
-        format!("{}{}", Self::base_name::<T>(), suffix)
+        let base = Self::base_name::<T>();
+
+        // Firefox DevTools client requires "/workerTarget" in actor name to recognize workers
+        // <https://searchfox.org/firefox-main/source/devtools/client/fronts/watcher.js#65>
+        if base.contains("WorkerTarget") {
+            format!("/workerTarget{}", suffix)
+        } else {
+            format!("{}{}", base, suffix)
+        }
     }
 
     /// Add an actor to the registry of known actors that can receive messages.
@@ -198,7 +204,7 @@ impl ActorRegistry {
     pub(crate) fn handle_message(
         &self,
         msg: &Map<String, Value>,
-        stream: &mut TcpStream,
+        stream: &mut DevtoolsConnection,
         stream_id: StreamId,
     ) -> Result<(), ()> {
         let to = match msg.get("to") {
@@ -221,7 +227,7 @@ impl ActorRegistry {
             },
             Some(actor) => {
                 let msg_type = msg.get("type").unwrap().as_str().unwrap();
-                if let Err(error) = ClientRequest::handle(stream, to, |req| {
+                if let Err(error) = ClientRequest::handle(stream.clone(), to, |req| {
                     actor.handle_message(req, self, msg_type, msg, stream_id)
                 }) {
                     // <https://firefox-source-docs.mozilla.org/devtools/backend/protocol.html#error-packets>

components/devtools/actors/blackboxing.rs

@@ -0,0 +1,34 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
+
+use malloc_size_of_derive::MallocSizeOf;
+
+use crate::ActorMsg;
+use crate::actor::{Actor, ActorEncode, ActorRegistry};
+
+#[derive(MallocSizeOf)]
+pub(crate) struct BlackboxingActor {
+    name: String,
+}
+
+impl Actor for BlackboxingActor {
+    fn name(&self) -> String {
+        self.name.clone()
+    }
+}
+
+impl BlackboxingActor {
+    pub fn register(registry: &ActorRegistry) -> String {
+        let name = registry.new_name::<Self>();
+        let actor = Self { name: name.clone() };
+        registry.register::<Self>(actor);
+        name
+    }
+}
+
+impl ActorEncode<ActorMsg> for BlackboxingActor {
+    fn encode(&self, _: &ActorRegistry) -> ActorMsg {
+        ActorMsg { actor: self.name() }
+    }
+}

components/devtools/actors/breakpoint.rs

@@ -30,7 +30,7 @@ struct BreakpointRequest {
 #[derive(MallocSizeOf)]
 pub(crate) struct BreakpointListActor {
     name: String,
-    browsing_context: String,
+    browsing_context_name: String,
 }
 
 impl Actor for BreakpointListActor {
@@ -60,10 +60,11 @@ impl Actor for BreakpointListActor {
                 } = msg.location;
                 let source_url = source_url.ok_or(ActorError::Internal)?;
 
-                let browsing_context =
-                    registry.find::<BrowsingContextActor>(&self.browsing_context);
-                let thread = registry.find::<ThreadActor>(&browsing_context.thread);
-                let source = thread
+                let browsing_context_actor =
+                    registry.find::<BrowsingContextActor>(&self.browsing_context_name);
+                let thread_actor =
+                    registry.find::<ThreadActor>(&browsing_context_actor.thread_name);
+                let source = thread_actor
                     .source_manager
                     .find_source(registry, &source_url)
                     .ok_or(ActorError::Internal)?;
@@ -96,10 +97,11 @@ impl Actor for BreakpointListActor {
                 } = msg.location;
                 let source_url = source_url.ok_or(ActorError::Internal)?;
 
-                let browsing_context =
-                    registry.find::<BrowsingContextActor>(&self.browsing_context);
-                let thread = registry.find::<ThreadActor>(&browsing_context.thread);
-                let source = thread
+                let browsing_context_actor =
+                    registry.find::<BrowsingContextActor>(&self.browsing_context_name);
+                let thread_actor =
+                    registry.find::<ThreadActor>(&browsing_context_actor.thread_name);
+                let source = thread_actor
                     .source_manager
                     .find_source(registry, &source_url)
                     .ok_or(ActorError::Internal)?;
@@ -124,11 +126,14 @@ impl Actor for BreakpointListActor {
 }
 
 impl BreakpointListActor {
-    pub fn new(name: String, browsing_context: String) -> Self {
-        Self {
-            name,
-            browsing_context,
-        }
+    pub fn register(registry: &ActorRegistry, browsing_context_name: String) -> String {
+        let name = registry.new_name::<Self>();
+        let actor = Self {
+            name: name.clone(),
+            browsing_context_name,
+        };
+        registry.register::<Self>(actor);
+        name
     }
 }
 

components/devtools/actors/browsing_context.rs

@@ -6,17 +6,16 @@
 //! Connection point for remote devtools that wish to investigate a particular Browsing Context's contents.
 //! Supports dynamic attaching and detaching which control notifications of navigation, etc.
 
-use std::net::TcpStream;
-
 use atomic_refcell::AtomicRefCell;
-use base::generic_channel::{self, GenericSender, SendError};
-use base::id::PipelineId;
 use devtools_traits::DevtoolScriptControlMsg::{self, GetCssDatabase, SimulateColorScheme};
 use devtools_traits::{DevtoolsPageInfo, NavigationState};
 use embedder_traits::Theme;
 use malloc_size_of_derive::MallocSizeOf;
+use rustc_hash::FxHashMap;
 use serde::Serialize;
 use serde_json::{Map, Value};
+use servo_base::generic_channel::{self, GenericSender, SendError};
+use servo_base::id::PipelineId;
 
 use crate::actor::{Actor, ActorEncode, ActorError, ActorRegistry};
 use crate::actors::inspector::InspectorActor;
@@ -28,7 +27,7 @@ use crate::actors::tab::TabDescriptorActor;
 use crate::actors::thread::ThreadActor;
 use crate::actors::watcher::{SessionContext, SessionContextType, WatcherActor};
 use crate::id::{DevtoolsBrowserId, DevtoolsBrowsingContextId, DevtoolsOuterWindowId, IdMap};
-use crate::protocol::{ClientRequest, JsonPacketStream};
+use crate::protocol::{ClientRequest, DevtoolsConnection, JsonPacketStream};
 use crate::resource::ResourceAvailable;
 use crate::{EmptyReplyMsg, StreamId};
 
@@ -140,16 +139,22 @@ pub(crate) struct BrowsingContextActor {
     active_pipeline_id: AtomicRefCell<PipelineId>,
     active_outer_window_id: AtomicRefCell<DevtoolsOuterWindowId>,
     pub browsing_context_id: DevtoolsBrowsingContextId,
-    accessibility: String,
-    pub console: String,
-    css_properties: String,
-    pub(crate) inspector: String,
-    reflow: String,
-    style_sheets: String,
-    pub thread: String,
+    accessibility_name: String,
+    pub console_name: String,
+    css_properties_name: String,
+    pub(crate) inspector_name: String,
+    reflow_name: String,
+    style_sheets_name: String,
+    pub thread_name: String,
     _tab: String,
-    pub script_chan: GenericSender<DevtoolScriptControlMsg>,
-    pub watcher: String,
+    // Different pipelines may run on different script threads.
+    // These should be kept around even when the active pipeline is updated,
+    // in case the browsing context revisits a pipeline via history navigation.
+    // TODO: Each entry is stored forever; ideally there should be a way to
+    //       detect when `ScriptThread`s are destroyed and remove the associated
+    //       entries.
+    script_chans: AtomicRefCell<FxHashMap<PipelineId, GenericSender<DevtoolScriptControlMsg>>>,
+    pub watcher_name: String,
 }
 
 impl ResourceAvailable for BrowsingContextActor {
@@ -192,24 +197,25 @@ impl Actor for BrowsingContextActor {
 
 impl BrowsingContextActor {
     #[expect(clippy::too_many_arguments)]
-    pub(crate) fn new(
-        console: String,
+    pub(crate) fn register(
+        registry: &ActorRegistry,
+        console_name: String,
         browser_id: DevtoolsBrowserId,
         browsing_context_id: DevtoolsBrowsingContextId,
         page_info: DevtoolsPageInfo,
         pipeline_id: PipelineId,
         outer_window_id: DevtoolsOuterWindowId,
         script_sender: GenericSender<DevtoolScriptControlMsg>,
-        actors: &ActorRegistry,
-    ) -> BrowsingContextActor {
-        let name = actors.new_name::<BrowsingContextActor>();
+    ) -> String {
+        let name = registry.new_name::<BrowsingContextActor>();
         let DevtoolsPageInfo {
             title,
             url,
             is_top_level_global,
+            ..
         } = page_info;
 
-        let accessibility = AccessibilityActor::new(actors.new_name::<AccessibilityActor>());
+        let accessibility_name = AccessibilityActor::register(registry);
 
         let properties = (|| {
             let (properties_sender, properties_receiver) = generic_channel::channel()?;
@@ -217,61 +223,69 @@ impl BrowsingContextActor {
             properties_receiver.recv().ok()
         })()
         .unwrap_or_default();
-        let css_properties =
-            CssPropertiesActor::new(actors.new_name::<CssPropertiesActor>(), properties);
+        let css_properties_name = CssPropertiesActor::register(registry, properties);
 
-        let inspector = InspectorActor::register(actors, pipeline_id, script_sender.clone());
+        let inspector_name = InspectorActor::register(registry, name.clone());
 
-        let reflow = ReflowActor::new(actors.new_name::<ReflowActor>());
+        let reflow_name = ReflowActor::register(registry);
 
-        let style_sheets = StyleSheetsActor::new(actors.new_name::<StyleSheetsActor>());
+        let style_sheets_name = StyleSheetsActor::register(registry);
 
-        let tabdesc = TabDescriptorActor::new(actors, name.clone(), is_top_level_global);
+        let tab_descriptor_name =
+            TabDescriptorActor::register(registry, name.clone(), is_top_level_global);
 
-        let thread = ThreadActor::new(actors.new_name::<ThreadActor>(), script_sender.clone());
+        let thread_name =
+            ThreadActor::register(registry, script_sender.clone(), Some(name.clone()));
 
-        let watcher = WatcherActor::new(
-            actors,
+        let watcher_name = WatcherActor::register(
+            registry,
             name.clone(),
             SessionContext::new(SessionContextType::BrowserElement),
         );
 
-        let target = BrowsingContextActor {
-            name,
-            script_chan: script_sender,
+        let mut script_chans = FxHashMap::default();
+        script_chans.insert(pipeline_id, script_sender);
+
+        let actor = BrowsingContextActor {
+            name: name.clone(),
+            script_chans: AtomicRefCell::new(script_chans),
             title: AtomicRefCell::new(title),
             url: AtomicRefCell::new(url.into_string()),
             active_pipeline_id: AtomicRefCell::new(pipeline_id),
             active_outer_window_id: AtomicRefCell::new(outer_window_id),
             browser_id,
             browsing_context_id,
-            accessibility: accessibility.name(),
-            console,
-            css_properties: css_properties.name(),
-            inspector,
-            reflow: reflow.name(),
-            style_sheets: style_sheets.name(),
-            _tab: tabdesc.name(),
-            thread: thread.name(),
-            watcher: watcher.name(),
+            accessibility_name,
+            console_name,
+            css_properties_name,
+            inspector_name,
+            reflow_name,
+            style_sheets_name,
+            _tab: tab_descriptor_name,
+            thread_name,
+            watcher_name,
         };
 
-        actors.register(accessibility);
-        actors.register(css_properties);
-        actors.register(reflow);
-        actors.register(style_sheets);
-        actors.register(tabdesc);
-        actors.register(thread);
-        actors.register(watcher);
+        registry.register::<Self>(actor);
 
-        target
+        name
     }
 
-    pub(crate) fn navigate<'a>(
+    pub(crate) fn handle_new_global(
+        &self,
+        pipeline: PipelineId,
+        script_sender: GenericSender<DevtoolScriptControlMsg>,
+    ) {
+        self.script_chans
+            .borrow_mut()
+            .insert(pipeline, script_sender);
+    }
+
+    pub(crate) fn handle_navigate<'a>(
         &self,
         state: NavigationState,
         id_map: &mut IdMap,
-        connections: impl Iterator<Item = &'a mut TcpStream>,
+        connections: impl Iterator<Item = &'a mut DevtoolsConnection>,
     ) {
         let (pipeline_id, title, url, state) = match state {
             NavigationState::Start(url) => (None, None, url, "start"),
@@ -325,7 +339,7 @@ impl BrowsingContextActor {
     }
 
     pub fn simulate_color_scheme(&self, theme: Theme) -> Result<(), ()> {
-        self.script_chan
+        self.script_chan()
             .send(SimulateColorScheme(self.pipeline_id(), theme))
             .map_err(|_| ())
     }
@@ -338,9 +352,18 @@ impl BrowsingContextActor {
         *self.active_outer_window_id.borrow()
     }
 
+    /// Returns the script sender for the active pipeline.
+    pub(crate) fn script_chan(&self) -> GenericSender<DevtoolScriptControlMsg> {
+        self.script_chans
+            .borrow()
+            .get(&self.pipeline_id())
+            .unwrap()
+            .clone()
+    }
+
     pub(crate) fn instruct_script_to_send_live_updates(&self, should_send_updates: bool) {
         let result = self
-            .script_chan
+            .script_chan()
             .send(DevtoolScriptControlMsg::WantsLiveNotifications(
                 self.pipeline_id(),
                 should_send_updates,
@@ -370,13 +393,13 @@ impl ActorEncode<BrowsingContextActorMsg> for BrowsingContextActor {
             browsing_context_id: self.browsing_context_id.value(),
             outer_window_id: self.outer_window_id().value(),
             is_top_level_target: true,
-            accessibility_actor: self.accessibility.clone(),
-            console_actor: self.console.clone(),
-            css_properties_actor: self.css_properties.clone(),
-            inspector_actor: self.inspector.clone(),
-            reflow_actor: self.reflow.clone(),
-            style_sheets_actor: self.style_sheets.clone(),
-            thread_actor: self.thread.clone(),
+            accessibility_actor: self.accessibility_name.clone(),
+            console_actor: self.console_name.clone(),
+            css_properties_actor: self.css_properties_name.clone(),
+            inspector_actor: self.inspector_name.clone(),
+            reflow_actor: self.reflow_name.clone(),
+            style_sheets_actor: self.style_sheets_name.clone(),
+            thread_actor: self.thread_name.clone(),
             target_type: TargetType::Frame,
         }
     }

components/devtools/actors/console.rs

@@ -7,31 +7,26 @@
 //! inspection, JS evaluation, autocompletion) in Servo.
 
 use std::collections::HashMap;
-use std::net::TcpStream;
 use std::sync::atomic::{AtomicBool, Ordering};
 
 use atomic_refcell::AtomicRefCell;
-use base::generic_channel::{self, GenericSender};
-use base::id::TEST_PIPELINE_ID;
-use devtools_traits::EvaluateJSReply::{
-    ActorValue, BooleanValue, NullValue, NumberValue, StringValue, VoidValue,
-};
 use devtools_traits::{
-    ConsoleArgument, ConsoleMessage, ConsoleMessageFields, DevtoolScriptControlMsg, PageError,
-    StackFrame, get_time_stamp,
+    ConsoleMessage, ConsoleMessageFields, DevtoolScriptControlMsg, PageError, StackFrame,
+    get_time_stamp,
 };
 use malloc_size_of_derive::MallocSizeOf;
 use serde::Serialize;
-use serde_json::{self, Map, Number, Value};
+use serde_json::{self, Map, Value};
+use servo_base::generic_channel::{self, GenericSender};
+use servo_base::id::TEST_PIPELINE_ID;
 use uuid::Uuid;
 
 use crate::actor::{Actor, ActorError, ActorRegistry};
 use crate::actors::browsing_context::BrowsingContextActor;
-use crate::actors::object::ObjectActor;
-use crate::actors::worker::WorkerActor;
-use crate::protocol::{ClientRequest, JsonPacketStream};
+use crate::actors::worker::WorkerTargetActor;
+use crate::protocol::{ClientRequest, DevtoolsConnection, JsonPacketStream};
 use crate::resource::{ResourceArrayType, ResourceAvailable};
-use crate::{EmptyReplyMsg, StreamId, UniqueId};
+use crate::{EmptyReplyMsg, StreamId, UniqueId, debugger_value_to_json};
 
 #[derive(Clone, Serialize, MallocSizeOf)]
 #[serde(rename_all = "camelCase")]
@@ -54,95 +49,13 @@ impl DevtoolsConsoleMessage {
             arguments: message
                 .arguments
                 .into_iter()
-                .map(|argument| console_argument_to_value(argument, registry))
+                .map(|argument| debugger_value_to_json(registry, argument))
                 .collect(),
             stacktrace: message.stacktrace,
         }
     }
 }
 
-fn console_argument_to_value(argument: ConsoleArgument, registry: &ActorRegistry) -> Value {
-    match argument {
-        ConsoleArgument::String(value) => Value::String(value),
-        ConsoleArgument::Integer(value) => Value::Number(value.into()),
-        ConsoleArgument::Number(value) => {
-            Number::from_f64(value).map(Value::from).unwrap_or_default()
-        },
-        ConsoleArgument::Boolean(value) => Value::Bool(value),
-        ConsoleArgument::Object(object) => {
-            // Create a new actor for the object.
-            // These are currently never cleaned up, and we make no attempt at re-using the same actor
-            // if the same object is logged repeatedly.
-            let actor = ObjectActor::register(registry, None);
-
-            #[derive(Serialize)]
-            struct PropertyDescriptor {
-                configurable: bool,
-                enumerable: bool,
-                writable: bool,
-                value: Value,
-            }
-
-            #[derive(Serialize)]
-            #[serde(rename_all = "camelCase")]
-            struct DevtoolsConsoleObjectArgument {
-                r#type: String,
-                actor: String,
-                class: String,
-                own_property_length: usize,
-                extensible: bool,
-                frozen: bool,
-                sealed: bool,
-                is_error: bool,
-                preview: DevtoolsConsoleObjectArgumentPreview,
-            }
-
-            #[derive(Serialize)]
-            #[serde(rename_all = "camelCase")]
-            struct DevtoolsConsoleObjectArgumentPreview {
-                kind: String,
-                own_properties: HashMap<String, PropertyDescriptor>,
-                own_properties_length: usize,
-            }
-
-            let own_properties: HashMap<String, PropertyDescriptor> = object
-                .own_properties
-                .into_iter()
-                .map(|property| {
-                    let property_descriptor = PropertyDescriptor {
-                        configurable: property.configurable,
-                        enumerable: property.enumerable,
-                        writable: property.writable,
-                        value: console_argument_to_value(property.value, registry),
-                    };
-
-                    (property.key, property_descriptor)
-                })
-                .collect();
-
-            let argument = DevtoolsConsoleObjectArgument {
-                r#type: "object".to_owned(),
-                actor,
-                class: object.class,
-                own_property_length: own_properties.len(),
-                extensible: true,
-                frozen: false,
-                sealed: false,
-                is_error: false,
-                preview: DevtoolsConsoleObjectArgumentPreview {
-                    kind: "Object".to_string(),
-                    own_properties_length: own_properties.len(),
-                    own_properties,
-                },
-            };
-
-            // to_value can fail if the implementation of Serialize fails or there are non-string map keys.
-            // Neither should be possible here
-            serde_json::to_value(argument).unwrap()
-        },
-    }
-}
-
 #[derive(Clone, Serialize, MallocSizeOf)]
 #[serde(rename_all = "camelCase")]
 struct DevtoolsPageError {
@@ -227,6 +140,7 @@ struct EvaluateJSReply {
     timestamp: u64,
     exception: Value,
     exception_message: Value,
+    has_exception: bool,
     helper_result: Value,
 }
 
@@ -243,6 +157,7 @@ struct EvaluateJSEvent {
     result_id: String,
     exception: Value,
     exception_message: Value,
+    has_exception: bool,
     helper_result: Value,
 }
 
@@ -279,36 +194,38 @@ pub(crate) struct ConsoleActor {
 }
 
 impl ConsoleActor {
-    pub fn new(name: String, root: Root) -> Self {
-        Self {
-            name,
+    pub fn register(registry: &ActorRegistry, name: String, root: Root) -> String {
+        let actor = Self {
+            name: name.clone(),
             root,
             cached_events: Default::default(),
             client_ready_to_receive_messages: false.into(),
-        }
+        };
+        registry.register(actor);
+        name
     }
 
     fn script_chan(&self, registry: &ActorRegistry) -> GenericSender<DevtoolScriptControlMsg> {
         match &self.root {
-            Root::BrowsingContext(browsing_context) => registry
-                .find::<BrowsingContextActor>(browsing_context)
-                .script_chan
+            Root::BrowsingContext(browsing_context_name) => registry
+                .find::<BrowsingContextActor>(browsing_context_name)
+                .script_chan(),
+            Root::DedicatedWorker(worker_name) => registry
+                .find::<WorkerTargetActor>(worker_name)
+                .script_sender
                 .clone(),
-            Root::DedicatedWorker(worker) => {
-                registry.find::<WorkerActor>(worker).script_chan.clone()
-            },
         }
     }
 
     fn current_unique_id(&self, registry: &ActorRegistry) -> UniqueId {
         match &self.root {
-            Root::BrowsingContext(browsing_context) => UniqueId::Pipeline(
+            Root::BrowsingContext(browsing_context_name) => UniqueId::Pipeline(
                 registry
-                    .find::<BrowsingContextActor>(browsing_context)
+                    .find::<BrowsingContextActor>(browsing_context_name)
                     .pipeline_id(),
             ),
-            Root::DedicatedWorker(worker) => {
-                UniqueId::Worker(registry.find::<WorkerActor>(worker).worker_id)
+            Root::DedicatedWorker(worker_name) => {
+                UniqueId::Worker(registry.find::<WorkerTargetActor>(worker_name).worker_id)
             },
         }
     }
@@ -319,79 +236,39 @@ impl ConsoleActor {
         msg: &Map<String, Value>,
     ) -> Result<EvaluateJSReply, ()> {
         let input = msg.get("text").unwrap().as_str().unwrap().to_owned();
+        let frame_actor_id = msg
+            .get("frameActor")
+            .and_then(|v| v.as_str())
+            .map(String::from);
         let (chan, port) = generic_channel::channel().unwrap();
-        // FIXME: Redesign messages so we don't have to fake pipeline ids when
-        //        communicating with workers.
+        // FIXME: Redesign messages so we don't have to fake pipeline ids when communicating with workers.
         let pipeline = match self.current_unique_id(registry) {
             UniqueId::Pipeline(p) => p,
             UniqueId::Worker(_) => TEST_PIPELINE_ID,
         };
         self.script_chan(registry)
-            .send(DevtoolScriptControlMsg::Eval(input.clone(), pipeline, chan))
+            .send(DevtoolScriptControlMsg::Eval(
+                input.clone(),
+                pipeline,
+                frame_actor_id,
+                chan,
+            ))
             .unwrap();
 
-        // TODO: Extract conversion into protocol module or some other useful place
-        let result = match port.recv().map_err(|_| ())? {
-            VoidValue => {
-                let mut m = Map::new();
-                m.insert("type".to_owned(), Value::String("undefined".to_owned()));
-                Value::Object(m)
-            },
-            NullValue => {
-                let mut m = Map::new();
-                m.insert("type".to_owned(), Value::String("null".to_owned()));
-                Value::Object(m)
-            },
-            BooleanValue(val) => Value::Bool(val),
-            NumberValue(val) => {
-                if val.is_nan() {
-                    let mut m = Map::new();
-                    m.insert("type".to_owned(), Value::String("NaN".to_owned()));
-                    Value::Object(m)
-                } else if val.is_infinite() {
-                    let mut m = Map::new();
-                    if val < 0. {
-                        m.insert("type".to_owned(), Value::String("-Infinity".to_owned()));
-                    } else {
-                        m.insert("type".to_owned(), Value::String("Infinity".to_owned()));
-                    }
-                    Value::Object(m)
-                } else if val == 0. && val.is_sign_negative() {
-                    let mut m = Map::new();
-                    m.insert("type".to_owned(), Value::String("-0".to_owned()));
-                    Value::Object(m)
-                } else {
-                    Value::Number(Number::from_f64(val).unwrap())
-                }
-            },
-            StringValue(s) => Value::String(s),
-            ActorValue { class, uuid } => {
-                // TODO: Make initial ActorValue message include these properties?
-                let mut m = Map::new();
-                let actor = ObjectActor::register(registry, Some(uuid));
+        let eval_result = port.recv().map_err(|_| ())?;
+        let has_exception = eval_result.has_exception;
 
-                m.insert("type".to_owned(), Value::String("object".to_owned()));
-                m.insert("class".to_owned(), Value::String(class));
-                m.insert("actor".to_owned(), Value::String(actor));
-                m.insert("extensible".to_owned(), Value::Bool(true));
-                m.insert("frozen".to_owned(), Value::Bool(false));
-                m.insert("sealed".to_owned(), Value::Bool(false));
-                Value::Object(m)
-            },
-        };
-
-        // TODO: Catch and return exception values from JS evaluation
-        // TODO: This should have a has_exception field
         let reply = EvaluateJSReply {
             from: self.name(),
             input,
-            result,
+            result: debugger_value_to_json(registry, eval_result.value),
             timestamp: get_time_stamp(),
             exception: Value::Null,
             exception_message: Value::Null,
+            has_exception,
             helper_result: Value::Null,
         };
-        std::result::Result::Ok(reply)
+        Ok(reply)
     }
 
     pub(crate) fn handle_console_resource(
@@ -399,7 +276,7 @@ impl ConsoleActor {
         resource: ConsoleResource,
         id: UniqueId,
         registry: &ActorRegistry,
-        stream: &mut TcpStream,
+        stream: &mut DevtoolsConnection,
     ) {
         self.cached_events
             .borrow_mut()
@@ -414,13 +291,15 @@ impl ConsoleActor {
         }
         let resource_type = resource.resource_type();
         if id == self.current_unique_id(registry) {
-            if let Root::BrowsingContext(bc) = &self.root {
-                registry.find::<BrowsingContextActor>(bc).resource_array(
-                    resource,
-                    resource_type,
-                    ResourceArrayType::Available,
-                    stream,
-                )
+            if let Root::BrowsingContext(browsing_context_name) = &self.root {
+                registry
+                    .find::<BrowsingContextActor>(browsing_context_name)
+                    .resource_array(
+                        resource,
+                        resource_type,
+                        ResourceArrayType::Available,
+                        stream,
+                    )
             };
         }
     }
@@ -429,18 +308,20 @@ impl ConsoleActor {
         &self,
         id: UniqueId,
         registry: &ActorRegistry,
-        stream: &mut TcpStream,
+        stream: &mut DevtoolsConnection,
     ) {
         if id == self.current_unique_id(registry) {
-            if let Root::BrowsingContext(bc) = &self.root {
-                registry.find::<BrowsingContextActor>(bc).resource_array(
-                    ConsoleClearMessage {
-                        level: "clear".to_owned(),
-                    },
-                    "console-message".into(),
-                    ResourceArrayType::Available,
-                    stream,
-                )
+            if let Root::BrowsingContext(browsing_context_name) = &self.root {
+                registry
+                    .find::<BrowsingContextActor>(browsing_context_name)
+                    .resource_array(
+                        ConsoleClearMessage {
+                            level: "clear".to_owned(),
+                        },
+                        "console-message".into(),
+                        ResourceArrayType::Available,
+                        stream,
+                    )
             };
         }
     }
@@ -514,7 +395,7 @@ impl Actor for ConsoleActor {
                 };
                 // Emit an eager reply so that the client starts listening
                 // for an async event with the resultID
-                let stream = request.reply(&early_reply)?;
+                let mut stream = request.reply(&early_reply)?;
 
                 if msg.get("eager").and_then(|v| v.as_bool()).unwrap_or(false) {
                     // We don't support the side-effect free evaluation that eager evaluation
@@ -532,6 +413,7 @@ impl Actor for ConsoleActor {
                     result_id,
                     exception: reply.exception,
                     exception_message: reply.exception_message,
+                    has_exception: reply.has_exception,
                     helper_result: reply.helper_result,
                 };
                 // Send the data from evaluateJS along with a resultID

components/devtools/actors/device.rs

@@ -60,7 +60,7 @@ impl Actor for DeviceActor {
                         apptype: "servo".to_string(),
                         version: env!("CARGO_PKG_VERSION").to_string(),
                         appbuildid: BUILD_ID.to_string(),
-                        platformversion: "145.0".to_string(),
+                        platformversion: "146.0".to_string(),
                         brand_name: "Servo".to_string(),
                     },
                 };
@@ -74,8 +74,11 @@ impl Actor for DeviceActor {
 }
 
 impl DeviceActor {
-    pub fn new(name: String) -> DeviceActor {
-        DeviceActor { name }
+    pub fn register(registry: &ActorRegistry) -> String {
+        let name = registry.new_name::<Self>();
+        let actor = DeviceActor { name: name.clone() };
+        registry.register::<Self>(actor);
+        name
     }
 
     pub fn description() -> ActorDescription {

components/devtools/actors/environment.rs

@@ -2,32 +2,20 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
+use std::collections::HashMap;
+
+use devtools_traits::EnvironmentInfo;
 use malloc_size_of_derive::MallocSizeOf;
 use serde::Serialize;
-use serde_json::{Map, Value};
+use serde_json::Value;
 
 use crate::actor::{Actor, ActorEncode, ActorRegistry};
-use crate::actors::object::ObjectActorMsg;
-
-#[derive(Serialize)]
-#[serde(rename_all = "camelCase")]
-pub enum EnvironmentType {
-    Function,
-    _Block,
-    _Object,
-}
-
-#[derive(Serialize)]
-#[serde(rename_all = "camelCase")]
-pub enum EnvironmentScope {
-    Function,
-    _Global,
-}
+use crate::actors::object::{ObjectActorMsg, ObjectPropertyDescriptor};
 
 #[derive(Serialize)]
 struct EnvironmentBindings {
     arguments: Vec<Value>,
-    variables: Map<String, Value>,
+    variables: HashMap<String, ObjectPropertyDescriptor>,
 }
 
 #[derive(Serialize)]
@@ -41,8 +29,8 @@ struct EnvironmentFunction {
 pub(crate) struct EnvironmentActorMsg {
     actor: String,
     #[serde(rename = "type")]
-    type_: EnvironmentType,
-    scope_kind: EnvironmentScope,
+    type_: Option<String>,
+    scope_kind: Option<String>,
     #[serde(skip_serializing_if = "Option::is_none")]
     parent: Option<Box<EnvironmentActorMsg>>,
     #[serde(skip_serializing_if = "Option::is_none")]
@@ -60,8 +48,9 @@ pub(crate) struct EnvironmentActorMsg {
 /// <https://searchfox.org/firefox-main/source/devtools/server/actors/environment.js>
 #[derive(MallocSizeOf)]
 pub(crate) struct EnvironmentActor {
-    pub name: String,
-    pub parent: Option<String>,
+    name: String,
+    environment: EnvironmentInfo,
+    parent_name: Option<String>,
 }
 
 impl Actor for EnvironmentActor {
@@ -70,22 +59,60 @@ impl Actor for EnvironmentActor {
     }
 }
 
+impl EnvironmentActor {
+    pub fn register(
+        registry: &ActorRegistry,
+        environment: EnvironmentInfo,
+        parent_name: Option<String>,
+    ) -> String {
+        let environment_name = registry.new_name::<Self>();
+        let environment_actor = Self {
+            name: environment_name.clone(),
+            parent_name,
+            environment,
+        };
+        registry.register(environment_actor);
+        environment_name
+    }
+}
+
 impl ActorEncode<EnvironmentActorMsg> for EnvironmentActor {
     fn encode(&self, registry: &ActorRegistry) -> EnvironmentActorMsg {
         let parent = self
-            .parent
+            .parent_name
             .as_ref()
             .map(|p| registry.find::<EnvironmentActor>(p))
             .map(|p| Box::new(p.encode(registry)));
         // TODO: Change hardcoded values.
         EnvironmentActorMsg {
             actor: self.name(),
-            type_: EnvironmentType::Function,
-            scope_kind: EnvironmentScope::Function,
+            type_: self.environment.type_.clone(),
+            scope_kind: self.environment.scope_kind.clone(),
             parent,
-            bindings: None,
-            function: None,
+            function: self
+                .environment
+                .function_display_name
+                .clone()
+                .map(|display_name| EnvironmentFunction { display_name }),
             object: None,
+            bindings: Some(EnvironmentBindings {
+                arguments: [].to_vec(),
+                variables: self
+                    .environment
+                    .binding_variables
+                    .clone()
+                    .into_iter()
+                    .map(|ref property_descriptor| {
+                        (
+                            property_descriptor.name.clone(),
+                            ObjectPropertyDescriptor::from_property_descriptor(
+                                registry,
+                                property_descriptor,
+                            ),
+                        )
+                    })
+                    .collect(),
+            }),
         }
     }
 }

components/devtools/actors/frame.rs

@@ -3,16 +3,18 @@
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
 use atomic_refcell::AtomicRefCell;
-use devtools_traits::FrameInfo;
+use devtools_traits::{DevtoolScriptControlMsg, FrameInfo};
 use malloc_size_of_derive::MallocSizeOf;
 use serde::Serialize;
 use serde_json::{Map, Value};
+use servo_base::generic_channel::channel;
 
 use crate::StreamId;
 use crate::actor::{Actor, ActorEncode, ActorError, ActorRegistry};
 use crate::actors::environment::{EnvironmentActor, EnvironmentActorMsg};
 use crate::actors::object::{ObjectActor, ObjectActorMsg};
-use crate::protocol::ClientRequest;
+use crate::actors::source::SourceActor;
+use crate::protocol::{ClientRequest, JsonPacketStream};
 
 #[derive(Serialize)]
 struct FrameEnvironmentReply {
@@ -58,7 +60,7 @@ pub(crate) struct FrameActorMsg {
 pub(crate) struct FrameActor {
     name: String,
     object_actor: String,
-    source_actor: String,
+    source_name: String,
     frame_result: FrameInfo,
     current_offset: AtomicRefCell<(u32, u32)>,
 }
@@ -71,7 +73,7 @@ impl Actor for FrameActor {
     // https://searchfox.org/firefox-main/source/devtools/shared/specs/frame.js
     fn handle_message(
         &self,
-        request: ClientRequest,
+        mut request: ClientRequest,
         registry: &ActorRegistry,
         msg_type: &str,
         _msg: &Map<String, Value>,
@@ -79,18 +81,24 @@ impl Actor for FrameActor {
     ) -> Result<(), ActorError> {
         match msg_type {
             "getEnvironment" => {
-                let environment = EnvironmentActor {
-                    name: registry.new_name::<EnvironmentActor>(),
-                    parent: None,
+                let Some((tx, rx)) = channel() else {
+                    return Err(ActorError::Internal);
                 };
+                let source_actor = registry.find::<SourceActor>(&self.source_name);
+                source_actor
+                    .script_sender
+                    .send(DevtoolScriptControlMsg::GetEnvironment(self.name(), tx))
+                    .map_err(|_| ActorError::Internal)?;
+                let environment_name = rx.recv().map_err(|_| ActorError::Internal)?;
+
                 let msg = FrameEnvironmentReply {
                     from: self.name(),
-                    environment: environment.encode(registry),
+                    environment: registry.encode::<EnvironmentActor, _>(&environment_name),
                 };
-                registry.register(environment);
                 // This reply has a `type` field but it doesn't need a followup,
                 // unlike most messages. We need to skip the validity check.
-                request.reply_unchecked(&msg)?;
+                request.write_json_packet(&msg)?;
+                request.mark_handled();
             },
             _ => return Err(ActorError::UnrecognizedPacketType),
         };
@@ -101,16 +109,16 @@ impl Actor for FrameActor {
 impl FrameActor {
     pub fn register(
         registry: &ActorRegistry,
-        source_actor: String,
+        source_name: String,
         frame_result: FrameInfo,
     ) -> String {
-        let object_actor = ObjectActor::register(registry, None);
+        let object_name = ObjectActor::register(registry, None, "Object".to_owned(), None);
 
         let name = registry.new_name::<Self>();
         let actor = Self {
             name: name.clone(),
-            object_actor,
-            source_actor,
+            object_actor: object_name,
+            source_name,
             frame_result,
             current_offset: Default::default(),
         };
@@ -145,7 +153,7 @@ impl ActorEncode<FrameActorMsg> for FrameActor {
             oldest: self.frame_result.oldest,
             state,
             where_: FrameWhere {
-                actor: self.source_actor.clone(),
+                actor: self.source_name.clone(),
                 line,
                 column,
             },

components/devtools/actors/framerate.rs

@@ -5,10 +5,10 @@
 use std::mem;
 
 use atomic_refcell::AtomicRefCell;
-use base::generic_channel::GenericSender;
-use base::id::PipelineId;
 use devtools_traits::DevtoolScriptControlMsg;
 use malloc_size_of_derive::MallocSizeOf;
+use servo_base::generic_channel::GenericSender;
+use servo_base::id::PipelineId;
 
 use crate::actor::{Actor, ActorRegistry};
 use crate::actors::timeline::HighResolutionStamp;

components/devtools/actors/inspector.rs

@@ -4,10 +4,6 @@
 
 //! Liberally derived from the [Firefox JS implementation](http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/inspector.js).
 
-use atomic_refcell::AtomicRefCell;
-use base::generic_channel::GenericSender;
-use base::id::PipelineId;
-use devtools_traits::DevtoolScriptControlMsg;
 use malloc_size_of_derive::MallocSizeOf;
 use serde::Serialize;
 use serde_json::{self, Map, Value};
@@ -20,11 +16,13 @@ use crate::protocol::ClientRequest;
 use crate::{ActorMsg, StreamId};
 
 pub mod accessibility;
+pub mod accessible_walker;
 pub mod css_properties;
 pub mod highlighter;
 pub mod layout;
 pub mod node;
 pub mod page_style;
+pub mod simulator;
 pub mod style_rule;
 pub mod walker;
 
@@ -56,9 +54,9 @@ struct SupportsHighlightersReply {
 #[derive(MallocSizeOf)]
 pub(crate) struct InspectorActor {
     name: String,
-    highlighter: String,
-    page_style: String,
-    pub(crate) walker: String,
+    highlighter_name: String,
+    page_style_name: String,
+    pub(crate) walker_name: String,
 }
 
 impl Actor for InspectorActor {
@@ -78,7 +76,7 @@ impl Actor for InspectorActor {
             "getPageStyle" => {
                 let msg = GetPageStyleReply {
                     from: self.name(),
-                    page_style: registry.encode::<PageStyleActor, _>(&self.page_style),
+                    page_style: registry.encode::<PageStyleActor, _>(&self.page_style_name),
                 };
                 request.reply_final(&msg)?
             },
@@ -86,7 +84,7 @@ impl Actor for InspectorActor {
             "getHighlighterByType" => {
                 let msg = GetHighlighterReply {
                     from: self.name(),
-                    highlighter: registry.encode::<HighlighterActor, _>(&self.highlighter),
+                    highlighter: registry.encode::<HighlighterActor, _>(&self.highlighter_name),
                 };
                 request.reply_final(&msg)?
             },
@@ -94,7 +92,7 @@ impl Actor for InspectorActor {
             "getWalker" => {
                 let msg = GetWalkerReply {
                     from: self.name(),
-                    walker: registry.encode::<WalkerActor, _>(&self.walker),
+                    walker: registry.encode::<WalkerActor, _>(&self.walker_name),
                 };
                 request.reply_final(&msg)?
             },
@@ -114,45 +112,23 @@ impl Actor for InspectorActor {
 }
 
 impl InspectorActor {
-    // TODO: Passing the pipeline id here isn't correct. We should query the browsing
-    // context for the active pipeline, otherwise reloading or navigating will break the inspector.
-    pub fn register(
-        registry: &ActorRegistry,
-        pipeline: PipelineId,
-        script_chan: GenericSender<DevtoolScriptControlMsg>,
-    ) -> String {
-        let highlighter = HighlighterActor {
-            name: registry.new_name::<HighlighterActor>(),
-            script_sender: script_chan.clone(),
-            pipeline,
-        };
+    pub fn register(registry: &ActorRegistry, browsing_context_name: String) -> String {
+        let highlighter_name = HighlighterActor::register(registry, browsing_context_name.clone());
 
-        let page_style = PageStyleActor {
-            name: registry.new_name::<PageStyleActor>(),
-            script_chan: script_chan.clone(),
-            pipeline,
-        };
+        let page_style_name = PageStyleActor::register(registry);
 
-        let walker = WalkerActor {
-            name: registry.new_name::<WalkerActor>(),
-            mutations: AtomicRefCell::new(vec![]),
-            script_chan,
-            pipeline,
-        };
+        let walker_name = WalkerActor::register(registry, browsing_context_name);
 
-        let actor = Self {
+        let inspector_actor = Self {
             name: registry.new_name::<InspectorActor>(),
-            highlighter: highlighter.name(),
-            page_style: page_style.name(),
-            walker: walker.name(),
+            highlighter_name,
+            page_style_name,
+            walker_name,
         };
-        let name = actor.name();
+        let inspector_name = inspector_actor.name();
 
-        registry.register(highlighter);
-        registry.register(page_style);
-        registry.register(walker);
-        registry.register(actor);
+        registry.register(inspector_actor);
 
-        name
+        inspector_name
     }
 }

components/devtools/actors/inspector/accessibility.rs

@@ -11,6 +11,8 @@ use serde_json::{Map, Value};
 
 use crate::StreamId;
 use crate::actor::{Actor, ActorError, ActorRegistry};
+use crate::actors::inspector::accessible_walker::AccessibleWalkerActor;
+use crate::actors::inspector::simulator::SimulatorActor;
 use crate::protocol::ClientRequest;
 
 #[derive(Serialize)]
@@ -90,14 +92,11 @@ impl Actor for AccessibilityActor {
                 request.reply_final(&msg)?
             },
             "getSimulator" => {
-                // TODO: Create actual simulator
-                let actor = registry.new_name::<SimulatorActor>();
-                registry.register(SimulatorActor {
-                    name: actor.clone(),
-                });
                 let msg = GetSimulatorReply {
                     from: self.name(),
-                    simulator: ActorMsg { actor },
+                    simulator: ActorMsg {
+                        actor: SimulatorActor::register(registry),
+                    },
                 };
                 request.reply_final(&msg)?
             },
@@ -111,14 +110,11 @@ impl Actor for AccessibilityActor {
                 request.reply_final(&msg)?
             },
             "getWalker" => {
-                // TODO: Create actual accessible walker
-                let actor = registry.new_name::<AccessibleWalkerActor>();
-                registry.register(AccessibleWalkerActor {
-                    name: actor.clone(),
-                });
                 let msg = GetWalkerReply {
                     from: self.name(),
-                    walker: ActorMsg { actor },
+                    walker: ActorMsg {
+                        actor: AccessibleWalkerActor::register(registry),
+                    },
                 };
                 request.reply_final(&msg)?
             },
@@ -129,29 +125,10 @@ impl Actor for AccessibilityActor {
 }
 
 impl AccessibilityActor {
-    pub fn new(name: String) -> Self {
-        Self { name }
-    }
-}
-
-#[derive(MallocSizeOf)]
-pub(crate) struct SimulatorActor {
-    name: String,
-}
-
-impl Actor for SimulatorActor {
-    fn name(&self) -> String {
-        self.name.clone()
-    }
-}
-
-#[derive(MallocSizeOf)]
-pub(crate) struct AccessibleWalkerActor {
-    name: String,
-}
-
-impl Actor for AccessibleWalkerActor {
-    fn name(&self) -> String {
-        self.name.clone()
+    pub fn register(registry: &ActorRegistry) -> String {
+        let name = registry.new_name::<Self>();
+        let actor = Self { name: name.clone() };
+        registry.register::<Self>(actor);
+        name
     }
 }